Display resolution changes don't work in mushrome |
||||||
Issue descriptionChanging the display resolution in mushrome doesn't work. Steps to reproduce. 1. Run mus with the following command on Ozone X11. $ ./chrome --mus --ash-debug-shortcuts --ash-dev-shortcuts --screen-config=1600x900#1280x720:1920x1080 2. Open display settings and change the display resolution. Output to the display is broken at this point. A few things are happening incorrectly here: 1. PlatformWindow is never resized. 2. The root ServerWindow for the WM never gets resized or a new LocalSurfaceId allocated. 3. A ServerWindow that sits between the Display root and WM root in the window hierarchy gets resized but this has no effect.
,
Aug 14 2017
,
Aug 14 2017
,
Aug 16 2017
,
Aug 16 2017
It looks like all the ServerWindows get resized, but the platform window doesn't change size, nor does the display id.
,
Aug 17 2017
Yep, the PlatformWindow doesn't change size and even if it did then ash won't draw until it gets a new SurfaceId. This is the CL I had to fix it, I didn't have a chance to improve on it though: https://chromium-review.googlesource.com/c/527473
,
Aug 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3dc5f87e04d857e0d6f59e2b25a35b43e3eaf8d8 commit 3dc5f87e04d857e0d6f59e2b25a35b43e3eaf8d8 Author: Scott Violet <sky@chromium.org> Date: Mon Aug 21 22:00:28 2017 chromeos: gets display updates working on mus The following changes were needed: . WindowTreeClient needed to update the LocalSurfaceId when the bounds of the window associated with the WindowTreeHost change. . DisplayManager needed to call UpdateViewportMetrics after a bounds change of the root. This ensures the PlatformDisplay updates. BUG= 730616 TEST=covered by tests Change-Id: Ib805e876220b58d086964bc8fcb149c2bb34bfe8 Reviewed-on: https://chromium-review.googlesource.com/621257 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#496074} [modify] https://crrev.com/3dc5f87e04d857e0d6f59e2b25a35b43e3eaf8d8/services/ui/ws/display_manager.cc [modify] https://crrev.com/3dc5f87e04d857e0d6f59e2b25a35b43e3eaf8d8/services/ui/ws/display_manager.h [modify] https://crrev.com/3dc5f87e04d857e0d6f59e2b25a35b43e3eaf8d8/services/ui/ws/test_utils.h [modify] https://crrev.com/3dc5f87e04d857e0d6f59e2b25a35b43e3eaf8d8/services/ui/ws/window_tree.cc [modify] https://crrev.com/3dc5f87e04d857e0d6f59e2b25a35b43e3eaf8d8/services/ui/ws/window_tree.h [modify] https://crrev.com/3dc5f87e04d857e0d6f59e2b25a35b43e3eaf8d8/services/ui/ws/window_tree_unittest.cc [modify] https://crrev.com/3dc5f87e04d857e0d6f59e2b25a35b43e3eaf8d8/ui/aura/mus/window_tree_client.cc [modify] https://crrev.com/3dc5f87e04d857e0d6f59e2b25a35b43e3eaf8d8/ui/aura/test/mus/change_completion_waiter.cc [modify] https://crrev.com/3dc5f87e04d857e0d6f59e2b25a35b43e3eaf8d8/ui/aura/test/mus/change_completion_waiter.h [modify] https://crrev.com/3dc5f87e04d857e0d6f59e2b25a35b43e3eaf8d8/ui/views/mus/drag_interactive_uitest.cc
,
Aug 21 2017
,
Jan 22 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by kylec...@chromium.org
, Jun 7 2017Labels: -Pri-3 mustash-display Proj-Mustash-Mus-WS OS-Chrome Pri-2
Owner: kylec...@chromium.org
Status: Started (was: Untriaged)