Handle the X-Chrome-ID-Consistency-Response that can be sent by Gaia for account consistency.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d5c7b158fb963fea6f63a568a610ddf43f72426 commit 2d5c7b158fb963fea6f63a568a610ddf43f72426 Author: droger <droger@chromium.org> Date: Mon Jun 12 16:59:35 2017 [signin] Move Mirror code to ChromeConnectedHeaderHelper This is a refactoring/cleanup, to prepare for DICE response handling. BUG= 730589 Review-Url: https://codereview.chromium.org/2925083002 Cr-Commit-Position: refs/heads/master@{#478664} [modify] https://crrev.com/2d5c7b158fb963fea6f63a568a610ddf43f72426/chrome/browser/signin/chrome_signin_helper.cc [modify] https://crrev.com/2d5c7b158fb963fea6f63a568a610ddf43f72426/components/signin/core/browser/chrome_connected_header_helper.cc [modify] https://crrev.com/2d5c7b158fb963fea6f63a568a610ddf43f72426/components/signin/core/browser/chrome_connected_header_helper.h [modify] https://crrev.com/2d5c7b158fb963fea6f63a568a610ddf43f72426/components/signin/core/browser/signin_header_helper.cc [modify] https://crrev.com/2d5c7b158fb963fea6f63a568a610ddf43f72426/components/signin/core/browser/signin_header_helper.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0bf70fdccf4a551f4df5241ccd52b3370f3727b commit c0bf70fdccf4a551f4df5241ccd52b3370f3727b Author: droger <droger@chromium.org> Date: Tue Jun 13 13:02:45 2017 [Dice] Parse the Dice response header BUG= 730589 Review-Url: https://codereview.chromium.org/2918403009 Cr-Commit-Position: refs/heads/master@{#478990} [modify] https://crrev.com/c0bf70fdccf4a551f4df5241ccd52b3370f3727b/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc [modify] https://crrev.com/c0bf70fdccf4a551f4df5241ccd52b3370f3727b/chrome/browser/signin/chrome_signin_helper.cc [modify] https://crrev.com/c0bf70fdccf4a551f4df5241ccd52b3370f3727b/chrome/browser/signin/chrome_signin_helper.h [modify] https://crrev.com/c0bf70fdccf4a551f4df5241ccd52b3370f3727b/components/signin/core/browser/dice_header_helper.cc [modify] https://crrev.com/c0bf70fdccf4a551f4df5241ccd52b3370f3727b/components/signin/core/browser/dice_header_helper.h [modify] https://crrev.com/c0bf70fdccf4a551f4df5241ccd52b3370f3727b/components/signin/core/browser/signin_header_helper.cc [modify] https://crrev.com/c0bf70fdccf4a551f4df5241ccd52b3370f3727b/components/signin/core/browser/signin_header_helper.h [modify] https://crrev.com/c0bf70fdccf4a551f4df5241ccd52b3370f3727b/components/signin/core/browser/signin_header_helper_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c51029f7f3e25be2a0d2a9c54263c43660990be commit 7c51029f7f3e25be2a0d2a9c54263c43660990be Author: droger <droger@chromium.org> Date: Thu Jun 22 13:51:27 2017 [signin] Generate OAuth token on Dice Signin responses Introduces the DiceResponseHandler class to handle the Dice responses, which is a new profile keyed service. In this CL, only the SIGNIN response is implemented, and triggers a OAuth2 token request. BUG= 730589 Review-Url: https://codereview.chromium.org/2942193002 Cr-Commit-Position: refs/heads/master@{#481518} [modify] https://crrev.com/7c51029f7f3e25be2a0d2a9c54263c43660990be/chrome/browser/BUILD.gn [modify] https://crrev.com/7c51029f7f3e25be2a0d2a9c54263c43660990be/chrome/browser/signin/chrome_signin_helper.cc [add] https://crrev.com/7c51029f7f3e25be2a0d2a9c54263c43660990be/chrome/browser/signin/dice_response_handler.cc [add] https://crrev.com/7c51029f7f3e25be2a0d2a9c54263c43660990be/chrome/browser/signin/dice_response_handler.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2290d78497eb6de3d0614ef252daebdf98855167 commit 2290d78497eb6de3d0614ef252daebdf98855167 Author: droger <droger@chromium.org> Date: Fri Jun 23 13:19:31 2017 [signin] Unit test for DiceResponseHandler BUG= 730589 Review-Url: https://codereview.chromium.org/2947853002 Cr-Commit-Position: refs/heads/master@{#481864} [add] https://crrev.com/2290d78497eb6de3d0614ef252daebdf98855167/chrome/browser/signin/dice_response_handler_unittest.cc [modify] https://crrev.com/2290d78497eb6de3d0614ef252daebdf98855167/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83cad2ae0c47202e124c910ce8f710fda13cf838 commit 83cad2ae0c47202e124c910ce8f710fda13cf838 Author: droger <droger@chromium.org> Date: Fri Jun 23 14:40:21 2017 [Signin] Handle multiple concurrent Dice responses This CL adds support for handling multiple concurrent Dice responses. BUG= 730589 Review-Url: https://codereview.chromium.org/2950073002 Cr-Commit-Position: refs/heads/master@{#481882} [modify] https://crrev.com/83cad2ae0c47202e124c910ce8f710fda13cf838/chrome/browser/signin/dice_response_handler.cc [modify] https://crrev.com/83cad2ae0c47202e124c910ce8f710fda13cf838/chrome/browser/signin/dice_response_handler.h [modify] https://crrev.com/83cad2ae0c47202e124c910ce8f710fda13cf838/chrome/browser/signin/dice_response_handler_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/159a49c29c076f9c5583c4607ca6965cd5ec4722 commit 159a49c29c076f9c5583c4607ca6965cd5ec4722 Author: droger <droger@chromium.org> Date: Fri Jun 23 15:57:49 2017 [Signin] Add timeout to Dice token exchange requests BUG= 730589 Review-Url: https://codereview.chromium.org/2951263002 Cr-Commit-Position: refs/heads/master@{#481906} [modify] https://crrev.com/159a49c29c076f9c5583c4607ca6965cd5ec4722/chrome/browser/signin/dice_response_handler.cc [modify] https://crrev.com/159a49c29c076f9c5583c4607ca6965cd5ec4722/chrome/browser/signin/dice_response_handler.h [modify] https://crrev.com/159a49c29c076f9c5583c4607ca6965cd5ec4722/chrome/browser/signin/dice_response_handler_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3fc057c54155174850badc5c6b3bfd9b1ec2d955 commit 3fc057c54155174850badc5c6b3bfd9b1ec2d955 Author: droger <droger@chromium.org> Date: Fri Jun 23 17:02:27 2017 [Signin] Rename obfuscated_gaia_id into gaia_id BUG= 730589 Review-Url: https://codereview.chromium.org/2944383006 Cr-Commit-Position: refs/heads/master@{#481935} [modify] https://crrev.com/3fc057c54155174850badc5c6b3bfd9b1ec2d955/chrome/browser/signin/dice_response_handler.cc [modify] https://crrev.com/3fc057c54155174850badc5c6b3bfd9b1ec2d955/chrome/browser/signin/dice_response_handler_unittest.cc [modify] https://crrev.com/3fc057c54155174850badc5c6b3bfd9b1ec2d955/components/signin/core/browser/dice_header_helper.cc [modify] https://crrev.com/3fc057c54155174850badc5c6b3bfd9b1ec2d955/components/signin/core/browser/signin_header_helper.h [modify] https://crrev.com/3fc057c54155174850badc5c6b3bfd9b1ec2d955/components/signin/core/browser/signin_header_helper_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17b48e52235ed23509c756d976cfa6871ef3c2d6 commit 17b48e52235ed23509c756d976cfa6871ef3c2d6 Author: droger <droger@chromium.org> Date: Sun Jun 25 13:08:56 2017 [signin] Add unit test for Gaia error in DiceResponseHandler BUG= 730589 Review-Url: https://codereview.chromium.org/2953673003 Cr-Commit-Position: refs/heads/master@{#482172} [modify] https://crrev.com/17b48e52235ed23509c756d976cfa6871ef3c2d6/chrome/browser/signin/dice_response_handler_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a3530331759f8edfb4ee8e595fa9f11bb5cb5670 commit a3530331759f8edfb4ee8e595fa9f11bb5cb5670 Author: David Roger <droger@google.com> Date: Fri Jun 30 13:52:22 2017 [Signin] Handle Google-Accounts-SignOut for Dice This CL intercepts the Google-Accounts-Signout header and implements the signout flow. Main changes: - Since multiple accounts can be specified, DiceResponseParams has now a vector of accounts. - Since header parameters can be repeated, the parsing function now uses std::multimap instead of std::map. - Since header parameters contain whitespace and quotes, additional sanitization is performed. - Since this header is not set on redirect, ProcessDiceResponseHeaderIfExists() is now called on all requests. - DiceResponseHandler now implements the signout flow. Bug: 730589 Change-Id: I334e9a884a2d40e8f614870a77c9db0e1cc67cb5 Reviewed-on: https://chromium-review.googlesource.com/548359 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#483691} [modify] https://crrev.com/a3530331759f8edfb4ee8e595fa9f11bb5cb5670/chrome/browser/signin/chrome_signin_helper.cc [modify] https://crrev.com/a3530331759f8edfb4ee8e595fa9f11bb5cb5670/chrome/browser/signin/dice_response_handler.cc [modify] https://crrev.com/a3530331759f8edfb4ee8e595fa9f11bb5cb5670/chrome/browser/signin/dice_response_handler.h [modify] https://crrev.com/a3530331759f8edfb4ee8e595fa9f11bb5cb5670/chrome/browser/signin/dice_response_handler_unittest.cc [modify] https://crrev.com/a3530331759f8edfb4ee8e595fa9f11bb5cb5670/components/signin/core/browser/dice_header_helper.cc [modify] https://crrev.com/a3530331759f8edfb4ee8e595fa9f11bb5cb5670/components/signin/core/browser/dice_header_helper.h [modify] https://crrev.com/a3530331759f8edfb4ee8e595fa9f11bb5cb5670/components/signin/core/browser/fake_signin_manager.cc [modify] https://crrev.com/a3530331759f8edfb4ee8e595fa9f11bb5cb5670/components/signin/core/browser/fake_signin_manager.h [modify] https://crrev.com/a3530331759f8edfb4ee8e595fa9f11bb5cb5670/components/signin/core/browser/signin_header_helper.cc [modify] https://crrev.com/a3530331759f8edfb4ee8e595fa9f11bb5cb5670/components/signin/core/browser/signin_header_helper.h [modify] https://crrev.com/a3530331759f8edfb4ee8e595fa9f11bb5cb5670/components/signin/core/browser/signin_header_helper_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9fad1a8bfd4c8202df7ed7ad1ff1145baefc08c0 commit 9fad1a8bfd4c8202df7ed7ad1ff1145baefc08c0 Author: David Roger <droger@google.com> Date: Fri Jun 30 14:31:33 2017 [Signin] Remove the Dice response header after processing it Bug: 730589 TBR: rdsmith Change-Id: If409917ed2ea3323af436a218e5b45c1f316375c Reviewed-on: https://chromium-review.googlesource.com/557862 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#483698} [modify] https://crrev.com/9fad1a8bfd4c8202df7ed7ad1ff1145baefc08c0/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc [modify] https://crrev.com/9fad1a8bfd4c8202df7ed7ad1ff1145baefc08c0/chrome/browser/signin/chrome_signin_helper.cc [modify] https://crrev.com/9fad1a8bfd4c8202df7ed7ad1ff1145baefc08c0/chrome/browser/signin/chrome_signin_helper.h [add] https://crrev.com/9fad1a8bfd4c8202df7ed7ad1ff1145baefc08c0/chrome/browser/signin/chrome_signin_helper_unittest.cc [modify] https://crrev.com/9fad1a8bfd4c8202df7ed7ad1ff1145baefc08c0/chrome/test/BUILD.gn
Comment 1 by bugdroid1@chromium.org
, Jun 12 2017