New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 730570 link

Starred by 3 users
Status: Duplicate
Merged: issue 732062
Owner:
yiyix@chromium.org
Closed: Jun 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
yiyix@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [Incognito] Extension icon seen chopped from bottom side on bookmark bar.

Reported by db...@etouch.net, Jun 7 2017 
Chrome Version: 61.0.3123.0 (Official BRevision	193094009c210267cfa2c194ec9875711ccaf647-refs/heads/master@{#477506}
OS: Windows(7,8,8.1), Linux(14.04 LTS), 
URL: https://chrome.google.com/webstore/detail/momentum/laookkfknpbbblfpciffpaejjkokdgca/related?hl=en

What steps will reproduce the problem?
(1) Launch chrome, navigate to above url and click on ADD TO CHROME button.
(2) Open NTP bookmarked NTP and then open New incognito window 
(3) Observe extension icon on bookmarkbar

Actual: Extension icon chopped from bottom side on bookmark bar.

Expected: Extension iscon should seen properly.

This is a regression issue, broken in 'M-61', will soon update the other info:

Good Build: 61.0.3118.0
Bad Build: 61.0.3119.0

Note: Issue is not seen on Mac OS.
Screenshot.png
8.9 KB View Download

Comment 1 by rbasuvula@chromium.org, Jun 7 2017

Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision
Owner: yiyix@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:61.0.3121.0 (Revision:477034).
Bad build:61.0.3122.0 (Revision:477124).

You are probably looking for a change made after 476568 (known good), but no later than 476569 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/9939f3a8acf8565958bfc50d01ff7c0f7bd4ebe5..7073ae5bc6af913c649500e015210992f9c7111a

From the CL above, assigning the issue to the concern owner

@yiyix: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2899133004
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Not in Mac 10.12.3 and Able to reproduce in latest Canary #61.0.3123.0

Comment 2 by ranjitkan@chromium.org, Jun 7 2017

Labels: ReleaseBlock-Stable
Adding release block label, please undo if not the case.

Comment 3 by yiyix@chromium.org, Jun 7 2017 

Unfortunately, I don't think there is anything to do with my change. I reduced the bookmark bar height by 1. I am trying this in my local branch i get what's in the attachment.
Screenshot from 2017-06-07 16:49:10.png
3.7 KB View Download

Comment 4 by yiyix@chromium.org, Jun 7 2017

Owner: ----
Status: Available (was: Assigned)
My patch number is 476569 which is not in the range 477034 and 477124. 

I will remove myself from owner.

Comment 5 by msramek@chromium.org, Jun 12 2017

Cc: yiyix@chromium.org
+yiyix@ re-adding you, because I don't understand comment #3.

The bottom of the icon is chopped by 1px, which is clearly something that would happen if you decrease the bookmark bar height by 1px?

Comment 6 by yiyix@chromium.org, Jun 12 2017 

@msramek, Sorry, based on the attachment, I thought the issue is the spacing between the icon and the title is too much. I misunderstand the step 3 "Observe extension icon on bookmarkbar"

It's definitely my cl caused it.

Comment 7 by yiyix@chromium.org, Jun 12 2017

Owner: yiyix@chromium.org

Comment 8 by yiyix@chromium.org, Jun 12 2017

Mergedinto: 732062
Status: Duplicate (was: Available)
►

Sign in to add a comment