New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 730534 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Unwanted space is seen between 'Momentum' text after search action in chrome://settings.

Reported by db...@etouch.net, Jun 7 2017

Issue description

Chrome Version: 61.0.3123.0 (Official BRevision	193094009c210267cfa2c194ec9875711ccaf647-refs/heads/master@{#477506}
OS: Windows(7,8,8.1), Linux(14.04 LTS), Mac(10.11.6, 10.12.3)

URL: https://chrome.google.com/webstore/detail/momentum/laookkfknpbbblfpciffpaejjkokdgca/related?hl=en

What steps will reproduce the problem?
1. Launch chrome,navigate to above url and click on ADD TO CHROME button.
2. Then open chrome://settings page, type 'Mom' in search field and observe.

Actual: Unwanted space is seen between Momentum text after search action.

Expected: No such a space should seen.

This is non-regression issue,seen from 'M 56'(56.0.2924.0) newly added feature.
 
Actual_Search.mp4
877 KB View Download
Status: Untriaged (was: Unconfirmed)
Untriaged so that it gets addressed.
Components: -Platform>Extensions
Labels: Proj-MaterialDesign-WebUI Hotlist-MD-Settings-SearchBox
Owner: dpa...@chromium.org
Status: assigned (was: Untriaged)
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fbb54abf28e52285f1b4ee260c3023fb3fea6ab

commit 0fbb54abf28e52285f1b4ee260c3023fb3fea6ab
Author: dpapad <dpapad@chromium.org>
Date: Thu Jun 08 01:39:46 2017

MD Settings: Fix search highlighting within extension-controlled-indicator.

Make the CSS rule for span more specific, such that it is not accidentally
applied to the <span> used for search highlights.

BUG= 730534 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2929683002
Cr-Commit-Position: refs/heads/master@{#477854}

[modify] https://crrev.com/0fbb54abf28e52285f1b4ee260c3023fb3fea6ab/chrome/browser/resources/settings/controls/extension_controlled_indicator.html

Status: Fixed (was: Started)
Labels: TE-Verified-M61 TE-Verified-61.0.3128.0
Tested the issue on windows 7, Mac 10.12.5, Linux Ubuntu 14.04 using chrome version# TE-Verified-61.0.3128.0 with the steps mentioned in comment #0.Unwanted space is not seen between Momentum text after search action which is working as intended.Hence adding TE-Verified labels.
Please find the attached screen cast for the same.
Thanks!!

730534.mp4
1.7 MB View Download

Sign in to add a comment