Issue metadata
Sign in to add a comment
|
Make interim translate bubble UI/UX acceptable for Harmony (before new translate UI gets made + shipped).
Reported by
db...@etouch.net,
Jun 7 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version: 61.0.3123.0 Revision 193094009c210267cfa2c194ec9875711ccaf647-refs/heads/master@{#477506} OS: Windows(7,8,10, Linux Pre-condition: Enabled 'Material Design in the rest of the browser's native UI' flag from chrome://flags What steps will reproduce the problem? (1) Launch chrome, navigate to https://www.google.com/intl/fil/chrome/browser/welcome.html (2) Click on Translation icon then hover mouse on Nope button of bubble and observe. Actual: Unwanted blink is seen while hovering mouse on 'Nope' button. Expected: No such blink should seen. This is a regression issue, broken in 'M-55', will soon update the other info: Good Build:55.0.2851.0 Bad Build: 55.0.2853.0 Note: Issue is not seen on Mac OS.
,
Jun 7 2017
,
Jun 8 2017
Note this also needs chrome://flags/#translate-2016q2-ui disabled. I think the "blink" is a momentary problem with subpixel AA that isn't being handled for these "Action-Style" combo boxes that the old translate UI uses. Mac is not affected since it still uses an infobar. Ideally.. we just drop support for these action-style combos since the old translate UI is the only thing that uses them. Also they haven't been re-styled for Harmony and have a manky focus ring. But also the *new* translate UI isn't using a properly styled combo box under harmony -- it's still the old style, and no focus ring. 2016-q2 is a while ago. What is the plan for this translate UI? We don't want to support 3 ui surfaces for the same dialog (infobar, old-bubble, new-bubble).
,
Jun 8 2017
Added this on the other bug but we're trying to figure out exactly what's happening with this UI. Translate team can't support the increase in server load with it now hence why we're not launching yet but we're finalizing the direction we want to take in the future. If you have thoughts that you'd like to share with us (SYD language team), we'd love to chat.
,
Nov 6 2017
Altering scope and increasing priority of this bug so we can fix it before Harmony launch. We should address the focus highlight and hover animation, by either fixing or removing the "combo" button on this dialog. At this point we should ignore the "2016q2" version of the UI.
,
Nov 6 2017
,
Nov 9 2017
re: c3 and c5, Since we'd like to fix this issue without a dependency on the TX revamp work, a fix we can make is 1. turning the old 'combo' to a regular secondary button 'Options' (see the attached screenshot) 2. adding close (x) per the popover close (x) guideline, which replaces 'Nope' on the old 'combo' 3. using the same focusring as other harmony secondary button
,
Nov 14 2017
Issue 784797 has been merged into this issue.
,
Nov 15 2017
,
Dec 5 2017
Load balancing
,
Dec 5 2017
The attached mock seems a good place to be until we revamp the UI. - Change the title from "Would you like to" to "Do you want to" to match password save prompt. - Remove the link "Options", and proved that under dropdown - The button "Options" expands dropdown with two never options and "More options (to go to the panel with the language change and always translate checkbox)" - X replaces 'Nope'
,
Dec 5 2017
Is it possible to have "Always translate Japanese" in the options list instead of hidden under "More options"? Users we talked in MON already have a hard time finding the functionality - one "power user" even requested it as a feature because he didn't know it already existed.
,
Dec 5 2017
re: c13 involves showing/hiding the checkmark as well as making the selecting to change the settings (image: go/730521c14).
,
Dec 5 2017
Gotcha. Ok.
,
Dec 5 2017
c14 was an additional context. I think pbos@ can answer the question in c13 in terms of determining whether c13/c14 should be scoped in or not for Harmony V1.
,
Dec 7 2017
WIP: The options menu now looks like a button and has new entries. I moved the options links to be buttons (but saying "More options" to be consistent with the first panel, as Options in the following pages always go to more options, and is not a menu dropdown). I still have to figure out menu styling. This isn't checked in yet. I don't think we'll fix c13/c14 as part of this, but someone with free cycles could pick it up. It's non-trivial for me because I don't know how to add the checkbox in a menu, and given that the UI is going away it would hopefully be added to the follow-up UI. FWIW / tangent: I don't agree with the proximity of "Always and Never" options in the mock, seems like a separator or some rewording is appropriate, they're too visually similar imo. All "never" options completely disables the translate UI and you can't easily restore it, so they're scary close to the "always" toggle. I was able to find out how to get the language back by digging (very deep) into chrome://settings, but couldn't figure out how to get the site back so I nuked my testing profile.
,
Dec 11 2017
,
Dec 11 2017
Changes since last round of screenshot (I'll take screenshots later): The middle 3 screenshots have had a bit of padding into them (matching the first) since they looked flat without it. The title string in the last screenshot is now simply "Options" instead of "Translation options".
,
Dec 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06704df5d7753985252ac7175972aba3fcda0d56 commit 06704df5d7753985252ac7175972aba3fcda0d56 Author: Peter Boström <pbos@chromium.org> Date: Fri Dec 15 03:44:54 2017 Harmonize Translate UI Bubble Adds somewhat-compliant Harmony style to the translate bubble. This UI is in the process of being reworked, so minor issues may be allowed to fall through the cracks in the interrim. Bug: chromium:730521 Change-Id: Ic8274ad285e41ce7750c41caaeb67010fd9e153c Reviewed-on: https://chromium-review.googlesource.com/815292 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Rachel Blum <groby@chromium.org> Cr-Commit-Position: refs/heads/master@{#524313} [modify] https://crrev.com/06704df5d7753985252ac7175972aba3fcda0d56/chrome/app/generated_resources.grd [modify] https://crrev.com/06704df5d7753985252ac7175972aba3fcda0d56/chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm [modify] https://crrev.com/06704df5d7753985252ac7175972aba3fcda0d56/chrome/browser/ui/translate/translate_bubble_view_state_transition.h [modify] https://crrev.com/06704df5d7753985252ac7175972aba3fcda0d56/chrome/browser/ui/views/translate/translate_bubble_view.cc [modify] https://crrev.com/06704df5d7753985252ac7175972aba3fcda0d56/chrome/browser/ui/views/translate/translate_bubble_view.h [modify] https://crrev.com/06704df5d7753985252ac7175972aba3fcda0d56/chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc [modify] https://crrev.com/06704df5d7753985252ac7175972aba3fcda0d56/chrome/browser/ui/views/translate/translate_bubble_view_unittest.cc
,
Dec 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b2d153e88726d92191b71869185a9b3995cfaca commit 2b2d153e88726d92191b71869185a9b3995cfaca Author: Peter Boström <pbos@chromium.org> Date: Mon Dec 18 20:17:13 2017 Add Always translate Language menu item. Makes Always translating a language significantly easier to discover, compared to clicking options link > checking Always translate checkbox. Since More options (from the translate options menu button) now is only useful for changing which languages translation is done in between, update the button label from there (but not the other panels) to reflect that. Bug: chromium:730521 Change-Id: I65f37382942d621a6caf1ee13342034fd49fd604 Reviewed-on: https://chromium-review.googlesource.com/829875 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#524780} [modify] https://crrev.com/2b2d153e88726d92191b71869185a9b3995cfaca/chrome/app/generated_resources.grd [modify] https://crrev.com/2b2d153e88726d92191b71869185a9b3995cfaca/chrome/browser/ui/views/translate/translate_bubble_view.cc [modify] https://crrev.com/2b2d153e88726d92191b71869185a9b3995cfaca/chrome/browser/ui/views/translate/translate_bubble_view.h [modify] https://crrev.com/2b2d153e88726d92191b71869185a9b3995cfaca/chrome/browser/ui/views/translate/translate_bubble_view_unittest.cc
,
Dec 19 2017
,
Dec 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe01fb1dde7d765c4178e7a0ba5e8cbbb3c3e1a2 commit fe01fb1dde7d765c4178e7a0ba5e8cbbb3c3e1a2 Author: Peter Boström <pbos@chromium.org> Date: Fri Dec 22 23:06:39 2017 Make UX-requested updates to Translate bubble. * Rename "More Options" back to "Options" (distinguisher no longer necessary). * Update in-progress title to "Translating...". * Update done title to "Translated". * Show "Options" menu from done panel. * Move "Always translate" checkbox inside advanced panel. * Remove "Language settings" link from advanced panel (not slated for updated UI either). * Update "never" options to state "Don't translate X" instead of "Never translate X". Also replaces the views::MenuButton with a Harmony-compliant bubble and updates the option menu on every click so any language changes done inside the advanced panel are reflected in the menu outside. TBR=tapted@chromium.org Bug: chromium:730521 Change-Id: I2e05bdacfb7c9e487e4f7f32e7934ba521ef54bd Reviewed-on: https://chromium-review.googlesource.com/832850 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#526085} [modify] https://crrev.com/fe01fb1dde7d765c4178e7a0ba5e8cbbb3c3e1a2/chrome/app/generated_resources.grd [modify] https://crrev.com/fe01fb1dde7d765c4178e7a0ba5e8cbbb3c3e1a2/chrome/browser/ui/cocoa/translate/translate_bubble_test_utils_views_cocoa.mm [modify] https://crrev.com/fe01fb1dde7d765c4178e7a0ba5e8cbbb3c3e1a2/chrome/browser/ui/views/translate/translate_bubble_test_utils_views.cc [modify] https://crrev.com/fe01fb1dde7d765c4178e7a0ba5e8cbbb3c3e1a2/chrome/browser/ui/views/translate/translate_bubble_view.cc [modify] https://crrev.com/fe01fb1dde7d765c4178e7a0ba5e8cbbb3c3e1a2/chrome/browser/ui/views/translate/translate_bubble_view.h [modify] https://crrev.com/fe01fb1dde7d765c4178e7a0ba5e8cbbb3c3e1a2/chrome/browser/ui/views/translate/translate_bubble_view_unittest.cc
,
Dec 22 2017
I believe this redesign is now acceptable until the new translate UI is in place (and significantly better than prior). hwi@ / yyushkina@ / ... feel free to try it out in the next Canary and reopen if there are some minor things that need to be addressed. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rbasuvula@chromium.org
, Jun 7 2017Labels: hasbisect-per-revision
Owner: est...@chromium.org
Status: Assigned (was: Unconfirmed)