New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 730481 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Feature

Blocked on:
issue 731594



Sign in to add a comment

Setup iOS sim and device builders in chromium.webrtc.fyi

Project Member Reported by kjellander@chromium.org, Jun 7 2017

Issue description

We've recently have problems with breaking the iOS build for Chromium as it now builds more of WebRTC code than in the past.

To detect breakages early on, we should setup bots that build with similar GN configuration as the 'ios-device' and 'ios-simulator' trybots in Chromium.




 
Labels: OS-iOS
Cc: mbonadei@chromium.org
Status: Started (was: Assigned)
Bot CL is up: https://chromium-review.googlesource.com/c/528092/
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6152403093cbb3b7690fc52da9766f433445c4c4

commit 6152403093cbb3b7690fc52da9766f433445c4c4
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Fri Jun 09 06:28:37 2017

Add iOS bot configurations for chromium.webrtc.fyi

These are exact copies of the bots in chromium.mac.

BUG= 730481 
TBR=smut@google.com
NOTRY=True

Change-Id: Iff4e8eb37d14e515f5509d7009be128294f3808a
Reviewed-on: https://chromium-review.googlesource.com/528072
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Reviewed-by: smut <smut@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478216}
[add] https://crrev.com/6152403093cbb3b7690fc52da9766f433445c4c4/ios/build/bots/chromium.webrtc.fyi/ios-device.json
[add] https://crrev.com/6152403093cbb3b7690fc52da9766f433445c4c4/ios/build/bots/chromium.webrtc.fyi/ios-simulator.json

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/3c7c5093194a0d624e792af5f67265a6f489ce83

commit 3c7c5093194a0d624e792af5f67265a6f489ce83
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Fri Jun 09 07:15:06 2017

WebRTC: Add iOS bots to chromium.webrtc.fyi

These bots will give us additional heads up for WebRTC rolls in
Chromium DEPS when iOS specific breakages are happening.

Add new recipe based on ios/unified_builder_tester that only builds
(no tests run).

The 'Mac Builder' has spare time compared to the tester, so deploying at that
one for now. Will request new machine if the iOS builds are slow (but the
incremental builds seems to be <5 minutes cycle times in chromium.mac waterfall).

Upstream JSON files are added in https://chromium-review.googlesource.com/c/528072/

BUG= 730481 

Change-Id: Ibaff6b4cda09c562b0805d99f364c44320b5b3d7
Reviewed-on: https://chromium-review.googlesource.com/528092
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>
Reviewed-by: smut <smut@chromium.org>

[add] https://crrev.com/3c7c5093194a0d624e792af5f67265a6f489ce83/scripts/slave/recipes/webrtc/chromium_ios.py
[add] https://crrev.com/3c7c5093194a0d624e792af5f67265a6f489ce83/scripts/slave/recipes/webrtc/chromium_ios.expected/basic_goma_build.json
[modify] https://crrev.com/3c7c5093194a0d624e792af5f67265a6f489ce83/scripts/slave/recipe_modules/ios/api.py
[modify] https://crrev.com/3c7c5093194a0d624e792af5f67265a6f489ce83/masters/master.chromium.webrtc.fyi/master_builders_cfg.py
[modify] https://crrev.com/3c7c5093194a0d624e792af5f67265a6f489ce83/masters/master.chromium.webrtc.fyi/slaves.cfg

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/93f34b2a45e60a65f64d916c27f0ddb379251d9a

commit 93f34b2a45e60a65f64d916c27f0ddb379251d9a
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Fri Jun 09 10:55:15 2017

WebRTC: Share the same checkout between Mac builder and iOS bots

The new bots added in https://chromium-review.googlesource.com/c/528092/
were filling up the disk due to two new Chromium checkouts being created.
While waiting for the VM in crbug.com/731594 to be allocated, let's use
the same checkout as the iPhone and iOS simulator builds are using
different directories inside out/

BUG= 730481 
TBR=machenbach@chromium.org

Change-Id: I25a08481b03b5be251f2cd291a5cb52eb9dfcc34
Reviewed-on: https://chromium-review.googlesource.com/527446
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>

[modify] https://crrev.com/93f34b2a45e60a65f64d916c27f0ddb379251d9a/masters/master.chromium.webrtc.fyi/master_builders_cfg.py

The new bots are still filling up the 200 GB partition even if they only have one Chromium checkout. I will make the bots perform noop builds for now (so I don't have to restart the master).
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/ab37bfe49cb361c81b3a2769d2d3867318e1c46e

commit ab37bfe49cb361c81b3a2769d2d3867318e1c46e
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Fri Jun 09 12:51:35 2017

WebRTC: Disable the new iOS bots in chromium.webrtc.fyi

They keep running out of disk, disable them until we got a new VM
to deploy at

BUG= 730481 
TBR=machenbach@chromium.org

Change-Id: I1daef6dcd9a7e8e60caeff53d6b3920d6a111776
Reviewed-on: https://chromium-review.googlesource.com/529164
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>

[modify] https://crrev.com/ab37bfe49cb361c81b3a2769d2d3867318e1c46e/scripts/slave/recipes/webrtc/chromium_ios.py
[modify] https://crrev.com/ab37bfe49cb361c81b3a2769d2d3867318e1c46e/scripts/slave/recipes/webrtc/chromium_ios.expected/basic_goma_build.json

Blockedon: 731594
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/f8641bd71040be4a16b2e8b3ef1492ff9d97313c

commit f8641bd71040be4a16b2e8b3ef1492ff9d97313c
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Wed Jun 14 08:16:46 2017

Revert "WebRTC: Disable the new iOS bots in chromium.webrtc.fyi"

This reverts commit ab37bfe49cb361c81b3a2769d2d3867318e1c46e.

Reason for revert: New, separate VM, is deployed for the iOS bots.

Original change's description:
> WebRTC: Disable the new iOS bots in chromium.webrtc.fyi
> 
> They keep running out of disk, disable them until we got a new VM
> to deploy at
> 
> BUG= 730481 
> TBR=machenbach@chromium.org
> 
> Change-Id: I1daef6dcd9a7e8e60caeff53d6b3920d6a111776
> Reviewed-on: https://chromium-review.googlesource.com/529164
> Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
> Commit-Queue: Henrik Kjellander <kjellander@chromium.org>

TBR=kjellander@chromium.org,machenbach@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  730481 
Change-Id: Iddbfdc648023f4186283f71043f25721e85f8494
Reviewed-on: https://chromium-review.googlesource.com/535553
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>

[modify] https://crrev.com/f8641bd71040be4a16b2e8b3ef1492ff9d97313c/scripts/slave/recipes/webrtc/chromium_ios.py
[modify] https://crrev.com/f8641bd71040be4a16b2e8b3ef1492ff9d97313c/scripts/slave/recipes/webrtc/chromium_ios.expected/basic_goma_build.json

Status: Fixed (was: Started)
These bots are doing fine now.

Sign in to add a comment