New issue
Advanced search Search tips

Issue 730460 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

CQ let a patch land that blocked subqequent commits

Project Member Reported by alexclarke@chromium.org, Jun 7 2017

Issue description

The CQ let https://codereview.chromium.org/2924663003/ land but subsequent commits were failing with the error below.  This is a really easy mistake to make in a patch and it would would be great if the CQ could catch it at the right time.

""" to /b/build/slave/ios-device/build/src/out/Release-iphoneos/args.gn.
/b/build/slave/ios-device/build/src/buildtools/mac/gn gen //out/Release-iphoneos --check
  -> returned 1
ERROR at //ios/chrome/browser/ui/payments/payment_request_mediator_unittest.mm:17:11: Can't include this header from here.
#include "components/signin/core/browser/signin_manager.h"
          ^----------------------------------------------
The target:
  //ios/chrome/browser/ui/payments:unit_tests
is including a file from the target:
  //components/signin/core/browser:browser
It's usually best to depend directly on the destination target.
In some cases, the destination target is considered a subcomponent
of an intermediate target. In this case, the intermediate target
should depend publicly on the destination to forward the ability
to include headers.
Dependency chain (there may also be others):
  //ios/chrome/browser/ui/payments:unit_tests -->
  //ios/chrome/browser/ui/payments:payments --[private]-->
  //components/signin/core/browser:browser

E.g. https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2Fios-device%2F226891%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files__mb___with_patch_%2F0%2Fstdout


 
I forgot to mention I reverted the patch in question and the CQ is happy now although the bug in the CQ is still there.
Cc: dpranke@chromium.org
Components: Infra>Client>Chrome
Since the error is in GN step, +dpranke@
do you know why it wasn't caught with the patch on tryjobs?
Owner: brettw@chromium.org
Status: Assigned (was: Untriaged)
strange, the ios-device build on the trybots succeeded:

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2Fios-device%2F226411%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files__mb___with_patch_%2F0%2Fstdout

Testing this patch locally, `gn check` fails (correctly) but `gn gen --check` is failing. I'm not sure what's going on, but this feels like a race in GN.

brettw@, can you take a look?
Components: -Infra>CQ

Comment 6 by brettw@chromium.org, Mar 20 2018

Owner: ----
Status: Available (was: Assigned)

Sign in to add a comment