Test "CrossSitePaymentForms" seems to be incorrect.
Reported by
xae...@yandex-team.ru,
Jun 7 2017
|
|||||||
Issue descriptionTest "AutofillInteractiveTest.CrossSitePaymentForms" from interactive_ui_tests should verify whether the credit card (payment card list) popup works when the form is inside an OOPIF. However, it actually detects the popup "HTTP form warning", introduced by feature "kHttpFormWarningFeature". Autofilling is virtually skipped in the test because of insecure form context (HTTP instead of HTTPS). It is suggested to change the context to HTTPS using another test server (the embedded_test_server() is insecure in the test); probably one might need to solve possible certificate errors that would arise.
,
Nov 21 2017
,
Jan 31 2018
Indeed this test is failing in https://chromium-review.googlesource.com/c/chromium/src/+/891677 where I removed the kHttpFormWarningFeature from the field trial testing config. (We never launched that feature.) I'll try changing the test to an https server to see if that fixes it; if not I'll probably just disable it. (It's already marked as flaky and disabeld on Windows.)
,
Jan 31 2018
Marking as Available; I decided to revert the HttpFormWarning change from the above CL. Here is what I think needs to be done to fix this test: - Instantiate an EmbeddedTestServer of TYPE_HTTPS to use instead of embedded_test_server() in the test. - Make the test inherit from CertVerifierBrowserTest (in c/b/ssl). Set a default cert verifier result of net::OK so that the cert verifier accepts certificates for the non-matching hostnames used in the test. - At this point the test still fails because there are no stored credit card suggestions. I didn't dig into this further but we probably want something like AddTestCreditCard (akin to AddTestProfile) in autofill_uitest_util.h. - Then we can remove the HttpFormWarning configuration from fieldtrial_testing_config.json and the test should (hopefully) pass.
,
Feb 1 2018
Over to Seb for triage
,
May 22 2018
,
Aug 3
This bug has an owner, thus, it's been triaged. Changing status to "assigned". |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by rbasuvula@chromium.org
, Jul 13 2017Labels: TE-NeedsTriageHelp