New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 730441 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Blink-Paint



Sign in to add a comment

matrixTransform() and transformPoint() 2d code path uses m12 instead of m21

Reported by sim...@opera.com, Jun 7 2017

Issue description

Owner: hs1217....@samsung.com
Status: Started (was: Untriaged)
i will fix it.

Comment 2 by sim...@opera.com, Jun 7 2017

Thanks! If you could also add tests under external/wpt/css/geometry-1/ for this difference, that would be A+. :-)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f81049d5a4f02b598815c00baa0d135b79304588

commit f81049d5a4f02b598815c00baa0d135b79304588
Author: hs1217.lee <hs1217.lee@samsung.com>
Date: Fri Jun 09 03:38:04 2017

[geometry] replace m12 with m21 when transform DOMPoint from DOMMatrix.

there is wrong calculate when transform DOMPoint from DOMMatrix.
we should replace m12 with m21.
unfortunately all of m12 and m21 values were zero in layout tests.
so it could not detect problems.

BUG= 730441 

Review-Url: https://codereview.chromium.org/2930883002
Cr-Commit-Position: refs/heads/master@{#478185}

[modify] https://crrev.com/f81049d5a4f02b598815c00baa0d135b79304588/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-transformPoint.html
[modify] https://crrev.com/f81049d5a4f02b598815c00baa0d135b79304588/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-point-readonly.html
[modify] https://crrev.com/f81049d5a4f02b598815c00baa0d135b79304588/third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.cpp
[modify] https://crrev.com/f81049d5a4f02b598815c00baa0d135b79304588/third_party/WebKit/Source/core/geometry/DOMPointReadOnly.cpp

@simonp
i will upload other tests for external/wpt/css/geometry-1/ indirectly.
as far as i know, external/wpt/css/geometry-1/ is synchronized 
from https://github.com/w3c/web-platform-tests periodically.

Comment 7 by sim...@opera.com, Jun 14 2017

\o/

This can be closed as fixed, then, right?

(Since there is two-way syncing for wpt, it should be possible to add tests in a Chromium CL and it will be automatically upstreamed to web-platform-tests, but either way works of course.)

Comment 8 by sim...@opera.com, Jun 14 2017

\o/

This can be closed as fixed, then, right?

(Since there is two-way syncing for wpt, it should be possible to add tests in a Chromium CL and it will be automatically upstreamed to web-platform-tests, but either way works of course.)
Status: Fixed (was: Started)
yes. i will close this issue as fixed. thank you.

Sign in to add a comment