chromium build failed with enable_vr = true && enable_openvr = true on windows |
||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36 Steps to reproduce the problem: Try to build chromium on windows with args.gn : is_debug = false is_component_build = true enable_vr = true enable_openvr = true What is the expected behavior? Build sucessfully What went wrong? There are 1compile error and 1 LINK error at last: 1. Compile Error : GetVSync failed to compatible to vr_service.mojom defined. 2. LINK error : [7/10504] LINK(DLL) device_vr.dll device_vr.dll.lib device_vr.dll.pdb FAILED: device_vr.dll device_vr.dll.lib device_vr.dll.pdb C:/Python27/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False link.exe /nologo /IMPLIB:./device_vr.dll.lib /DLL /OUT:./device_vr.dll /PDB:./device_vr.dll.pdb @./device_vr.dll.rsp openvr_device.obj : error LNK2019: unresolved external symbol __imp_VR_GetGenericInterface referenced in function "public: class vr::IVRChaperone * __cdecl vr::COpenVRContext::VRChaperone(void)" (?VRChaperone@COpenVRContext@vr@@QEAAPEAVIVRChaperone@2@XZ) openvr_device_provider.obj : error LNK2001: unresolved external symbol __imp_VR_GetGenericInterface openvr_device.obj : error LNK2019: unresolved external symbol __imp_VR_GetInitToken referenced in function "public: class vr::IVRChaperone * __cdecl vr::COpenVRContext::VRChaperone(void)" (?VRChaperone@COpenVRContext@vr@@QEAAPEAVIVRChaperone@2@XZ) openvr_device_provider.obj : error LNK2001: unresolved external symbol __imp_VR_GetInitToken openvr_device_provider.obj : error LNK2019: unresolved external symbol __imp_VR_IsHmdPresent referenced in function "public: virtual void __cdecl device::OpenVRDeviceProvider::Initialize(void)" (?Initialize@OpenVRDeviceProvider@device@@UEAAXXZ) openvr_device_provider.obj : error LNK2019: unresolved external symbol __imp_VR_IsRuntimeInstalled referenced in function "public: virtual void __cdecl device::OpenVRDeviceProvider::Initialize(void)" (?Initialize@OpenVRDeviceProvider@device@@UEAAXXZ) openvr_device_provider.obj : error LNK2019: unresolved external symbol __imp_VR_GetVRInitErrorAsEnglishDescription referenced in function "public: virtual void __cdecl device::OpenVRDeviceProvider::Initialize(void)" (?Initialize@OpenVRDeviceProvider@device@@UEAAXXZ) openvr_device_provider.obj : error LNK2019: unresolved external symbol __imp_VR_IsInterfaceVersionValid referenced in function "class vr::IVRSystem * __cdecl vr::VR_Init(enum vr::EVRInitError *,enum vr::EVRApplicationType)" (?VR_Init@vr@@YAPEAVIVRSystem@1@PEAW4EVRInitError@1@W4EVRApplicationType@1@@Z) openvr_device_provider.obj : error LNK2019: unresolved external symbol __imp_VR_InitInternal referenced in function "class vr::IVRSystem * __cdecl vr::VR_Init(enum vr::EVRInitError *,enum vr::EVRApplicationType)" (?VR_Init@vr@@YAPEAVIVRSystem@1@PEAW4EVRInitError@1@W4EVRApplicationType@1@@Z) openvr_device_provider.obj : error LNK2019: unresolved external symbol __imp_VR_ShutdownInternal referenced in function "class vr::IVRSystem * __cdecl vr::VR_Init(enum vr::EVRInitError *,enum vr::EVRApplicationType)" (?VR_Init@vr@@YAPEAVIVRSystem@1@PEAW4EVRInitError@1@W4EVRApplicationType@1@@Z) ./device_vr.dll : fatal error LNK1120: 8 unresolved externals Did this work before? N/A Does this work in other browsers? N/A Chrome version: 61.0.3118.0 Channel: n/a OS Version: 10 Flash Version:
,
Jun 8 2017
I'd like to get this building at least on an FYI bot to catch breaks earlier.
,
Jun 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d607aacd7fd54bab7abeef5b20eea1f4bf26e674 commit d607aacd7fd54bab7abeef5b20eea1f4bf26e674 Author: billorr <billorr@chromium.org> Date: Thu Jun 08 06:01:44 2017 Fix build break when building with enable_openvr=true on Windows BUG= 730436 Review-Url: https://codereview.chromium.org/2929733002 Cr-Commit-Position: refs/heads/master@{#477907} [modify] https://crrev.com/d607aacd7fd54bab7abeef5b20eea1f4bf26e674/device/vr/openvr/openvr_device.cc [modify] https://crrev.com/d607aacd7fd54bab7abeef5b20eea1f4bf26e674/device/vr/openvr/openvr_device.h [modify] https://crrev.com/d607aacd7fd54bab7abeef5b20eea1f4bf26e674/third_party/openvr/BUILD.gn
,
Jun 8 2017
Broken again shortly after submitting the fix. I'll reuse the exiting bug to fix again.
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba0495ce9770653cf13459d8a07727295d55fe1a commit ba0495ce9770653cf13459d8a07727295d55fe1a Author: billorr <billorr@chromium.org> Date: Fri Jun 09 03:53:36 2017 Fix new build break on Windows with OpenVR. BUG= 730436 Review-Url: https://codereview.chromium.org/2930993002 Cr-Commit-Position: refs/heads/master@{#478193} [modify] https://crrev.com/ba0495ce9770653cf13459d8a07727295d55fe1a/chrome/browser/permissions/permission_manager.cc [modify] https://crrev.com/ba0495ce9770653cf13459d8a07727295d55fe1a/chrome/browser/permissions/permission_manager_unittest.cc [modify] https://crrev.com/ba0495ce9770653cf13459d8a07727295d55fe1a/device/vr/openvr/openvr_gamepad_data_fetcher.cc
,
Jun 9 2017
@billorr thx for fixing it! It could build successfully.
,
Jun 12 2017
,
Jul 4
|
||||
►
Sign in to add a comment |
||||
Comment 1 by ddorwin@chromium.org
, Jun 7 2017Owner: billorr@chromium.org
Status: Assigned (was: Unconfirmed)