New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 730405 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Not on Chrome
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

[MD Bookmarks] Ctrl-A should be a global shortcut to select all bookmarks

Project Member Reported by tsergeant@chromium.org, Jun 7 2017

Issue description

Ctrl-A currently only selects all if you already have a bookmark list item focused. This is slightly confusing behavior, and we should change it so that it always works (in the same contexts that Ctrl-Z would work, for example).
 
Owner: tsergeant@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/679159f7fd567e7c1953a1c1548ee42ae55d2907

commit 679159f7fd567e7c1953a1c1548ee42ae55d2907
Author: tsergeant <tsergeant@chromium.org>
Date: Fri Jun 16 06:58:41 2017

MD Bookmarks: Make shortcuts for select all/deselect all global

These shortcuts (Ctrl/Meta-A and Escape) can now be triggered while
the sidebar or document are active.

BUG= 730405 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2929053004
Cr-Commit-Position: refs/heads/master@{#479975}

[modify] https://crrev.com/679159f7fd567e7c1953a1c1548ee42ae55d2907/chrome/browser/resources/md_bookmarks/command_manager.js
[modify] https://crrev.com/679159f7fd567e7c1953a1c1548ee42ae55d2907/chrome/browser/resources/md_bookmarks/constants.js
[modify] https://crrev.com/679159f7fd567e7c1953a1c1548ee42ae55d2907/chrome/browser/resources/md_bookmarks/list.js
[modify] https://crrev.com/679159f7fd567e7c1953a1c1548ee42ae55d2907/chrome/test/data/webui/md_bookmarks/md_bookmarks_focus_test.js

Status: Fixed (was: Started)

Sign in to add a comment