New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 730377 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Team-Security-UX



Sign in to add a comment

Investigate how permissions embargo interacts with search geolocation disclosure / default search engine geolocation

Project Member Reported by dominickn@chromium.org, Jun 7 2017

Issue description

Let's say the user has a search engine with geolocation permission embargoed. What should happen when the user changes their default search engine to the embargoed engine?

a) wipe embargo and restore state to ASK
b) respect embargo and do not grant geolocation to the new default search engine

emilyschechter: do you have thoughts on this from the PM perspective?
 
Good catch Dom! This seems like it would happen quite rarely.

Honestly I think that changing the DSE is a very strong signal of intent and #1 should take precedence. Any other opinions?
Cc: emilyschechter@chromium.org
Labels: M-61
Owner: benwells@chromium.org
I agree with that. Let's go with #1.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19a5b3587d246544ad1927e6c891e00df2061c49

commit 19a5b3587d246544ad1927e6c891e00df2061c49
Author: benwells <benwells@chromium.org>
Date: Thu Jun 15 04:47:56 2017

Reset geolocation permission embargo for an origin when it becomes DSE

If an origin becomes the default search engine (DSE) it should have any
embargo status on it reset.

BUG= 730377 

Review-Url: https://codereview.chromium.org/2941753002
Cr-Commit-Position: refs/heads/master@{#479606}

[modify] https://crrev.com/19a5b3587d246544ad1927e6c891e00df2061c49/chrome/browser/android/search_geolocation/search_geolocation_service.cc
[modify] https://crrev.com/19a5b3587d246544ad1927e6c891e00df2061c49/chrome/browser/android/search_geolocation/search_geolocation_service_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment