New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 730359 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 463591



Sign in to add a comment

Remove cq_actual.py. Make cq.py launch commit_queue.py directly.

Project Member Reported by dsansome@chromium.org, Jun 7 2017

Issue description

cq_actual.py used to handle starting and stopping CQ in the background.  Service manager handles that now, so we should be able to remove cq_actual.py completely and provide the relevant flags directly to commit_queue.py.
 
Components: -Infra>CQ Infra>Platform>CQdaemon
Blocking: 463591
very sgtm
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/6634425f06c070a35a7b7ac42b301621f5d35cb6

commit 6634425f06c070a35a7b7ac42b301621f5d35cb6
Author: David Sansome <dsansome@google.com>
Date: Thu Jun 08 00:40:41 2017

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/61512cd433a9cd1058578ddf08678029bccbfbcf

commit 61512cd433a9cd1058578ddf08678029bccbfbcf
Author: David Sansome <dsansome@google.com>
Date: Thu Jun 08 00:41:40 2017

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/f7dcffcdb6d3c083201bce796b9fd69108119aea

commit f7dcffcdb6d3c083201bce796b9fd69108119aea
Author: David Sansome <dsansome@google.com>
Date: Fri Jun 09 03:38:50 2017

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/b3c683c99e13ade9cf48b16a761a5811bebd839b

commit b3c683c99e13ade9cf48b16a761a5811bebd839b
Author: David Sansome <dsansome@google.com>
Date: Fri Jun 09 03:43:17 2017

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/cfa9cfef8848dabbc3c52735b534c053d7ab6908

commit cfa9cfef8848dabbc3c52735b534c053d7ab6908
Author: David Sansome <dsansome@google.com>
Date: Tue Jun 13 01:16:13 2017

Status: Fixed (was: Started)

Sign in to add a comment