New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 730342 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

The string on Dino button "Download page later" need to change

Project Member Reported by dim...@chromium.org, Jun 7 2017

Issue description

New text: "Download when online"
 
Do we also need to update the text for "DOWNLOADING" when the dino button is clicked? Just want to confirm this.
Cc: rachelis@chromium.org
talo@, rachelis@: See ^^^. Should the second string read something like "Will notify when downloaded"?
Update from the mail tread: the second string should be "Waiting for connection..."

Comment 4 by srahim@chromium.org, Jun 12 2017

Message descriptions for the 2 strings:
Download when online - Text on a button. Appears on a page under a heading "You are offline" with suggestions for how to get back online/connected. This page appears after the user has tried to download something, but because they don't have an internet connection, Chrome can't complete the download. If clicked, "Download when online" will queue the download for when the user has an internet connection again. Imperative.

Waiting for connection... - Text on a button that appears after a user clicks the button. Button text originally reads "Download when online", and appears on a page under a heading "You are offline" with suggestions for how to get back online/connected. This page appears after the user has tried to download something, but because they don't have an internet connection, Chrome can't complete the download. When button is clicked, Chrome queues the download for when the user has an internet connection again, and the button text changes to "Waiting for connection".
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/762bb48da4b3ff06e5a6c108c0f1f9f3c6050619

commit 762bb48da4b3ff06e5a6c108c0f1f9f3c6050619
Author: jianli <jianli@chromium.org>
Date: Tue Jun 13 21:40:58 2017

Update the text of the button to download page later on error

BUG= 730342 

Review-Url: https://codereview.chromium.org/2924173002
Cr-Commit-Position: refs/heads/master@{#479163}

[modify] https://crrev.com/762bb48da4b3ff06e5a6c108c0f1f9f3c6050619/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/762bb48da4b3ff06e5a6c108c0f1f9f3c6050619/components/error_page_strings.grdp

Comment 6 by jianli@chromium.org, Jun 14 2017

Status: Fixed (was: Assigned)

Sign in to add a comment