New issue
Advanced search Search tips

Issue 730338 link

Starred by 2 users
Status: Fixed
Owner:
kinuko@chromium.org
Closed: Oct 2017
Cc:
yhirano@chromium.org
jam@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Proj-Servicification

Blocking:
issue 751427



Sign in to add a comment

Generalize how renderer handles loading for non-network schemes (for Network Service)

Project Member Reported by kinuko@chromium.org, Jun 7 2017 
Currently we hook this using request's extra data that is plumbed in RenderFrameImpl::WillSendRequest, for, e.g. Blob. (Reference: https://codereview.chromium.org/2925903004/)

This could probably directly plumbed when we set-up / create URLLoader without going through extra data.  Also it'd be better to have a generalized, common mechanism for this.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b29773986fb56b3561cab32da7a10e108d1bb4e9

commit b29773986fb56b3561cab32da7a10e108d1bb4e9
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Thu Jun 29 00:26:49 2017

Pass request and task runner to WebURLLoader construction function

This CL adds WebURLRequest and SingleThreadTaskRunner params to
Platfrom::CreateURLLoader to enable further refactoring.

Bug:  712913 ,  730338 
Change-Id: I263905dadd5505135eb171c3920d92d1b335b578
Reviewed-on: https://chromium-review.googlesource.com/552417
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483220}
[modify] https://crrev.com/b29773986fb56b3561cab32da7a10e108d1bb4e9/components/plugins/renderer/webview_plugin.cc
[modify] https://crrev.com/b29773986fb56b3561cab32da7a10e108d1bb4e9/components/plugins/renderer/webview_plugin.h
[modify] https://crrev.com/b29773986fb56b3561cab32da7a10e108d1bb4e9/components/printing/renderer/print_web_view_helper.cc
[modify] https://crrev.com/b29773986fb56b3561cab32da7a10e108d1bb4e9/content/ppapi_plugin/ppapi_blink_platform_impl.cc
[modify] https://crrev.com/b29773986fb56b3561cab32da7a10e108d1bb4e9/content/ppapi_plugin/ppapi_blink_platform_impl.h
[modify] https://crrev.com/b29773986fb56b3561cab32da7a10e108d1bb4e9/content/renderer/fetchers/resource_fetcher_impl.cc
[modify] https://crrev.com/b29773986fb56b3561cab32da7a10e108d1bb4e9/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/b29773986fb56b3561cab32da7a10e108d1bb4e9/content/renderer/render_frame_impl.h
[modify] https://crrev.com/b29773986fb56b3561cab32da7a10e108d1bb4e9/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/b29773986fb56b3561cab32da7a10e108d1bb4e9/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/b29773986fb56b3561cab32da7a10e108d1bb4e9/content/test/test_blink_web_unit_test_support.cc
[modify] https://crrev.com/b29773986fb56b3561cab32da7a10e108d1bb4e9/content/test/test_blink_web_unit_test_support.h
[modify] https://crrev.com/b29773986fb56b3561cab32da7a10e108d1bb4e9/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.h
[modify] https://crrev.com/b29773986fb56b3561cab32da7a10e108d1bb4e9/third_party/WebKit/Source/core/frame/FrameTestHelpers.h
[modify] https://crrev.com/b29773986fb56b3561cab32da7a10e108d1bb4e9/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/b29773986fb56b3561cab32da7a10e108d1bb4e9/third_party/WebKit/Source/core/frame/LocalFrame.h
[modify] https://crrev.com/b29773986fb56b3561cab32da7a10e108d1bb4e9/third_party/WebKit/Source/core/frame/LocalFrameClient.h
[modify] https://crrev.com/b29773986fb56b3561cab32da7a10e108d1bb4e9/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/b29773986fb56b3561cab32da7a10e108d1bb4e9/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/b29773986fb56b3561cab32da7a10e108d1bb4e9/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.h
[modify] https://crrev.com/b29773986fb56b3561cab32da7a10e108d1bb4e9/third_party/WebKit/Source/platform/loader/testing/FetchTestingPlatformSupport.cpp
[modify] https://crrev.com/b29773986fb56b3561cab32da7a10e108d1bb4e9/third_party/WebKit/Source/platform/loader/testing/FetchTestingPlatformSupport.h
[modify] https://crrev.com/b29773986fb56b3561cab32da7a10e108d1bb4e9/third_party/WebKit/Source/platform/loader/testing/MockFetchContext.h
[modify] https://crrev.com/b29773986fb56b3561cab32da7a10e108d1bb4e9/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp
[modify] https://crrev.com/b29773986fb56b3561cab32da7a10e108d1bb4e9/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h
[modify] https://crrev.com/b29773986fb56b3561cab32da7a10e108d1bb4e9/third_party/WebKit/Source/web/LocalFrameClientImpl.cpp
[modify] https://crrev.com/b29773986fb56b3561cab32da7a10e108d1bb4e9/third_party/WebKit/Source/web/LocalFrameClientImpl.h
[modify] https://crrev.com/b29773986fb56b3561cab32da7a10e108d1bb4e9/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/b29773986fb56b3561cab32da7a10e108d1bb4e9/third_party/WebKit/Source/web/WebLocalFrameImpl.h
[modify] https://crrev.com/b29773986fb56b3561cab32da7a10e108d1bb4e9/third_party/WebKit/public/platform/Platform.h
[modify] https://crrev.com/b29773986fb56b3561cab32da7a10e108d1bb4e9/third_party/WebKit/public/web/WebFrameClient.h
[modify] https://crrev.com/b29773986fb56b3561cab32da7a10e108d1bb4e9/third_party/WebKit/public/web/WebLocalFrame.h

Comment 3 by kinuko@chromium.org, Aug 2 2017

Blocking: 751427

Comment 4 by kinuko@chromium.org, Oct 4 2017

Owner: kinuko@chromium.org
Status: Fixed (was: Available)
I think we can close this, this could probably be achieved via https://bugs.chromium.org/p/chromium/issues/detail?id=712913#c26
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67426804b31a71503626bbeedea75b5d1c936665

commit 67426804b31a71503626bbeedea75b5d1c936665
Author: Kinuko Yasuda <kinuko@chromium.org>
Date: Thu Oct 12 05:57:48 2017

Add ChildURLLoaderFactoryGetter::GetFactoryForURL()

We have multiple similar code that checks request.Url().ProtocolIs(kBlobScheme)
just to return BlobURLLoaderFactory, which should be probably removed.

This patch adds ChildURLLoaderFactoryGetter::GetFactoryForURL()
which centralizes the code to return appropriate URLLoaderFactory for
a given request URL.

Bug:  730338 
Change-Id: If3ebcfb4b6c1367e7ee3c97e8a6e32256343a780
Reviewed-on: https://chromium-review.googlesource.com/710274
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508264}
[modify] https://crrev.com/67426804b31a71503626bbeedea75b5d1c936665/content/child/child_url_loader_factory_getter_impl.cc
[modify] https://crrev.com/67426804b31a71503626bbeedea75b5d1c936665/content/child/child_url_loader_factory_getter_impl.h
[modify] https://crrev.com/67426804b31a71503626bbeedea75b5d1c936665/content/public/child/child_url_loader_factory_getter.h
[modify] https://crrev.com/67426804b31a71503626bbeedea75b5d1c936665/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/67426804b31a71503626bbeedea75b5d1c936665/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/67426804b31a71503626bbeedea75b5d1c936665/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/67426804b31a71503626bbeedea75b5d1c936665/content/renderer/service_worker/service_worker_fetch_context_impl.cc
[modify] https://crrev.com/67426804b31a71503626bbeedea75b5d1c936665/content/renderer/service_worker/worker_fetch_context_impl.cc

Comment 6 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.
►

Sign in to add a comment