New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 730330 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Context Menu should feature in and out animations

Project Member Reported by bbergher@chromium.org, Jun 7 2017

Issue description

The context menu should animate in from the trigger point, with a scale up animation, and animate out with a scale down animation, to the center of the screen.
 
i thought we discussed animating the menu out to the trigger point to "tell the story".
I thought you had told me that wasn't possible. Let's definitely animate back to the origin point if we can, then.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/facb458c362b51cbe79dc41b6a2680c8b76ea4c5

commit facb458c362b51cbe79dc41b6a2680c8b76ea4c5
Author: injae <injae@google.com>
Date: Tue Jun 13 19:37:26 2017

added scale animation for context menu

BUG=655359,  730330 

Review-Url: https://codereview.chromium.org/2868403003
Cr-Commit-Position: refs/heads/master@{#479100}

[add] https://crrev.com/facb458c362b51cbe79dc41b6a2680c8b76ea4c5/chrome/android/java/res/drawable/grey_with_top_rounded_corners.xml
[modify] https://crrev.com/facb458c362b51cbe79dc41b6a2680c8b76ea4c5/chrome/android/java/res/layout/tabular_context_menu.xml
[modify] https://crrev.com/facb458c362b51cbe79dc41b6a2680c8b76ea4c5/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/facb458c362b51cbe79dc41b6a2680c8b76ea4c5/chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionActivity.java
[modify] https://crrev.com/facb458c362b51cbe79dc41b6a2680c8b76ea4c5/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java
[modify] https://crrev.com/facb458c362b51cbe79dc41b6a2680c8b76ea4c5/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java
[modify] https://crrev.com/facb458c362b51cbe79dc41b6a2680c8b76ea4c5/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java
[modify] https://crrev.com/facb458c362b51cbe79dc41b6a2680c8b76ea4c5/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuViewPager.java
[add] https://crrev.com/facb458c362b51cbe79dc41b6a2680c8b76ea4c5/chrome/android/java/src/org/chromium/chrome/browser/widget/ContextMenuDialog.java
[modify] https://crrev.com/facb458c362b51cbe79dc41b6a2680c8b76ea4c5/chrome/android/java_sources.gni
[modify] https://crrev.com/facb458c362b51cbe79dc41b6a2680c8b76ea4c5/chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUiTest.java
[modify] https://crrev.com/facb458c362b51cbe79dc41b6a2680c8b76ea4c5/chrome/android/junit/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulatorTest.java
[modify] https://crrev.com/facb458c362b51cbe79dc41b6a2680c8b76ea4c5/chrome/browser/ui/android/context_menu_helper.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment