Height and position transition for context menu is abrupt |
||
Issue descriptionWhen the height of the menu changes (for example, when switching between tabs), if should ideally transition smoothly, at the same time as the tab animation happens. The dialog should also be recentered with a smooth animation, at the same time.
,
Jul 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04a7c3fcd6d8d600f2aec4a89e260443dbf21f58 commit 04a7c3fcd6d8d600f2aec4a89e260443dbf21f58 Author: danielpark <danielpark@chromium.org> Date: Fri Jul 21 00:13:11 2017 -Adds clip and translation animations for context menu. -Adds logic to correctly resize on orientation changes. -Adds logic to set clip bounds on resize (i.e. image loads or context menu shows/hides all of the link text). -Sets rounded corners programmatically instead of in the context menu's xml file. Note: this does not handle the image loading or link text view enlargement animations. BUG= 730329 Review-Url: https://codereview.chromium.org/2960743002 Cr-Commit-Position: refs/heads/master@{#488506} [modify] https://crrev.com/04a7c3fcd6d8d600f2aec4a89e260443dbf21f58/chrome/android/java/res/layout/tabular_context_menu.xml [modify] https://crrev.com/04a7c3fcd6d8d600f2aec4a89e260443dbf21f58/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuViewPager.java
,
Jul 21 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by danielpark@chromium.org
, Jul 14 2017