Spacing and sizing of elements in context menu headers are incorrect |
||||
Issue description- In Image menus, there's no space between the thumbnail and the URL - In Image menus, the thumbnail is generally way too small - In link menus, space above and below URLs is uneven Thumbnail size should be limited to: Max Width: Available width - 30dp (padding) Max Height: 150dp Reference mocks attached, but please refer to the spec for details.
,
Aug 23 2017
,
Nov 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0de667715c86e500f4fa0b3309b4a5c699f7054d commit 0de667715c86e500f4fa0b3309b4a5c699f7054d Author: Daniel Park <danielpark@chromium.org> Date: Fri Nov 03 21:20:47 2017 [Android] Tweak spacing and sizing of revamped context menu UI -Add new parameter to native image retrieving methods so they include a max height & max width instead of only a max size. Per design specs: -Add spacing above & padding adjacent to the image view. -Add spacing above and below the text for links. -Add a max width and max height for images in the context menu. Bug: 730325 Change-Id: If2552bc27b8fb89771b0d444868148d5189c6e4b Reviewed-on: https://chromium-review.googlesource.com/742481 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Daniel Park <danielpark@chromium.org> Cr-Commit-Position: refs/heads/master@{#513913} [modify] https://crrev.com/0de667715c86e500f4fa0b3309b4a5c699f7054d/chrome/android/java/res/layout/tabular_context_menu_page.xml [modify] https://crrev.com/0de667715c86e500f4fa0b3309b4a5c699f7054d/chrome/android/java/res/values-sw600dp/dimens.xml [modify] https://crrev.com/0de667715c86e500f4fa0b3309b4a5c699f7054d/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/0de667715c86e500f4fa0b3309b4a5c699f7054d/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java [modify] https://crrev.com/0de667715c86e500f4fa0b3309b4a5c699f7054d/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java [modify] https://crrev.com/0de667715c86e500f4fa0b3309b4a5c699f7054d/chrome/browser/ui/android/context_menu_helper.cc [modify] https://crrev.com/0de667715c86e500f4fa0b3309b4a5c699f7054d/chrome/browser/ui/android/context_menu_helper.h
,
Nov 3 2017
@hannahs can you confirm if the new patch fixed this?
,
Nov 13 2017
Re-assigning to hannah to confirm
,
Nov 13 2017
Hey! Had a quick gchat with Dan with some non blocking questions but everything lgtm. (The apk I reviewed didn't have any image previews or icons in the context menu so just wanted to confirm that was the correct version).
,
Feb 15 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by danielpark@chromium.org
, Jul 11 2017