New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 730314 link

Starred by 5 users

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Chrome_Mac: Crash Report "Missing Touches. This is a bug in IOHIDFamily" after -[NSTextView(NSTextView_TouchBar_API) updateTextTouchBarItems] - (-[NSApplication _crashOnException:])

Project Member Reported by tapted@chromium.org, Jun 7 2017

Issue description

Product name: Chrome_Mac
Magic Signature: -[NSApplication _crashOnException:]

This extends  Issue 708495 

I suspect this is still an AppKit bug, but there are some interesting properties of the crash in http://go/crash/e6ea7f51f0000000 that aren't captured in crbug and would be nice to include for keyword searches.


If someone can reproduce, please leave a note - we may be able to get a fix.


The crash has

firstexception: NSAccessibilityException reason "AXDescription" attribute unsupported by: <NSButton: 0x60800075da60>

lastexception: NSInternalInconsistency Exception reason 518485937.834000 Missing Touches. This is a bug in IOHIDFamily

With stacks

0x0001548d [libobjc.A.dylib +	 0x1548d] objc_exception_throw
0x001112c9 [CoreFoundation +	 0x1112c9] -[NSException raise]
0x00016642 [AppKit +	 0x16642] NSAccessibilityAttributeValue
0x000d360a [AppKit +	 0xd360a] NSAccessibilityGetObjectForAttributeUsingLegacyAPI
0x00663ef7 [AppKit +	 0x663ef7] __NSAccessibilityGetObjectValueForAttribute_block_invoke
0x00663e88 [AppKit +	 0x663e88] NSAccessibilityPerformEntryPointObject
0x000d281e [AppKit +	 0xd281e] NSAccessibilityGetObjectValueForAttribute
0x00730304 [AppKit +	 0x730304] -[NSResponder accessibilityLabel]
0x004cbe96 [AppKit +	 0x4cbe96] -[NSButton accessibilityLabel]
0x00b4abc7 [AppKit +	 0xb4abc7] -[NSTextTouchBarItemController textAlignmentItem]
0x00b4c040 [AppKit +	 0xb4c040] -[NSTextTouchBarItemController setSelectedAttributesWithEnumrator:]
0x009a752e [AppKit +	 0x9a752e] -[NSTextView(NSTextView_TouchBar_API) updateTextTouchBarItems]
0x00104a63 [AppKit +	 0x104a63] -[NSTextView updateFontPanel]
0x00132010 [AppKit +	 0x132010] -[NSTextView(NSSharing) setSelectedRanges:affinity:stillSelecting:]
0x000186bc [UIFoundation +	 0x186bc] -[NSLayoutManager textStorage:edited:range:changeInLength:invalidatedRange:]


0x0001548d [libobjc.A.dylib +	 0x1548d] objc_exception_throw
0x00116082 [CoreFoundation +	 0x116082] +[NSException raise:format:arguments:]
0x0014ee36 [Foundation +	 0x14ee36] -[NSAssertionHandler handleFailureInFunction:file:lineNumber:description:]
0x005d71b3 [AppKit +	 0x5d71b3] -[NSEvent _initDigitizerTouchesFromIOHidEvent:window:contextID:]
0x005d8f19 [AppKit +	 0x5d8f19] -[NSEvent _initWithCGEvent:eventRef:]
0x007c29bf [AppKit +	 0x7c29bf] -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:]
0x015dbb10 [Google Chrome Framework -	 chrome_browser_application_mac.mm:187] __71-[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:]_block_invoke
0x01a31d6a [Google Chrome Framework +	 0x1a31d6a] base::mac::CallWithEHFrame(void () block_pointer)
0x015dba49 [Google Chrome Framework -	 chrome_browser_application_mac.mm:192] -[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:]
0x0003b7ab [AppKit +	 0x3b7ab] -[NSApplication run]
0x01a41cae [Google Chrome Framework -	 message_pump_mac.mm:772] base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*)
0x01a412cc [Google Chrome Framework -	 message_pump_mac.mm:300] base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*)
0x01a5f8a3 [Google Chrome Framework -	 run_loop.cc:38] base::RunLoop::Run()
0x015e1889 [Google Chrome Framework -	 chrome_browser_main.cc:2009] ChromeBrowserMainParts::MainMessageLoopRun(int*)
0x004b2274 [Google Chrome Framework -	 browser_main_loop.cc:1185] content::BrowserMainLoop::RunMainMessageLoopParts()
0x004b5222 [Google Chrome Framework -	 memory:2586] content::BrowserMainRunnerImpl::Run()
0x004ade7c [Google Chrome Framework -	 browser_main.cc:46] content::BrowserMain(content::MainFunctionParams const&)


Current link:
https://crash.corp.google.com/browse?q=reportid%3D'e6ea7f51f0000000'%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D'-%5BNSApplication%20_crashOnException%3A%5D'&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D#3



Search properties:
reportid: e6ea7f51f0000000

Metadata :
Product Name: Chrome_Mac
Product Version: 58.0.3029.110
Report ID: e6ea7f51f0000000
Report Time: Tue, 06 Jun 2017 23:52:17 GMT
Uptime: 523240000 ms
Cumulative Uptime: 0 ms
User Email: 
OS Name: Mac OS X
OS Version: 10.12.4 16E195
CPU Architecture: amd64
CPU Info: family 6 model 78 stepping 3


 
Project Member

Comment 1 by sheriffbot@chromium.org, Jun 7 2017

Labels: Fracas FoundIn-M-61
Users experienced this crash on the following builds:

Mac Canary 61.0.3122.0 -  0.20 CPM, 1 reports, 1 clients (signature -[NSApplication _crashOnException:])

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 8 2017

Labels: FoundIn-M-59
Users experienced this crash on the following builds:

Mac Beta 59.0.3071.86 -  0.20 CPM, 3 reports, 3 clients (signature -[NSApplication _crashOnException:])

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 9 2017

Labels: FoundIn-M-60
Users experienced this crash on the following builds:

Mac Dev 60.0.3112.20 -  0.58 CPM, 4 reports, 4 clients (signature -[NSApplication _crashOnException:])

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas
Just to update, latest crash rates on all channels are as below:
This crash not seen in latest Canary.

61.0.3128.0	0.00%	3
61.0.3124.4	0.00%	1	-Dev
60.0.3112.24	0.01%	8       -Beta
59.0.3071.86	0.42%	350	-Stable

Link to the list of builds:
---------------------------
https://crash.corp.google.com/browse?q=custom_data.ChromeCrashProto.ptype%3D%27browser%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D%27-%5BNSApplication%20_crashOnException%3A%5D%27&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D#-property-selector,samplereports:5,productversion:1000

Thank You!

Comment 5 by rsesek@chromium.org, Jun 13 2017

Labels: -Fracas Fracas-Wrong
Issue 735575 has been merged into this issue.
Just to update, latest crash rates on all channels are as below:
This crash not seen on latest Canary.

61.0.3152.0	0.00%	2	
61.0.3141.7	0.01%	10	-Dev
60.0.3112.50	0.04%	34	-Beta
59.0.3071.115	5.36%	4337	-Stable

Thank You!
Just to update, latest crash rates on all channels are as below:

62.0.3165.0	0.00%	1	-Canary
61.0.3159.5	0.04%	32	-Dev
60.0.3112.72	0.02%	15	-Beta
59.0.3071.115	13.08%	11823	-Stable

Please find the builds link in above comments.

Thank You!


Comment 9 by tapted@chromium.org, Jul 25 2017

The link in #c4 is incorrect for this bug. Here we're only concerned with crashes annotated with "Missing Touches. This is a bug in IOHIDFamily"

Which is roughly one third of the crashes in #c4

https://crash.corp.google.com/browse?q=product.Name%3D%27Chrome_Mac%27%20OMIT%20RECORD%20IF%20SOME(ProductData.key%3D%27list_annotations%27%20AND%20ProductData.value%20LIKE%20%27%25This%20is%20a%20bug%20in%20IOHIDFamily%27)%20%3D%200&ignore_case=false&enable_rewrite=false&omit_field_name=&omit_field_value=&omit_field_opt=#samplereports

Interestingly.. they are all 10.12+.
Cc: pbomm...@chromium.org gov...@chromium.org
This is top#8 browser crash on latest Chrome Beta(61.0.3163.49) on Mac with 7 crashes from 7 clients, Please find details of all Chrome version where this crash was seen : https://goto.google.com/rfdzgb


On latest Chrome beta the majority of the crashes are from 10.11(5 crashes) and 10.12(2 crashes).

Note : Given this is top#10 in crash ranking I am not tagging the bug as blocker since the crash is present since M51.
Components: UI>Browser>Touchbar
Components: -UI>Browser>Touchbar
Cc: -spqc...@chromium.org
Owner: spqc...@chromium.org
Based on offline chat with Sarah we can ignore this crash for now.
Issue 762331 has been merged into this issue.
Status: Assigned (was: Available)
Mac triage: this is contributing quite a bit to the Mac browser crash rate - is there anything we can/should do here?
This looks like an API issue, but I'll investigate to see if anything we have on the touch bar is triggering it
Cc: spqc...@chromium.org
 Issue 806761  has been merged into this issue.
Sarah do we have any update on the fix, please let us know. Since we are still seeing these crashes on latest Chrome Stable i..e, 65.0.3325.162.

Please find crash impact here : https://goto.google.com/dyyuh
Sorry, I'm still investigating the cause of the issue. It looks like this is caused by [NSTouchDevice _touchingTouchesForContextId:] returning an empty set. I'm currently trying to figure out why.
Just to update the latest behavior of this issue, still crash instances are observed on chrome latest stable #66.0.3359.139 with 1527 instances. Currently this crash is ranked as number #3 under browser process for Mac platform.

Link to list of the builds:
----------------------------
https://crash.corp.google.com/browse?q=product.name%3D%27Chrome_Mac%27+AND+expanded_custom_data.ChromeCrashProto.ptype%3D%27browser%27+AND+expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27%5BUncaught+NSException%5D+NSInternalInconsistencyException+reason+%23.%23+Missing+Touches.+This+is+a+bug+in+IOHIDFamily%27#-samplereports,productversion:1000,-magicsignature:50,-magicsignature2:50,-stablesignature:50,-magicsignaturesorted:50

Thanks!
Labels: FoundIn-67 Target-68 FoundIn-68 FoundIn-69
Just to update the latest behavior of this issue in the latest channels:

Still seeing 911 crashes from 881 clients so far on latest Stable - 67.0.3396.99 on Mac OS. This crash is ranked as number #7 in 'Browser' Stable crashes. 

69.0.3472.3	0.00%	1 - Dev
68.0.3440.42	0.02%	5 - Beta
67.0.3396.99	4.06%	915 - Stable

Link to the list of builds:
-------------------------
https://crash.corp.google.com/browse?q=product_name%3D%27Chrome_Mac%27+AND+expanded_custom_data.ChromeCrashProto.channel%3D%27%27+AND+expanded_custom_data.ChromeCrashProto.ptype%3D%27browser%27+AND+expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27%5BUncaught+NSException%5D+NSInternalInconsistencyException+reason+%23.%23+Missing+Touches.+This+is+a+bug+in+IOHIDFamily%27

Thanks!
This crash happens pretty reliably for me after trying to two-finger-scroll on a chrome-window with the third-party-touchscreen-driver touchbase on the Mojave public beta.
Sorry, I was wrong, I don't have the excact same error (not after updateTextTouchBarItems)

Exception Type:        EXC_BAD_INSTRUCTION (SIGILL)
Exception Codes:       0x0000000000000001, 0x0000000000000000

Application Specific Information:
Crashing on exception: 553352722.790308 Missing Touches. This is a bug in IOHIDFamily

Application Specific Backtrace 1:
0   CoreFoundation                      0x00007fff4267d9d7 __exceptionPreprocess + 256
1   Google Chrome Framework             0x000000010ab1a461 ChromeMain + 33335585
2   libobjc.A.dylib                     0x00007fff6e486a18 objc_exception_throw + 48
3   CoreFoundation                      0x00007fff426817dc +[NSException raise:format:arguments:] + 98
4   Foundation                          0x00007fff44b05dd3 -[NSAssertionHandler handleFailureInFunction:file:lineNumber:description:] + 166
5   AppKit                              0x00007fff400f597d -[NSEvent _initDigitizerTouchesFromIOHidEvent:window:contextID:] + 1517
6   AppKit                              0x00007fff400f8731 -[NSEvent _initWithCGEvent:eventRef:] + 4112
7   AppKit                              0x00007fff402e826e -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1866
8   Google Chrome Framework             0x000000010aa7f070 ChromeMain + 32699696
9   Google Chrome Framework             0x000000010ae4e15a ChromeMain + 36693530
10  Google Chrome Framework             0x000000010aa7efa4 ChromeMain + 32699492
11  AppKit                              0x00007fff3fb948ae -[NSApplication run] + 699
12  Google Chrome Framework             0x000000010ae5e6dc ChromeMain + 36760476
13  Google Chrome Framework             0x000000010ae5d25e ChromeMain + 36755230
14  Google Chrome Framework             0x000000010ae7fc85 ChromeMain + 36897093
15  Google Chrome Framework             0x000000010aa85b0b ChromeMain + 32726987
16  Google Chrome Framework             0x0000000109678914 ChromeMain + 11701716
17  Google Chrome Framework             0x000000010967ae82 ChromeMain + 11711298
18  Google Chrome Framework             0x00000001096753cb ChromeMain + 11688075
19  Google Chrome Framework             0x000000010aa39a48 ChromeMain + 32415496
20  Google Chrome Framework             0x000000010c370fcd ChromeMain + 58856589
21  Google Chrome Framework             0x000000010aa38af4 ChromeMain + 32411572
22  Google Chrome Framework             0x0000000108b4fbf3 ChromeMain + 179
23  Google Chrome Canary                0x0000000103916dd1 main + 385
24  libdyld.dylib                       0x00007fff6f4623ed start + 1
25  ???                                 0x0000000000000001 0x0 + 1
Owner: ellyjo...@chromium.org
Labels: -Target-68 Target-71
Owner: a...@chromium.org
Frequency of this has dropped off quite a bit but it still seems to be around. avi@, want to take a crack at it?
Just to update the latest behavior of this issue in the latest channels:

Still seeing 546 crashes from 530 clients so far on latest Stable - 70.0.3538.102 on Mac OS. This crash is ranked as #15 in 'Browser' Stable crashes. 

72.0.3614.0	0.01%	1 - Canary
71.0.3578.53	0.01%	1 - Beta
70.0.3538.102	5.41%	546 - Stable

Link to the list of builds:
-------------------------
https://crash.corp.google.com/browse?q=product_name%3D%27Chrome_Mac%27+AND+expanded_custom_data.ChromeCrashProto.ptype%3D%27browser%27+AND+expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27%5BUncaught+NSException%5D+NSInternalInconsistencyException+reason+%23.%23+Missing+Touches.+This+is+a+bug+in+IOHIDFamily%27

Thanks!
Owner: sdy@chromium.org
mac triage: to sdy@ for touchbar :)

Sign in to add a comment