I'm updating the arguments being passed to the CommandLineFlags.Add call [1] in
src/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java
When I run git cl format it spews that call this way:
@CommandLineFlags.
Add({"enable-features=OfflinePagesSharing", ChromeSwitches.DISABLE_FIRST_RUN_EXPERIENCE,
ChromeActivityTestRule.DISABLE_NETWORK_PREDICTION_FLAG})
But then when I try to upload my changes I get the following presubmit errors:
chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java:46:18: '.' should be on a new line.
chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java:47: 'Add' have incorrect indentation level 0, expected level should be 8.
Beyond filing this issue so that this inconsistency is addressed I'd also like to know what formatting and procedure should I use now to move on with my CL?
[1] https://cs.chromium.org/chromium/src/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java?q="CommandLineFlags.Add"
Comment 1 by carlosk@chromium.org
, Jun 7 2017