New issue
Advanced search Search tips

Issue 730291 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

DCHECK failure in BackgroundDownloader::TimerIsRunning

Project Member Reported by thestig@chromium.org, Jun 7 2017

Issue description

Chrome Version: Local build at r476830 with DCHECKs enabled.
OS: Windows

I left a debug build idling, and it crashed on its own with:

[25208:21220:0606/183711.007:FATAL:timer.cc(108)] Check failed: origin_sequence_checker_.CalledOnValidSequence().
Backtrace:
        base::debug::StackTrace::StackTrace [0x0000000000A52E45+69]
        base::debug::StackTrace::StackTrace [0x0000000000A52968+24]
        logging::LogMessage::~LogMessage [0x0000000000AC50C0+112]
        base::Timer::IsRunning [0x0000000000D17383+163]
        update_client::BackgroundDownloader::TimerIsRunning [0x0000000005787AA9+73]
        update_client::BackgroundDownloader::EndDownload [0x0000000005784BC8+232]
        update_client::BackgroundDownloader::OnStateTransferred [0x0000000005786D7F+31]
        update_client::BackgroundDownloader::OnDownloading [0x0000000005786919+393]
        ....

 

Comment 1 by sorin@chromium.org, Jun 7 2017

Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f81c5f0e622cd1eb2bac723744a5a0f5c6b7837d

commit f81c5f0e622cd1eb2bac723744a5a0f5c6b7837d
Author: Sorin Jianu <sorin@chromium.org>
Date: Thu Jun 08 00:22:47 2017

Fix DCHECK failure in BackgroundDownloader::TimerIsRunning.

Bug:  730291 
Change-Id: I1e0b4f83c3235ee05d9c9724c6d31f86b12ccd85
Reviewed-on: https://chromium-review.googlesource.com/527852
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477825}
[modify] https://crrev.com/f81c5f0e622cd1eb2bac723744a5a0f5c6b7837d/components/update_client/background_downloader_win.cc
[modify] https://crrev.com/f81c5f0e622cd1eb2bac723744a5a0f5c6b7837d/components/update_client/background_downloader_win.h

Comment 3 by sorin@chromium.org, Jun 8 2017

Cc: waff...@chromium.org
Status: Fixed (was: Started)

Sign in to add a comment