New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 730284 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[SPv2] Create clip node for replaced elements with border-radius

Project Member Reported by trchen@chromium.org, Jun 7 2017

Issue description

Unlike most block-like elements that uses padding box for overflow clip, replaced elements uses content box instead.

Note that replaced elements' content always has the same size as the content box (except embedded SVGs), i.e. inherently can't overflow unless there is rounded corner. They simply ignore CSS overflow property (again, except for embedded SVGs) and always apply a clip when border-radius is present.
 
Blocking: 726041
Blocking: -726041
Labels: BugSource-Team PaintTeamTriaged-20170608
Status: Fixed (was: Assigned)
I believe this has been fixed for SPv175.
Status: Assigned (was: Fixed)
We just need to examine the following tests for SPv2 for rebaseline or filing remaining bugs:

 crbug.com/730284  fast/borders/border-radius-mask-canvas-all.html [ Failure ]
 crbug.com/730284  fast/borders/border-radius-mask-canvas-border.html [ Failure ]
 crbug.com/730284  fast/borders/border-radius-mask-canvas-padding.html [ Failure ]
 crbug.com/730284  fast/borders/border-radius-mask-canvas-with-mask.html [ Failure ]
 crbug.com/730284  fast/borders/border-radius-mask-canvas-with-shadow.html [ Failure ]
 crbug.com/730284  fast/borders/border-radius-mask-canvas.html [ Failure ]
 crbug.com/730284  fast/borders/border-radius-mask-video-ratio.html [ Failure ]
 crbug.com/730284  fast/borders/border-radius-mask-video-shadow.html [ Failure ]
 crbug.com/730284  fast/borders/border-radius-mask-video.html [ Failure ]
 crbug.com/730284  fast/replaced/border-radius-clip.html [ Failure ]

Comment 6 by trchen@chromium.org, May 29 2018

I think my initial comments were not entirely true, there are a few cases that replaced contents can overflow, e.g. object-fit:cover. Also I think it is not quite right to mux overflow clip node for replaced content clip, because the shadow DOM (common in videos for media control) should be clipped to padding box, not the content box.

IMO the cleanest way is to add a transform node and a clip node for replaced contents. Both non-composited and directly composited replaced elements can benefit from it.
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ea138d60b5c616ac59cd0561022a3105fd35f01

commit 0ea138d60b5c616ac59cd0561022a3105fd35f01
Author: Tien-Ren Chen <trchen@chromium.org>
Date: Thu Jul 19 01:51:01 2018

[Blink] Unify pre-snapping of <video> to match <iframe>

This CL changes the pre-snapping policy of <video> so that only the size
of the contents is pre-snapped, while the location will exactly match the
content box's final location.

BUG= 730284 

Change-Id: Id10bd0fbd8021a11b7db4a2950a908f3d1b50ac0
Reviewed-on: https://chromium-review.googlesource.com/1141328
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576317}
[modify] https://crrev.com/0ea138d60b5c616ac59cd0561022a3105fd35f01/third_party/WebKit/LayoutTests/platform/linux/compositing/geometry/video-fixed-scrolling-expected.png
[modify] https://crrev.com/0ea138d60b5c616ac59cd0561022a3105fd35f01/third_party/WebKit/LayoutTests/platform/linux/compositing/geometry/video-opacity-overlay-expected.png
[add] https://crrev.com/0ea138d60b5c616ac59cd0561022a3105fd35f01/third_party/WebKit/LayoutTests/platform/mac-retina/compositing/geometry/video-fixed-scrolling-expected.png
[add] https://crrev.com/0ea138d60b5c616ac59cd0561022a3105fd35f01/third_party/WebKit/LayoutTests/platform/mac-retina/compositing/geometry/video-opacity-overlay-expected.png
[add] https://crrev.com/0ea138d60b5c616ac59cd0561022a3105fd35f01/third_party/WebKit/LayoutTests/platform/mac-retina/compositing/visibility/visibility-simple-video-layer-expected.png
[add] https://crrev.com/0ea138d60b5c616ac59cd0561022a3105fd35f01/third_party/WebKit/LayoutTests/platform/mac-retina/media/color-profile-video-seek-object-fit-expected.png
[add] https://crrev.com/0ea138d60b5c616ac59cd0561022a3105fd35f01/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/threaded/compositing/visibility/visibility-simple-video-layer-expected.png
[add] https://crrev.com/0ea138d60b5c616ac59cd0561022a3105fd35f01/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/video-surface-layer/media/color-profile-video-seek-object-fit-expected.png
[modify] https://crrev.com/0ea138d60b5c616ac59cd0561022a3105fd35f01/third_party/WebKit/LayoutTests/platform/mac/compositing/geometry/video-fixed-scrolling-expected.png
[modify] https://crrev.com/0ea138d60b5c616ac59cd0561022a3105fd35f01/third_party/WebKit/LayoutTests/platform/mac/compositing/geometry/video-opacity-overlay-expected.png
[modify] https://crrev.com/0ea138d60b5c616ac59cd0561022a3105fd35f01/third_party/WebKit/LayoutTests/platform/mac/compositing/visibility/visibility-simple-video-layer-expected.png
[modify] https://crrev.com/0ea138d60b5c616ac59cd0561022a3105fd35f01/third_party/WebKit/LayoutTests/platform/mac/media/color-profile-video-seek-object-fit-expected.png
[modify] https://crrev.com/0ea138d60b5c616ac59cd0561022a3105fd35f01/third_party/WebKit/LayoutTests/platform/win/compositing/geometry/video-fixed-scrolling-expected.png
[modify] https://crrev.com/0ea138d60b5c616ac59cd0561022a3105fd35f01/third_party/WebKit/LayoutTests/platform/win/compositing/geometry/video-opacity-overlay-expected.png
[modify] https://crrev.com/0ea138d60b5c616ac59cd0561022a3105fd35f01/third_party/WebKit/LayoutTests/platform/win/compositing/visibility/visibility-simple-video-layer-expected.png
[modify] https://crrev.com/0ea138d60b5c616ac59cd0561022a3105fd35f01/third_party/WebKit/LayoutTests/platform/win/media/color-profile-video-seek-object-fit-expected.png
[modify] https://crrev.com/0ea138d60b5c616ac59cd0561022a3105fd35f01/third_party/blink/renderer/core/layout/layout_embedded_content.cc
[modify] https://crrev.com/0ea138d60b5c616ac59cd0561022a3105fd35f01/third_party/blink/renderer/core/layout/layout_replaced.cc
[modify] https://crrev.com/0ea138d60b5c616ac59cd0561022a3105fd35f01/third_party/blink/renderer/core/layout/layout_replaced.h
[modify] https://crrev.com/0ea138d60b5c616ac59cd0561022a3105fd35f01/third_party/blink/renderer/core/layout/layout_video.cc

I suspect that the CL above broke a number of tests, I will revert it:
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.13%20%28retina%29/63

Unexpected Failures:
* compositing/geometry/video-fixed-scrolling.html
* compositing/geometry/video-opacity-overlay.html
* compositing/visibility/visibility-simple-video-layer.html
* media/color-profile-video-seek-object-fit.html
* virtual/new-remote-playback-pipeline/media/controls/text-track-menu-pointer-selection.html
* virtual/threaded/compositing/visibility/visibility-simple-video-layer.html
* virtual/video-surface-layer/media/color-profile-video-seek-object-fit.html
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee930b05acca04657f1b073552494c8f1d2563b6

commit ee930b05acca04657f1b073552494c8f1d2563b6
Author: Christian Dullweber <dullweber@chromium.org>
Date: Thu Jul 19 11:05:42 2018

Revert "[Blink] Unify pre-snapping of <video> to match <iframe>"

This reverts commit 0ea138d60b5c616ac59cd0561022a3105fd35f01.

Reason for revert: The CL probably broke a number of tests:
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.13%20%28retina%29/63


Original change's description:
> [Blink] Unify pre-snapping of <video> to match <iframe>
> 
> This CL changes the pre-snapping policy of <video> so that only the size
> of the contents is pre-snapped, while the location will exactly match the
> content box's final location.
> 
> BUG= 730284 
> 
> Change-Id: Id10bd0fbd8021a11b7db4a2950a908f3d1b50ac0
> Reviewed-on: https://chromium-review.googlesource.com/1141328
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576317}

TBR=trchen@chromium.org,chrishtr@chromium.org

Change-Id: I518e659cbab820263480b02ae347c99468dd95fa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  730284 
Reviewed-on: https://chromium-review.googlesource.com/1143205
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576438}
[modify] https://crrev.com/ee930b05acca04657f1b073552494c8f1d2563b6/third_party/WebKit/LayoutTests/platform/linux/compositing/geometry/video-fixed-scrolling-expected.png
[modify] https://crrev.com/ee930b05acca04657f1b073552494c8f1d2563b6/third_party/WebKit/LayoutTests/platform/linux/compositing/geometry/video-opacity-overlay-expected.png
[delete] https://crrev.com/4a27ce9d6c8c89b86063bce752da95bc380a854e/third_party/WebKit/LayoutTests/platform/mac-retina/compositing/geometry/video-fixed-scrolling-expected.png
[delete] https://crrev.com/4a27ce9d6c8c89b86063bce752da95bc380a854e/third_party/WebKit/LayoutTests/platform/mac-retina/compositing/geometry/video-opacity-overlay-expected.png
[delete] https://crrev.com/4a27ce9d6c8c89b86063bce752da95bc380a854e/third_party/WebKit/LayoutTests/platform/mac-retina/compositing/visibility/visibility-simple-video-layer-expected.png
[delete] https://crrev.com/4a27ce9d6c8c89b86063bce752da95bc380a854e/third_party/WebKit/LayoutTests/platform/mac-retina/media/color-profile-video-seek-object-fit-expected.png
[delete] https://crrev.com/4a27ce9d6c8c89b86063bce752da95bc380a854e/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/threaded/compositing/visibility/visibility-simple-video-layer-expected.png
[delete] https://crrev.com/4a27ce9d6c8c89b86063bce752da95bc380a854e/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/video-surface-layer/media/color-profile-video-seek-object-fit-expected.png
[modify] https://crrev.com/ee930b05acca04657f1b073552494c8f1d2563b6/third_party/WebKit/LayoutTests/platform/mac/compositing/geometry/video-fixed-scrolling-expected.png
[modify] https://crrev.com/ee930b05acca04657f1b073552494c8f1d2563b6/third_party/WebKit/LayoutTests/platform/mac/compositing/geometry/video-opacity-overlay-expected.png
[modify] https://crrev.com/ee930b05acca04657f1b073552494c8f1d2563b6/third_party/WebKit/LayoutTests/platform/mac/compositing/visibility/visibility-simple-video-layer-expected.png
[modify] https://crrev.com/ee930b05acca04657f1b073552494c8f1d2563b6/third_party/WebKit/LayoutTests/platform/mac/media/color-profile-video-seek-object-fit-expected.png
[modify] https://crrev.com/ee930b05acca04657f1b073552494c8f1d2563b6/third_party/WebKit/LayoutTests/platform/win/compositing/geometry/video-fixed-scrolling-expected.png
[modify] https://crrev.com/ee930b05acca04657f1b073552494c8f1d2563b6/third_party/WebKit/LayoutTests/platform/win/compositing/geometry/video-opacity-overlay-expected.png
[modify] https://crrev.com/ee930b05acca04657f1b073552494c8f1d2563b6/third_party/WebKit/LayoutTests/platform/win/compositing/visibility/visibility-simple-video-layer-expected.png
[modify] https://crrev.com/ee930b05acca04657f1b073552494c8f1d2563b6/third_party/WebKit/LayoutTests/platform/win/media/color-profile-video-seek-object-fit-expected.png
[modify] https://crrev.com/ee930b05acca04657f1b073552494c8f1d2563b6/third_party/blink/renderer/core/layout/layout_embedded_content.cc
[modify] https://crrev.com/ee930b05acca04657f1b073552494c8f1d2563b6/third_party/blink/renderer/core/layout/layout_replaced.cc
[modify] https://crrev.com/ee930b05acca04657f1b073552494c8f1d2563b6/third_party/blink/renderer/core/layout/layout_replaced.h
[modify] https://crrev.com/ee930b05acca04657f1b073552494c8f1d2563b6/third_party/blink/renderer/core/layout/layout_video.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4a6e81f654b77f4394b188f0acc98906bf3b224

commit f4a6e81f654b77f4394b188f0acc98906bf3b224
Author: Tien-Ren Chen <trchen@chromium.org>
Date: Fri Jul 20 03:02:29 2018

Reland "[Blink] Unify pre-snapping of <video> to match <iframe>"

This CL changes the pre-snapping policy of <video> so that only the size
of the contents is pre-snapped, while the location will exactly match the
content box's final location.

BUG= 730284 

Change-Id: I6d02bb09fc5d570f74b94923b6b806e16ed4f119
Reviewed-on: https://chromium-review.googlesource.com/1144256
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576765}
[modify] https://crrev.com/f4a6e81f654b77f4394b188f0acc98906bf3b224/third_party/WebKit/LayoutTests/platform/linux/compositing/geometry/video-fixed-scrolling-expected.png
[modify] https://crrev.com/f4a6e81f654b77f4394b188f0acc98906bf3b224/third_party/WebKit/LayoutTests/platform/linux/compositing/geometry/video-opacity-overlay-expected.png
[modify] https://crrev.com/f4a6e81f654b77f4394b188f0acc98906bf3b224/third_party/WebKit/LayoutTests/platform/mac/compositing/geometry/video-fixed-scrolling-expected.png
[modify] https://crrev.com/f4a6e81f654b77f4394b188f0acc98906bf3b224/third_party/WebKit/LayoutTests/platform/mac/compositing/geometry/video-opacity-overlay-expected.png
[modify] https://crrev.com/f4a6e81f654b77f4394b188f0acc98906bf3b224/third_party/WebKit/LayoutTests/platform/mac/compositing/visibility/visibility-simple-video-layer-expected.png
[modify] https://crrev.com/f4a6e81f654b77f4394b188f0acc98906bf3b224/third_party/WebKit/LayoutTests/platform/mac/media/color-profile-video-seek-object-fit-expected.png
[modify] https://crrev.com/f4a6e81f654b77f4394b188f0acc98906bf3b224/third_party/WebKit/LayoutTests/platform/win/compositing/geometry/video-fixed-scrolling-expected.png
[modify] https://crrev.com/f4a6e81f654b77f4394b188f0acc98906bf3b224/third_party/WebKit/LayoutTests/platform/win/compositing/geometry/video-opacity-overlay-expected.png
[modify] https://crrev.com/f4a6e81f654b77f4394b188f0acc98906bf3b224/third_party/WebKit/LayoutTests/platform/win/compositing/visibility/visibility-simple-video-layer-expected.png
[modify] https://crrev.com/f4a6e81f654b77f4394b188f0acc98906bf3b224/third_party/WebKit/LayoutTests/platform/win/media/color-profile-video-seek-object-fit-expected.png
[modify] https://crrev.com/f4a6e81f654b77f4394b188f0acc98906bf3b224/third_party/blink/renderer/core/layout/layout_embedded_content.cc
[modify] https://crrev.com/f4a6e81f654b77f4394b188f0acc98906bf3b224/third_party/blink/renderer/core/layout/layout_replaced.cc
[modify] https://crrev.com/f4a6e81f654b77f4394b188f0acc98906bf3b224/third_party/blink/renderer/core/layout/layout_replaced.h
[modify] https://crrev.com/f4a6e81f654b77f4394b188f0acc98906bf3b224/third_party/blink/renderer/core/layout/layout_video.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b36947af1d61837ba292b9159c927e26164863b5

commit b36947af1d61837ba292b9159c927e26164863b5
Author: Tien-Ren Chen <trchen@chromium.org>
Date: Tue Jul 24 00:11:59 2018

[Blink] Use OverflowClip node for replaced content clip

Previously replaced elements only create clip node if a border radius is
applied. This CL makes them to also create clip node if the replaced
contents may overflow due to object-fit.

Also previously the clip was created as InnerBorderRadius node, which is
not quite right because replaced elements uses content box instead of
padding box to clip. This CL makes it to use OverflowClip node instead.

As a side effect, embedded <svg> elements are now also clipped to
the content box. This matches the Firefox behavior.

BUG= 730284 

Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ie91069c11f8e4fc09d09a4a9fa940def6d2ad35f
Reviewed-on: https://chromium-review.googlesource.com/1142571
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577358}
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[add] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/fast/sub-pixel/iframe-overflow-due-to-snapping-expected.html
[add] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/fast/sub-pixel/iframe-overflow-due-to-snapping.html
[add] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/flag-specific/enable-blink-gen-property-trees/compositing/direct-image-compositing-expected.png
[add] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/borders/border-radius-mask-canvas-all-expected.png
[add] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/borders/border-radius-mask-canvas-all-expected.txt
[add] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/borders/border-radius-mask-canvas-border-expected.png
[add] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/borders/border-radius-mask-canvas-border-expected.txt
[add] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/borders/border-radius-mask-canvas-expected.png
[add] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/borders/border-radius-mask-canvas-expected.txt
[add] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/borders/border-radius-mask-canvas-padding-expected.png
[add] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/borders/border-radius-mask-canvas-padding-expected.txt
[add] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/borders/border-radius-mask-canvas-with-mask-expected.png
[add] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/borders/border-radius-mask-canvas-with-mask-expected.txt
[add] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/borders/border-radius-mask-canvas-with-shadow-expected.png
[add] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/borders/border-radius-mask-canvas-with-shadow-expected.txt
[add] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/borders/border-radius-mask-video-expected.png
[add] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/borders/border-radius-mask-video-expected.txt
[add] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/replaced/border-radius-clip-expected.png
[add] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/replaced/border-radius-clip-expected.txt
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/linux/media/controls/video-controls-with-cast-rendering-expected.txt
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/linux/media/controls/video-overlay-cast-dark-rendering-expected.txt
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/linux/media/controls/video-overlay-cast-light-rendering-expected.txt
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/linux/media/video-controls-rendering-expected.txt
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/linux/media/video-layer-crash-expected.txt
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/linux/media/video-zoom-expected.txt
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-svg-float-border-padding-expected.png
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.txt
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/video-overlay-cast-dark-rendering-expected.txt
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/video-overlay-cast-light-rendering-expected.txt
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor150/fast/hidpi/static/calendar-picker-appearance-expected.png
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls/video-controls-with-cast-rendering-expected.txt
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls/video-overlay-cast-dark-rendering-expected.txt
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls/video-overlay-cast-light-rendering-expected.txt
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-controls-rendering-expected.txt
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-layer-crash-expected.txt
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/mac/media/controls/video-controls-with-cast-rendering-expected.png
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/mac/media/controls/video-controls-with-cast-rendering-expected.txt
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/mac/media/controls/video-overlay-cast-dark-rendering-expected.txt
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/mac/media/controls/video-overlay-cast-light-rendering-expected.txt
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/mac/media/video-controls-rendering-expected.txt
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/mac/media/video-layer-crash-expected.txt
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/mac/media/video-poster-scale-expected.txt
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/mac/media/video-zoom-expected.txt
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.png
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/mac/virtual/video-surface-layer/media/video-controls-rendering-expected.txt
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/win/media/controls/video-controls-with-cast-rendering-expected.png
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/win/media/controls/video-controls-with-cast-rendering-expected.txt
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/win/media/controls/video-overlay-cast-dark-rendering-expected.txt
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/win/media/controls/video-overlay-cast-light-rendering-expected.txt
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/win/media/video-controls-rendering-expected.txt
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/win/media/video-layer-crash-expected.txt
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/win/media/video-poster-scale-expected.txt
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/win/media/video-zoom-expected.txt
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/win/svg/zoom/page/zoom-svg-float-border-padding-expected.png
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/win/virtual/scalefactor150/fast/hidpi/static/calendar-picker-appearance-expected.png
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/win/virtual/video-surface-layer/media/video-controls-rendering-expected.txt
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/platform/win7/virtual/scalefactor150/fast/hidpi/static/calendar-picker-appearance-expected.png
[add] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/svg/in-html/svg-clip-to-content-box-expected.html
[add] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/WebKit/LayoutTests/svg/in-html/svg-clip-to-content-box.html
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/blink/renderer/core/layout/layout_box.cc
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/blink/renderer/core/layout/layout_box.h
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/blink/renderer/core/paint/box_paint_invalidator.cc
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/blink/renderer/core/paint/box_paint_invalidator.h
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/blink/renderer/core/paint/embedded_content_painter.cc
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/blink/renderer/core/paint/paint_property_tree_builder_test.cc
[modify] https://crrev.com/b36947af1d61837ba292b9159c927e26164863b5/third_party/blink/renderer/core/paint/replaced_painter.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05d439bae59df4f21124c2bf2e7f96070fd0e796

commit 05d439bae59df4f21124c2bf2e7f96070fd0e796
Author: Tien-Ren Chen <trchen@chromium.org>
Date: Wed Jul 25 00:23:28 2018

[Blink] Unify replaced element clipping

Prior to this CL each replaced element type implemented its own clipping.
This CL refactors it so that a clip node will be applied in the common
path, ReplacedPainter::Paint(), so the specialized
XyzPainter::PaintReplaced() won't need to apply their own clips.

Note that ImagePainter still mutates its internal painting for changed
clip rect. This behavior should be changed in a follow-up CL, and
changing only the content box of a replaced element should only result
in incremental invalidation.

BUG= 730284 

Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia5c1412b1bd3182a22849d0b3196f3e72d52248a
Reviewed-on: https://chromium-review.googlesource.com/1147617
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577741}
[add] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/images/imagemap-focus-ring-with-paint-root-offset-expected.png
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/block-layout-inline-children-replaced-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/box/box-inline-resize-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/canvas-resize-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/canvas-resize-no-full-invalidation-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/clip/clipped-relative-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/clip/replaced-clipped-positioned-not-wrong-incremental-repainting-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/iframe-display-block-to-display-none-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/iframe-display-none-to-display-block-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/image/do-not-paint-below-image-baseline-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/image/image-resize-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/image/percent-size-image-resize-container-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/list-marker-2-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/position/positioned-list-offset-change-repaint-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/selection/selected-replaced-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/selection/selection-clear-after-move-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/transform/transform-replaced-shadows-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layer-canvas-log-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/paint/invalidation/block-layout-inline-children-replaced-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/paint/invalidation/canvas-resize-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/paint/invalidation/canvas-resize-no-full-invalidation-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/paint/invalidation/clip/replaced-clipped-positioned-not-wrong-incremental-repainting-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/paint/invalidation/compositing/squash-partial-repaint-inside-squashed-layer-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/paint/invalidation/image/do-not-paint-below-image-baseline-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/paint/invalidation/image/image-resize-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/paint/invalidation/image/percent-size-image-resize-container-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/paint/invalidation/selection/selection-clear-after-move-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/paint/invalidation/transform/transform-replaced-shadows-expected.txt
[add] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/platform/fuchsia/paint/invalidation/selection/selected-replaced-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/platform/linux/fast/replaced/selection-rect-transform-expected.png
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/box/box-inline-resize-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/image/canvas-composite-repaint-by-all-imagesource-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/platform/mac/fast/overflow/overflow-update-transform-expected.png
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/platform/mac/fast/replaced/selection-rect-transform-expected.png
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/box/box-inline-resize-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/clip/clipped-relative-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/image/canvas-composite-repaint-by-all-imagesource-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/list-marker-2-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/position/positioned-list-offset-change-repaint-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/selection/selected-replaced-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/platform/win/fast/overflow/overflow-update-transform-expected.png
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/platform/win/fast/replaced/selection-rect-transform-expected.png
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/box/box-inline-resize-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/clip/clipped-relative-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/image/canvas-composite-repaint-by-all-imagesource-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/list-marker-2-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/position/positioned-list-offset-change-repaint-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/selection/selected-replaced-expected.txt
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/blink/renderer/core/layout/layout_embedded_content.cc
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/blink/renderer/core/layout/layout_embedded_content.h
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/blink/renderer/core/layout/layout_embedded_object.cc
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/blink/renderer/core/layout/layout_embedded_object.h
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/blink/renderer/core/paint/embedded_content_painter.cc
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/blink/renderer/core/paint/embedded_content_painter.h
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/blink/renderer/core/paint/embedded_object_painter.cc
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/blink/renderer/core/paint/html_canvas_painter.cc
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/blink/renderer/core/paint/object_paint_invalidator_test.cc
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/blink/renderer/core/paint/replaced_painter.cc
[modify] https://crrev.com/05d439bae59df4f21124c2bf2e7f96070fd0e796/third_party/blink/renderer/core/paint/svg_root_painter.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726

commit 2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726
Author: Tien-Ren Chen <trchen@chromium.org>
Date: Wed Jul 25 23:32:47 2018

Revert "[Blink] Unify replaced element clipping"

This reverts commit 05d439bae59df4f21124c2bf2e7f96070fd0e796.

Reason for revert: Perf regression  crbug.com/867670 

Original change's description:
> [Blink] Unify replaced element clipping
> 
> Prior to this CL each replaced element type implemented its own clipping.
> This CL refactors it so that a clip node will be applied in the common
> path, ReplacedPainter::Paint(), so the specialized
> XyzPainter::PaintReplaced() won't need to apply their own clips.
> 
> Note that ImagePainter still mutates its internal painting for changed
> clip rect. This behavior should be changed in a follow-up CL, and
> changing only the content box of a replaced element should only result
> in incremental invalidation.
> 
> BUG= 730284 
> 
> Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: Ia5c1412b1bd3182a22849d0b3196f3e72d52248a
> Reviewed-on: https://chromium-review.googlesource.com/1147617
> Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#577741}

TBR=trchen@chromium.org,pdr@chromium.org

Change-Id: Ib91981e97c8558a462336f98f5ad219ef48bcef4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  730284 
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1150255
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578125}
[delete] https://crrev.com/3ab37f355f00d71bc26a5d56622b457f7c63ffa2/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/images/imagemap-focus-ring-with-paint-root-offset-expected.png
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/block-layout-inline-children-replaced-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/box/box-inline-resize-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/canvas-resize-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/canvas-resize-no-full-invalidation-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/clip/clipped-relative-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/clip/replaced-clipped-positioned-not-wrong-incremental-repainting-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/iframe-display-block-to-display-none-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/iframe-display-none-to-display-block-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/image/do-not-paint-below-image-baseline-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/image/image-resize-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/image/percent-size-image-resize-container-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/list-marker-2-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/position/positioned-list-offset-change-repaint-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/selection/selected-replaced-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/selection/selection-clear-after-move-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/transform/transform-replaced-shadows-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layer-canvas-log-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/paint/invalidation/block-layout-inline-children-replaced-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/paint/invalidation/canvas-resize-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/paint/invalidation/canvas-resize-no-full-invalidation-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/paint/invalidation/clip/replaced-clipped-positioned-not-wrong-incremental-repainting-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/paint/invalidation/compositing/squash-partial-repaint-inside-squashed-layer-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/paint/invalidation/image/do-not-paint-below-image-baseline-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/paint/invalidation/image/image-resize-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/paint/invalidation/image/percent-size-image-resize-container-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/paint/invalidation/selection/selection-clear-after-move-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/paint/invalidation/transform/transform-replaced-shadows-expected.txt
[delete] https://crrev.com/3ab37f355f00d71bc26a5d56622b457f7c63ffa2/third_party/WebKit/LayoutTests/platform/fuchsia/paint/invalidation/selection/selected-replaced-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/platform/linux/fast/replaced/selection-rect-transform-expected.png
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/box/box-inline-resize-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/image/canvas-composite-repaint-by-all-imagesource-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/platform/mac/fast/overflow/overflow-update-transform-expected.png
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/platform/mac/fast/replaced/selection-rect-transform-expected.png
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/box/box-inline-resize-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/clip/clipped-relative-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/image/canvas-composite-repaint-by-all-imagesource-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/list-marker-2-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/position/positioned-list-offset-change-repaint-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/selection/selected-replaced-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/platform/win/fast/overflow/overflow-update-transform-expected.png
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/platform/win/fast/replaced/selection-rect-transform-expected.png
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/box/box-inline-resize-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/clip/clipped-relative-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/image/canvas-composite-repaint-by-all-imagesource-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/list-marker-2-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/position/positioned-list-offset-change-repaint-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/selection/selected-replaced-expected.txt
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/blink/renderer/core/layout/layout_embedded_content.cc
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/blink/renderer/core/layout/layout_embedded_content.h
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/blink/renderer/core/layout/layout_embedded_object.cc
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/blink/renderer/core/layout/layout_embedded_object.h
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/blink/renderer/core/paint/embedded_content_painter.cc
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/blink/renderer/core/paint/embedded_content_painter.h
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/blink/renderer/core/paint/embedded_object_painter.cc
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/blink/renderer/core/paint/html_canvas_painter.cc
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/blink/renderer/core/paint/object_paint_invalidator_test.cc
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/blink/renderer/core/paint/replaced_painter.cc
[modify] https://crrev.com/2a4ffbeb37b55ba98443d1d34ce0bc629f0f8726/third_party/blink/renderer/core/paint/svg_root_painter.cc

Project Member

Comment 14 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/112f71fce5ea31c1a4a92a2161a2d3ba77b20b35

commit 112f71fce5ea31c1a4a92a2161a2d3ba77b20b35
Author: Tien-Ren Chen <trchen@chromium.org>
Date: Fri Jul 27 14:51:51 2018

Reland: [Blink] Unify replaced element clipping

Prior to this CL each replaced element type implemented its own clipping.
This CL refactors it so that a clip node will be applied in the common
path, ReplacedPainter::Paint(), so the specialized
XyzPainter::PaintReplaced() won't need to apply their own clips.

BUG= 730284 

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I4d30fa3a80dfe54d4729b17d1084cd685a8fb712
Reviewed-on: https://chromium-review.googlesource.com/1150866
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578640}
[modify] https://crrev.com/112f71fce5ea31c1a4a92a2161a2d3ba77b20b35/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/canvas-resize-expected.txt
[modify] https://crrev.com/112f71fce5ea31c1a4a92a2161a2d3ba77b20b35/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/canvas-resize-no-full-invalidation-expected.txt
[modify] https://crrev.com/112f71fce5ea31c1a4a92a2161a2d3ba77b20b35/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/iframe-display-block-to-display-none-expected.txt
[modify] https://crrev.com/112f71fce5ea31c1a4a92a2161a2d3ba77b20b35/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/iframe-display-none-to-display-block-expected.txt
[modify] https://crrev.com/112f71fce5ea31c1a4a92a2161a2d3ba77b20b35/third_party/WebKit/LayoutTests/paint/invalidation/canvas-resize-expected.txt
[modify] https://crrev.com/112f71fce5ea31c1a4a92a2161a2d3ba77b20b35/third_party/WebKit/LayoutTests/paint/invalidation/canvas-resize-no-full-invalidation-expected.txt
[delete] https://crrev.com/2bf1cdb05f02bc83ed3624eaa7caeaf9942bff6f/third_party/WebKit/LayoutTests/platform/android/fast/replaced/selection-rect-transform-expected.png
[delete] https://crrev.com/2bf1cdb05f02bc83ed3624eaa7caeaf9942bff6f/third_party/WebKit/LayoutTests/platform/android/paint/invalidation/selection/selected-replaced-expected.txt
[modify] https://crrev.com/112f71fce5ea31c1a4a92a2161a2d3ba77b20b35/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/image/canvas-composite-repaint-by-all-imagesource-expected.txt
[modify] https://crrev.com/112f71fce5ea31c1a4a92a2161a2d3ba77b20b35/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/image/canvas-composite-repaint-by-all-imagesource-expected.txt
[modify] https://crrev.com/112f71fce5ea31c1a4a92a2161a2d3ba77b20b35/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/image/canvas-composite-repaint-by-all-imagesource-expected.txt
[modify] https://crrev.com/112f71fce5ea31c1a4a92a2161a2d3ba77b20b35/third_party/blink/renderer/core/layout/layout_embedded_content.cc
[modify] https://crrev.com/112f71fce5ea31c1a4a92a2161a2d3ba77b20b35/third_party/blink/renderer/core/layout/layout_embedded_content.h
[modify] https://crrev.com/112f71fce5ea31c1a4a92a2161a2d3ba77b20b35/third_party/blink/renderer/core/layout/layout_embedded_object.cc
[modify] https://crrev.com/112f71fce5ea31c1a4a92a2161a2d3ba77b20b35/third_party/blink/renderer/core/layout/layout_embedded_object.h
[modify] https://crrev.com/112f71fce5ea31c1a4a92a2161a2d3ba77b20b35/third_party/blink/renderer/core/paint/embedded_content_painter.cc
[modify] https://crrev.com/112f71fce5ea31c1a4a92a2161a2d3ba77b20b35/third_party/blink/renderer/core/paint/embedded_content_painter.h
[modify] https://crrev.com/112f71fce5ea31c1a4a92a2161a2d3ba77b20b35/third_party/blink/renderer/core/paint/embedded_object_painter.cc
[modify] https://crrev.com/112f71fce5ea31c1a4a92a2161a2d3ba77b20b35/third_party/blink/renderer/core/paint/html_canvas_painter.cc
[modify] https://crrev.com/112f71fce5ea31c1a4a92a2161a2d3ba77b20b35/third_party/blink/renderer/core/paint/replaced_painter.cc
[modify] https://crrev.com/112f71fce5ea31c1a4a92a2161a2d3ba77b20b35/third_party/blink/renderer/core/paint/svg_root_painter.cc

Status: Fixed (was: Assigned)

Sign in to add a comment