New issue
Advanced search Search tips

Issue 730254 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug

Blocking:
issue 730253
issue 730429



Sign in to add a comment

Null-dereference READ in v8::internal::compiler::Node::opcode

Project Member Reported by ClusterFuzz, Jun 6 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5733551747366912

Fuzzer: mbarbella_js_mutation
Job Type: linux_asan_d8
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  v8::internal::compiler::Node::opcode
  v8::internal::compiler::StateValuesAccess::size
  v8::internal::compiler::InstructionSelector::GetFrameStateDescriptor
  
Sanitizer: address (ASAN)

Regressed: V8: 45719:45720

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5733551747366912


Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: bmeu...@chromium.org mlippautz@chromium.org jarin@chromium.org rmcilroy@chromium.org
Owner: mythria@chromium.org
Status: Assigned (was: Untriaged)
Bisects to c360c6a1d01135298aa9b6508f8367db322ce107.
Blocking: 730429
Blocking: 730253
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/66218e4efa7ec0272bb707f21cc793da65954308

commit 66218e4efa7ec0272bb707f21cc793da65954308
Author: Mythri <mythria@chromium.org>
Date: Wed Jun 07 12:07:24 2017

[Turbofan] Fix to not leak holes on any edges.

This cl: https://chromium-review.googlesource.com/509613 changed
CheckNotTaggedHole to not produce any value output. This would mean that
in some cases, we could leak hole on value edges. This violates the
assumption that we cannot see a hole on several operators. Fixing this
back to the original state.

Bug:  chromium:730254 
Change-Id: I3512930e88dbe15e9d9b4b0d276868f354cc2ae2
Reviewed-on: https://chromium-review.googlesource.com/527033
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#45757}
[modify] https://crrev.com/66218e4efa7ec0272bb707f21cc793da65954308/src/compiler/js-native-context-specialization.cc
[modify] https://crrev.com/66218e4efa7ec0272bb707f21cc793da65954308/src/compiler/opcodes.h
[modify] https://crrev.com/66218e4efa7ec0272bb707f21cc793da65954308/src/compiler/simplified-operator.cc
[modify] https://crrev.com/66218e4efa7ec0272bb707f21cc793da65954308/src/compiler/typer.cc
[modify] https://crrev.com/66218e4efa7ec0272bb707f21cc793da65954308/src/compiler/verifier.cc
[add] https://crrev.com/66218e4efa7ec0272bb707f21cc793da65954308/test/mjsunit/regress/regress-730254.js

Status: Fixed (was: Assigned)
Project Member

Comment 6 by ClusterFuzz, Jun 8 2017

ClusterFuzz has detected this issue as fixed in range 45756:45757.

Detailed report: https://clusterfuzz.com/testcase?key=5733551747366912

Fuzzer: mbarbella_js_mutation
Job Type: linux_asan_d8
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  v8::internal::compiler::Node::opcode
  v8::internal::compiler::StateValuesAccess::size
  v8::internal::compiler::InstructionSelector::GetFrameStateDescriptor
  
Sanitizer: address (ASAN)

Regressed: V8: 45719:45720
Fixed: V8: 45756:45757

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5733551747366912


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Issue 730622 has been merged into this issue.

Sign in to add a comment