MD Settings: Search engine list is unordered and difficult to search (ergo edit)
Reported by
abwic...@gmail.com,
Jun 6 2017
|
||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.86 Safari/537.36 Steps to reproduce the problem: 1. Enable material design settings, and add/have many 'other' (non-default) search engines (around 100 or more) 2. Go to search engines settings page: chrome://settings/searchEngines 3. Search for an engine you might want to edit with Find dialog (Ctrl/Cmd+F) 4. Alternatively, scroll down to where the engine should be 5. Throw a fit because nothing works like it should What is the expected behavior? Step (3) should find the string entered like any normal web page. Step (4) expects that the search engines are sorted in some human useable format, e.g. lexicographical. What went wrong? In step (3), it is often the case that the Find dialog does not find the string you searched for, even when the string exists as part of one or more of the search engines. See Figure 1. In the main MD settings issue linked below, I was told: > The list of search engines is implemented as a "smart" list where not all of the rows are rendered all the time. Only rows that are showing are rendered, which is good for performance, but bad for ctrl+F. This could maybe be addressed by a dedicated search field for filtering the search engines list (similar to the passwords list). This could be fine if not for problems in step (4). In step (4), the order of the search engines seems roughly correlated with creation/modification time, not lexicographically (see Figure 2). This is useless when you have a decent number of engines, since you cannot just scroll down to the right spot by eye. It should be sorted lexicographically to aid in human usability, like it used to be in the legacy settings (see Figure 3). Before MD settings, neither of these issues existed. Did this work before? Yes Any version with legacy settings or with MD settings disabled Chrome version: 59.0.3071.86 Channel: stable OS Version: OS X 10.12.5 Flash Version: This is following up comments made at https://bugs.chromium.org/p/chromium/issues/detail?id=425627#c159
,
Jun 7 2017
,
Jun 8 2017
We should probably add a dedicated search box for search engines, similar to how one can search passwords or cookies.
,
Jun 8 2017
FYI, I am investigating why the list is not ordered alphabetically.
,
Jun 8 2017
,
Jun 8 2017
So, the data coming from C++ is the same in both Options and MD Settings. The old Options code was sorting the search engines in JS at https://cs.chromium.org/chromium/src/chrome/browser/resources/options/search_engine_manager.js?q=search_engine_manager.js&sq=package:chromium&dr&l=83-89. This logic was not ported to the MD Settings page. Will address.
,
Jun 8 2017
FYI the fix is at https://codereview.chromium.org/2930953002. I'll add some tests before sending for review. I will also request a merge to M60 after this lands.
,
Jun 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cdceb9213784adf9e87f5a68212b714dab455b4a commit cdceb9213784adf9e87f5a68212b714dab455b4a Author: dpapad <dpapad@chromium.org> Date: Thu Jun 08 22:38:58 2017 MD Settings: Sort "other" search engines alphabetically. This matches the behavior of old Options. BUG= 730248 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2930953002 Cr-Commit-Position: refs/heads/master@{#478107} [modify] https://crrev.com/cdceb9213784adf9e87f5a68212b714dab455b4a/chrome/browser/resources/settings/search_engines_page/search_engines_page.js [modify] https://crrev.com/cdceb9213784adf9e87f5a68212b714dab455b4a/chrome/test/data/webui/settings/search_engines_page_test.js
,
Jun 9 2017
The ordering of search engines has been fixed I am marking this bug as Fixed so that I can request a merge to M60. The incompatibility of a virtual list with Ctrl+F is still a problem, and can potentially be addressed by a dedicated search box. Let's track this separately.
,
Jun 9 2017
FYI, for anyone interested, filed https://bugs.chromium.org/p/chromium/issues/detail?id=731467 for tracking the effort to add a dedicated search box.
,
Jun 9 2017
Thank you very much. (Disregard the deleted comment)
,
Jun 9 2017
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 14 2017
@bustamante: Ping, can you take a look please?
,
Jun 15 2017
@bustamante: Friendly ping. Can we merge this to M60?
,
Jun 16 2017
Since M60 has already branched and our bar for merges is fairly high now, we're only considering absolutely critical changes or bug regressions. Can you please confirm if this can wait until M61? I'm rejecting the merge right now, but feel free to re-request it if it's critical.
,
Aug 3 2017
What's the latest on when this fix will make it in?
,
Aug 3 2017
#17, the above fix landed in 61.0.3125.0, not merged to v60, see [1]. v61 will be in Stable channel on September, 5 [1]: https://storage.googleapis.com/chromium-find-releases-static/cdc.html#cdceb9213784adf9e87f5a68212b714dab455b4a [2]: https://www.chromestatus.com/features/schedule |
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by patricia...@chromium.org
, Jun 7 2017Labels: Proj-MaterialDesign-WebUI OS-Chrome OS-Linux OS-Windows
Status: Untriaged (was: Unconfirmed)
Summary: MD Settings: Search engine list is unordered and difficult to search (ergo edit) (was: Material design search engine settings are unordered and difficult to search (ergo edit))