New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 730238 link

Starred by 2 users
Status: Fixed
Owner:
█ kateso...@chromium.org
Last visit > 30 days ago
Closed: Oct 2017
Cc:
█ cweakliam@google.com
st...@chromium.org
wittman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 730241



Sign in to add a comment

[Predator] Rename findit* to predator*.

Project Member Reported by kateso...@chromium.org, Jun 6 2017 
[Predator] Rename findit* to predator*.

We should remove findit* in the code. After Predator got separated from Findit, we should also rename some files:

findit.py -> predator_app.py
Findit -> PredatorApp

findit_for_chromecrash.py -> predator_for_chromecrash.py
FinditForChromeCrash -> PredatorForChromeCrash

findit_for_clusterfuzz.py -> predator_for_clusterfuzz.py
FinditForClusterfuzz -> PredatorForClusterfuzz

In crash_pipeline.py:
FinditForClientID -> PredatorForClientID

Comment 1 by kateso...@chromium.org, Jun 6 2017

Blocking: 730241
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/11867c20d0a020f5a7882ad3b82aee5ae4f1e299

commit 11867c20d0a020f5a7882ad3b82aee5ae4f1e299
Author: Cathal Weakliam <cweakliam@google.com>
Date: Wed Jun 07 21:59:33 2017

Rename 'findit' to 'predator' throughout.

Also renames the ``Findit`` class in 'common' to ``PredatorApp``.

R=katesonia@google.com

Bug:  730238 
Change-Id: I26bcf03d90707c5eb862fcdc1e260828ad9ce62b
Reviewed-on: https://chromium-review.googlesource.com/526347
Reviewed-by: Sharu Jiang <katesonia@chromium.org>
Commit-Queue: Cathal Weakliam <cweakliam@google.com>

[rename] https://crrev.com/11867c20d0a020f5a7882ad3b82aee5ae4f1e299/appengine/predator/common/test/predator_for_clusterfuzz_test.py
[modify] https://crrev.com/11867c20d0a020f5a7882ad3b82aee5ae4f1e299/appengine/predator/scripts/run_predator.py
[modify] https://crrev.com/11867c20d0a020f5a7882ad3b82aee5ae4f1e299/appengine/predator/scripts/delta_test/delta_test.py
[modify] https://crrev.com/11867c20d0a020f5a7882ad3b82aee5ae4f1e299/appengine/predator/analysis/culprit.py
[modify] https://crrev.com/11867c20d0a020f5a7882ad3b82aee5ae4f1e299/appengine/predator/common/model/test/crash_analysis_test.py
[modify] https://crrev.com/11867c20d0a020f5a7882ad3b82aee5ae4f1e299/appengine/predator/frontend/handlers/crash_handler.py
[modify] https://crrev.com/11867c20d0a020f5a7882ad3b82aee5ae4f1e299/appengine/predator/common/model/test/clusterfuzz_analysis_test.py
[rename] https://crrev.com/11867c20d0a020f5a7882ad3b82aee5ae4f1e299/appengine/predator/common/test/predator_for_chromecrash_test.py
[modify] https://crrev.com/11867c20d0a020f5a7882ad3b82aee5ae4f1e299/appengine/predator/common/crash_pipeline.py
[rename] https://crrev.com/11867c20d0a020f5a7882ad3b82aee5ae4f1e299/appengine/predator/common/predator_for_clusterfuzz.py
[modify] https://crrev.com/11867c20d0a020f5a7882ad3b82aee5ae4f1e299/appengine/predator/common/appengine_testcase.py
[modify] https://crrev.com/11867c20d0a020f5a7882ad3b82aee5ae4f1e299/appengine/predator/frontend/handlers/test/crash_handler_test.py
[modify] https://crrev.com/11867c20d0a020f5a7882ad3b82aee5ae4f1e299/appengine/predator/common/model/crash_config.py
[modify] https://crrev.com/11867c20d0a020f5a7882ad3b82aee5ae4f1e299/appengine/predator/common/test/crash_pipeline_test.py
[modify] https://crrev.com/11867c20d0a020f5a7882ad3b82aee5ae4f1e299/appengine/predator/scripts/run-predator.py
[rename] https://crrev.com/11867c20d0a020f5a7882ad3b82aee5ae4f1e299/appengine/predator/common/predator_app.py
[modify] https://crrev.com/11867c20d0a020f5a7882ad3b82aee5ae4f1e299/appengine/predator/common/model/crash_analysis.py
[rename] https://crrev.com/11867c20d0a020f5a7882ad3b82aee5ae4f1e299/appengine/predator/common/predator_for_chromecrash.py
[modify] https://crrev.com/11867c20d0a020f5a7882ad3b82aee5ae4f1e299/appengine/predator/common/model/test/chrome_crash_analysis_test.py
[modify] https://crrev.com/11867c20d0a020f5a7882ad3b82aee5ae4f1e299/appengine/predator/frontend/handlers/crash_config.py
[rename] https://crrev.com/11867c20d0a020f5a7882ad3b82aee5ae4f1e299/appengine/predator/common/test/predator_app_test.py
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 8 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/10f8637e68e7474ccdc41e3d117697b515a21b28

commit 10f8637e68e7474ccdc41e3d117697b515a21b28
Author: Katie Thomas <katthomas@google.com>
Date: Thu Jun 08 17:54:46 2017

Comment 4 by mbarbe...@chromium.org, Oct 11 2017

Owner: kateso...@chromium.org
Status: Fixed (was: Assigned)
This is done, right?

Comment 5 by kateso...@chromium.org, Oct 11 2017 

Yes, it's done.
►

Sign in to add a comment