New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 730233 link

Starred by 1 user
Status: Fixed
Owner:
█ romax@chromium.org
Last visit > 30 days ago
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Adding missing image/CSS detection in FrameSerializer.

Project Member Reported by romax@chromium.org, Jun 6 2017 
In order to get some metrics to evaluation how the offline page is doing in the field, we need to add some logic to record the number of loaded/missing images/CSS files at the time of serialization (generating MHTML).
dd: go/offline-pages-problems-metric
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df3595bb1db14d038879823a24b60e9e284c861c

commit df3595bb1db14d038879823a24b60e9e284c861c
Author: romax <romax@chromium.org>
Date: Tue Jun 13 22:29:42 2017

[Offline Pages] Adding missing image/CSS detection in FrameSerializer.

Adding interfaces of problem detectors which are going to be used for UMA
collecting for offline pages.

See go/offline-pages-problems-metric for more information.

BUG= 730233 

Review-Url: https://codereview.chromium.org/2886943003
Cr-Commit-Position: refs/heads/master@{#479180}

[modify] https://crrev.com/df3595bb1db14d038879823a24b60e9e284c861c/content/browser/download/mhtml_generation_manager.cc
[modify] https://crrev.com/df3595bb1db14d038879823a24b60e9e284c861c/content/common/frame_messages.h
[modify] https://crrev.com/df3595bb1db14d038879823a24b60e9e284c861c/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/df3595bb1db14d038879823a24b60e9e284c861c/third_party/WebKit/Source/core/frame/FrameSerializer.cpp
[modify] https://crrev.com/df3595bb1db14d038879823a24b60e9e284c861c/third_party/WebKit/Source/core/frame/FrameSerializer.h
[modify] https://crrev.com/df3595bb1db14d038879823a24b60e9e284c861c/third_party/WebKit/Source/platform/Histogram.cpp
[modify] https://crrev.com/df3595bb1db14d038879823a24b60e9e284c861c/third_party/WebKit/Source/platform/Histogram.h
[modify] https://crrev.com/df3595bb1db14d038879823a24b60e9e284c861c/third_party/WebKit/Source/web/WebFrameSerializer.cpp
[modify] https://crrev.com/df3595bb1db14d038879823a24b60e9e284c861c/third_party/WebKit/Source/web/tests/WebFrameSerializerSanitizationTest.cpp
[modify] https://crrev.com/df3595bb1db14d038879823a24b60e9e284c861c/third_party/WebKit/public/web/WebFrameSerializer.h
[modify] https://crrev.com/df3595bb1db14d038879823a24b60e9e284c861c/tools/metrics/histograms/histograms.xml

Comment 2 by romax@chromium.org, Jun 13 2017

Status: Fixed (was: Started)
►

Sign in to add a comment