New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 730232 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: ----
Type: ----


Sign in to add a comment

Improve touch interactions on Files app

Project Member Reported by weifangsun@chromium.org, Jun 6 2017

Issue description

As we move towards convertible/detachable etc. devices, touch is becoming more common on Chrome OS. We should update the touch interactions on Files app be more intuitive to users.

UX guidelines: https://docs.google.com/presentation/d/1gjgqcHR0cL2IDiuVE42rMKYwGhUn43GP4yjpg3V63Pc/edit#slide=id.g2298fac1bf_0_0

 
Blockedon: 493514
Found a related bug at  crbug.com/493514 
This has two parts. 

1. Updating the touch interactions. I started an email thread about this so we can make sure we've weighed in all options before we settle on the final touch interactions. 

2. Increase discoverability of the context menu in touch mode.  
Interaction spec: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZSLl8DO5WVeQ/files/MCHPDvtymHH2zY0CGDl2ok5k

Comment 3 by fukino@chromium.org, Jun 28 2017

Cc: yamaguchi@chromium.org satorux@chromium.org fukino@chromium.org
Labels: M-61
weifangsun@, mcirimele@, should we implement both features in comment #2 for M61?

Comment 4 by fukino@chromium.org, Jun 28 2017

Regarding the mock in #2, I have following questions.

Files app already uses 3-dot icon. Using the same icon for opening context menu might be confusing.
Maybe we should change the existing icon? (for instance, replace the existing 3-dot icon with gear icon?)

Should we show the new 3-dot icon when a file is selected but not in check-select mode?
If a file is selected without clicking the circle icon, the toolbar will stay blue (not white). Should we show the 3-dot icon to open context menu in this case?
Great questions! 

We decided to re-use the three dot (more) menu for context menu in selected state because it is used in this way in other first party apps (like Drive) on Android. I think it will be okay to have the contents of the menu depend on the state the user is in. 

I call the "selected but not in check-select mode" focus state. The focused state is when the row highlight is light blue and like you said the toolbar is blue. In this case the three dot menu should open the regular overflow menu. 
Can I request image resources for the new context menu button?
Currently we only have ones for a white one.
https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/images/files/ui/menu_white.png
https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/images/files/ui/2x/menu_white.png

Since the backgound in the selection mode is white, I think we'd need gray ones like this delete icon.
https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/images/files/ui/delete.png
Cc: sgabr...@chromium.org
+sgabriel@ - Would you be able to provide the requested asset for Files app? This is a 3-dot menu icon like the one in the current menu bar which is grey rather than white for the action bar menu.
Can we also have these assets?
- tooltip/accessibility label text for the button (e.g. "more actions")
- ripple color/transparency of the button (if we want this effect)

Also, should we show "paste" command (=paste items to the current folder) somewhere in the menu, in either of the modes?
Paste is not an action to the selected file, but it currently don't appear in neither of the two modes.
Blockedon: 740842
Blockedon: 446606
Adding  crbug.com/446606  to this bug from an old touch improvements initiative. Not sure if this bug is still applicable given the current state of Files app (no gear icon) and our current proposed touch enhancements.
Blocking: 741183
Blockedon: 695699 526877
526877 & 695699 are not truly blocking, but might be good to review these bugs as we look to improve touch interactions.
Blockedon: 742779
Blockedon: 742784
Blockedon: 742865
Is there anything outstanding on this bug? Looking at canary on Kevin 62.0.3165.0 (9774.0.0) we have "More..." as the tooltip and "paste" in the context menu which is the correct behavior. 

I see a gray three dot icon but can't tell if it's exactly the same color as the other buttons, do you still need an asset for it?
I don't need new assets anymore, unless we see problems with the current ones.
I made the new icons, using the same colors as other icons like the trash icons.
We also applied the ripple effect consistent with other parts of the toolbar.
Blockedon: 748504
Thank you so much Yamaguchi-san, that's great work!

Comment 20 by willg...@gmail.com, Jul 29 2017

What about 'Select all'? That is still conspicuously absent for touch.

 crbug.com/572801  
willg76x@ - Thanks for your feedback! We agree that it would be great to add this action to the Context Menu. We have this feature in our backlog and are working to prioritize including it.
Blockedon: 753723
Blockedon: 754272
Blockedon: 754283
Blockedon: 754290
Blockedon: 754301
Blockedon: 755111
Blockedon: 755709
Blockedon: 755705
Blockedon: 755703
Blockedon: 755695
Blockedon: 755757
Blockedon: 755760
Blockedon: 755762
Blockedon: 755774
Blockedon: 753835
Blockedon: 755785
Blockedon: 755792
Blockedon: 755937
Blockedon: 756297
Blockedon: 742689
Blockedon: 756511
Blockedon: 756839
Blockedon: 747845
Blockedon: 757716
Blockedon: 760058
Blockedon: 760400
Blockedon: 760552
Labels: M-62
Blockedon: -493514
Blockedon: -755703
Blockedon: -755762
Blockedon: -755785
Blockedon: -742689
Blockedon: -755111
Blockedon: -756297
Blockedon: -755792
Blockedon: -755760
Blockedon: -760552
Blockedon: -754301
Blockedon: -747845
Status: Fixed (was: Assigned)

Sign in to add a comment