New issue
Advanced search Search tips

Issue 730199 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

IDB memory metrics have bad ranges

Project Member Reported by dmu...@chromium.org, Jun 6 2017

Issue description


The following metrics:
WebCore.IndexedDB.Transaction.*.SizeOnCommit
WebCore.IndexedDB.PutValueSize

Start at 1MB, and we need better accuracy in the 1KB-1MB range.
 

Comment 2 by dmu...@chromium.org, Jun 12 2017

Labels: Merge-Request-60
Status: Fixed (was: Assigned)
requesting merge to fix metrics in m60
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 12 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-60 Merge-Rejected-60
We're pretty late into M60 and cracking down on merges for this milestone, I'd prefer to wait until M61.  If you feel strongly this should get merged, feel free to add back the Merge-Request-60 label and we'll re-review.

Comment 5 by dmu...@chromium.org, Jun 13 2017

Labels: -Merge-Rejected-60 Merge-Request-60
These metrics are influencing prioritization decisions for the OWP Storage team and we'd really like them in m60 if possible. Requesting again.

They are also really small changes.
Project Member

Comment 6 by sheriffbot@chromium.org, Jun 13 2017

Labels: -Merge-Request-60 Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-60 Merge-Approved-60
Ok SGTM, approving for merge into M60 build 3112.
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 21 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a8321f3ec2373a9a71048941c0905b90d921fda

commit 4a8321f3ec2373a9a71048941c0905b90d921fda
Author: Daniel Murphy <dmurph@chromium.org>
Date: Wed Jun 21 22:12:00 2017

[IndexedDB] Fixed metric size ranges

TBR=dmurph@chromium.org

(cherry picked from commit 772bd18650977683ae4cf6e8087c219079d53a4c)

R: mpearson@chromium.org
Bug:  730199 
Change-Id: I40e4c84432536931daa6416ee027db739dad9968
Reviewed-on: https://chromium-review.googlesource.com/526302
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#478455}
Reviewed-on: https://chromium-review.googlesource.com/544181
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/branch-heads/3112@{#428}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
[modify] https://crrev.com/4a8321f3ec2373a9a71048941c0905b90d921fda/content/browser/indexed_db/indexed_db_transaction.cc
[modify] https://crrev.com/4a8321f3ec2373a9a71048941c0905b90d921fda/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp
[modify] https://crrev.com/4a8321f3ec2373a9a71048941c0905b90d921fda/tools/metrics/histograms/histograms.xml

Sign in to add a comment