IDB memory metrics have bad ranges |
||||||||
Issue descriptionThe following metrics: WebCore.IndexedDB.Transaction.*.SizeOnCommit WebCore.IndexedDB.PutValueSize Start at 1MB, and we need better accuracy in the 1KB-1MB range.
,
Jun 12 2017
requesting merge to fix metrics in m60
,
Jun 12 2017
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 13 2017
We're pretty late into M60 and cracking down on merges for this milestone, I'd prefer to wait until M61. If you feel strongly this should get merged, feel free to add back the Merge-Request-60 label and we'll re-review.
,
Jun 13 2017
These metrics are influencing prioritization decisions for the OWP Storage team and we'd really like them in m60 if possible. Requesting again. They are also really small changes.
,
Jun 13 2017
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 21 2017
Ok SGTM, approving for merge into M60 build 3112.
,
Jun 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a8321f3ec2373a9a71048941c0905b90d921fda commit 4a8321f3ec2373a9a71048941c0905b90d921fda Author: Daniel Murphy <dmurph@chromium.org> Date: Wed Jun 21 22:12:00 2017 [IndexedDB] Fixed metric size ranges TBR=dmurph@chromium.org (cherry picked from commit 772bd18650977683ae4cf6e8087c219079d53a4c) R: mpearson@chromium.org Bug: 730199 Change-Id: I40e4c84432536931daa6416ee027db739dad9968 Reviewed-on: https://chromium-review.googlesource.com/526302 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#478455} Reviewed-on: https://chromium-review.googlesource.com/544181 Reviewed-by: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#428} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/4a8321f3ec2373a9a71048941c0905b90d921fda/content/browser/indexed_db/indexed_db_transaction.cc [modify] https://crrev.com/4a8321f3ec2373a9a71048941c0905b90d921fda/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp [modify] https://crrev.com/4a8321f3ec2373a9a71048941c0905b90d921fda/tools/metrics/histograms/histograms.xml |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Jun 9 2017