New issue
Advanced search Search tips

Issue 730197 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Ignore the rest of the scroll sequence if GSB is ignored.

Project Member Reported by sahel@chromium.org, Jun 6 2017

Issue description

This is for avoiding cases that the GSB event gets dropped but GSU and GSE events are sent to the main thread.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dad0c1edb6da7ce815e5019c87cd1f474b3d055c

commit dad0c1edb6da7ce815e5019c87cd1f474b3d055c
Author: sahel <sahel@chromium.org>
Date: Thu Jun 15 22:32:11 2017

Ignore the rest of the scroll sequence if GSB is ignored.

This cl also modifies ContentViewCoreScrollingTests to initialize the
compositor's outer viewport before starting the test. This change is
required, as without properly initializing the compositor's outer
viewport, GSB events and the rest of the scroll sequences will get
ignored.

BUG= 730197 
TEST=AnimateInput/InputHandlerProxyTest.GestureScrollIgnored/*
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2924953002
Cr-Commit-Position: refs/heads/master@{#479871}

[modify] https://crrev.com/dad0c1edb6da7ce815e5019c87cd1f474b3d055c/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/dad0c1edb6da7ce815e5019c87cd1f474b3d055c/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
[modify] https://crrev.com/dad0c1edb6da7ce815e5019c87cd1f474b3d055c/content/public/android/javatests/src/org/chromium/content/browser/ContentViewScrollingTest.java
[modify] https://crrev.com/dad0c1edb6da7ce815e5019c87cd1f474b3d055c/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/dad0c1edb6da7ce815e5019c87cd1f474b3d055c/ui/events/blink/input_handler_proxy.h
[modify] https://crrev.com/dad0c1edb6da7ce815e5019c87cd1f474b3d055c/ui/events/blink/input_handler_proxy_unittest.cc

Comment 2 by sahel@chromium.org, Jun 19 2017

Status: Fixed (was: Assigned)

Sign in to add a comment