High Sierra: Window traffic light control is mis-placed |
||||||
Issue descriptionChrome Version: 61.0.3122.0 OS: macOS 10.13 17A264c What steps will reproduce the problem? (1) Open Chrome (2) Look at the window traffic lights (3) Traffic lights are mis-aligned (should be center-aligned in the frame) (4) Put Chrome in the background (5) Traffic lights disappear altogether What is the expected result? Step 3 should have traffic lights aligned with the vertical center of the tabstrip. And in step 5, the traffic lights should be visible when Chrome is backgrounded. What happens instead? Please use labels and text to provide additional information. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Jun 8 2017
Resizing by the corners fixed it for me too. Issue 605219 could be at play here. "Reverting" r433658 could fix it (possibly Issue 730679 as well), but it will bring back the autolayout woes. Maybe there's something we can do that addresses the fullsize contentview thing in Issue 605219 without opting in the browser window to autolayout.
,
Jun 8 2017
Are you saying the root cause of the problem is us opting into autolayout because of r433658? As far as I know this change is not enabled because we haven't fixed all the autolayout problems (e.g. if I run Canary from the command line I still get "NSWindow warning: adding an unknown subview: <FullSizeContentView: 0x7fb7cfceea80>. Break on NSLog to debug"). Or am I confused about what you're saying?
,
Jun 9 2017
I think the root cause is us replacing [[NSWindow contentView] superview] with our own NSView. That's what triggers the "unknown subview" warning. Issue 605219 implements a solution that avoids us having to replace [contentView superview] to draw the tab strip. However, in its current form, it causes the browser window to opt in to autolayout as a side-effect.
,
Jun 9 2017
,
Jun 13 2017
,
Jun 19 2017
Probably same root cause: Stoplights are showing up on the left in RTL, fixed by full-screen or dragging by the corners (but it has to be more than just a little).
,
Jun 20 2017
Changing ShouldUseFullSizeContentView() to return true fixes the stoplight position problem.
,
Jun 30 2017
,
Jul 6 2017
,
Jul 11 2017
A friendly reminder that M61 branch is coming soon on 07/20! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix ASAP to trunk. This way we branch M61 from a high quality trunk. Thank you.
,
Jul 12 2017
,
Sep 27 2017
Issue 765926 has been merged into this issue. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by rsesek@chromium.org
, Jun 6 2017