GaiaScreenHandler::MaybePreloadAuthExtension is called in user session |
||||
Issue descriptiontot Chrome 61.0.3123.0 Repro steps: (1) connect to a captive portal wifi (2) click notification to open the portal dialog (3) enter credentials, which makes dialog auto-closed Will see GaiaScreenHandler::MaybePreloadAuthExtension get called in user session. This will cause an unnecessary network_portal_detector initialized (which doesn't create notification controller). [20859:20859:0606/131154.307877:ERROR:device_event_log_impl.cc(156)] [13:11:54.307] Network: network_state_handler.cc:1385 Default network in unexpected state: Ethernet (/service/1582)State: idle [20859:21063:0606/131155.331455:ERROR:connection_factory_impl.cc(386)] Failed to connect to MCS endpoint with error -106 [20859:20859:0606/131246.726844:ERROR:device_event_log_impl.cc(156)] [13:12:46.725] Network: network_portal_detector_impl.cc:465 Portal detection timeout: name=panda-5G id=b7e06b9a-23d4-4a0a-898c-037cac02c997 [20859:20859:0606/131250.167090:ERROR:device_event_log_impl.cc(156)] [13:12:50.166] Network: network_portal_detector_impl.cc:465 Portal detection timeout: name=panda-5G id=b7e06b9a-23d4-4a0a-898c-037cac02c997 [20859:20859:0606/131259.312674:ERROR:device_event_log_impl.cc(156)] [13:12:59.312] Network: network_portal_detector_impl.cc:465 Portal detection timeout: name=panda-5G id=b7e06b9a-23d4-4a0a-898c-037cac02c997 [20859:20859:0606/131259.354300:ERROR:device_event_log_impl.cc(156)] [13:12:59.354] Network: network_state_handler.cc:1385 Default network in unexpected state: panda-5G (/service/992)State: idle [20859:21063:0606/131306.888899:ERROR:connection_factory_impl.cc(386)] Failed to connect to MCS endpoint with error -21 [20859:20859:0606/131414.278171:ERROR:gaia_screen_handler.cc(244)] MaybePreloadAuthExtension [21076:21076:0606/131414.353891:ERROR:gles2_cmd_decoder.cc(17729)] [.DisplayCompositor-0x3256a000]GL ERROR :GL_INVALID_OPERATION : glCreateAndConsumeTextureCHROMIUM: invalid mailbox name [21076:21076:0606/131414.354119:ERROR:gles2_cmd_decoder.cc(9734)] [.DisplayCompositor-0x3256a000]RENDER WARNING: texture bound to texture unit 0 is not renderable. It maybe non-power-of-2 and have incompatible texture filtering. [21076:21076:0606/131414.377193:ERROR:gles2_cmd_decoder.cc(9734)] [.DisplayCompositor-0x3256a000]RENDER WARNING: texture bound to texture unit 0 is not renderable. It maybe non-power-of-2 and have incompatible texture filtering. [21076:21076:0606/131414.381624:ERROR:gles2_cmd_decoder.cc(9734)] [.DisplayCompositor-0x3256a000]RENDER WARNING: texture bound to texture unit 0 is not renderable. It maybe non-power-of-2 and have incompatible texture filtering. [21076:21076:0606/131414.418815:ERROR:gles2_cmd_decoder.cc(9734)] [.DisplayCompositor-0x3256a000]RENDER WARNING: texture bound to texture unit 0 is not renderable. It maybe non-power-of-2 and have incompatible texture filtering. [21076:21076:0606/131414.447581:ERROR:gles2_cmd_decoder.cc(9734)] [.DisplayCompositor-0x3256a000]RENDER WARNING: texture bound to texture unit 0 is not renderable. It maybe non-power-of-2 and have incompatible texture filtering. [20859:21063:0606/131414.470013:ERROR:service_manager.cc(142)] Connection InterfaceProviderSpec prevented service: content_plugin from binding interface: memory_instrumentation::mojom::Coordinator exposed by: content_browser [21076:21076:0606/131414.477037:ERROR:gles2_cmd_decoder.cc(9734)] [.DisplayCompositor-0x3256a000]RENDER WARNING: texture bound to texture unit 0 is not renderable. It maybe non-power-of-2 and have incompatible texture filtering. [21076:21076:0606/131414.505263:ERROR:gles2_cmd_decoder.cc(9734)] [.DisplayCompositor-0x3256a000]RENDER WARNING: texture bound to texture unit 0 is not renderable. It maybe non-power-of-2 and have incompatible texture filtering. [20859:20859:0606/131506.079000:ERROR:device_event_log_impl.cc(156)] [13:15:06.077] Network: network_portal_detector_impl.cc:465 Portal detection timeout: name=GUESTGATE id=9a8908bd-87ce-4d21-a45d-6faeae69e579 [20859:20859:0606/131513.760654:ERROR:device_event_log_impl.cc(156)] [13:15:13.759] Network: network_portal_detector_impl.cc:465 Portal detection timeout: name= id= [20859:20859:0606/131524.236770:ERROR:device_event_log_impl.cc(156)] [13:15:24.235] Network: network_portal_detector_impl.cc:465 Portal detection timeout: name= id= [20859:20859:0606/131539.765748:ERROR:device_event_log_impl.cc(156)] [13:15:39.764] Network: network_portal_detector_impl.cc:465 Portal detection timeout: name= id= [20859:20859:0606/131541.322890:ERROR:gaia_screen_handler.cc(244)] MaybePreloadAuthExtension [20859:21063:0606/131541.489980:ERROR:service_manager.cc(142)] Connection InterfaceProviderSpec prevented service: content_plugin from binding interface: memory_instrumentation::mojom::Coordinator exposed by: content_browser [20859:20859:0606/131636.349218:ERROR:device_event_log_impl.cc(156)] [13:16:36.347] Network: network_portal_detector_impl.cc:465 Portal detection timeout: name=GUESTGATE id=9a8908bd-87ce-4d21-a45d-6faeae69e579 [20859:20859:0606/131639.864681:ERROR:device_event_log_impl.cc(156)] [13:16:39.862] Network: network_portal_detector_impl.cc:465 Portal detection timeout: name=GUESTGATE id=9a8908bd-87ce-4d21-a45d-6faeae69e579 [20859:20859:0606/131643.318180:ERROR:device_event_log_impl.cc(156)] [13:16:43.317] Network: network_portal_detector_impl.cc:465 Portal detection timeout: name=GUESTGATE id=9a8908bd-87ce-4d21-a45d-6faeae69e579 [20859:20859:0606/131648.892778:ERROR:device_event_log_impl.cc(156)] [13:16:48.892] Network: network_portal_detector_impl.cc:465 Portal detection timeout: name=GUESTGATE id=9a8908bd-87ce-4d21-a45d-6faeae69e579 [20859:20859:0606/131654.758077:ERROR:device_event_log_impl.cc(156)] [13:16:54.757] Network: network_portal_detector_impl.cc:465 Portal detection timeout: name=GUESTGATE id=9a8908bd-87ce-4d21-a45d-6faeae69e579 [20859:20859:0606/131657.937642:ERROR:gaia_screen_handler.cc(244)] MaybePreloadAuthExtension [20859:20859:0606/131706.148950:ERROR:device_event_log_impl.cc(156)] [13:17:06.148] Network: network_portal_detector_impl.cc:465 Portal detection timeout: name= id=
,
Jun 6 2017
Most likely caused by lock screen preloading. Lock screen preloading will go away entirely after the switch to views-based lock.
,
Jun 6 2017
OK, what is the milestone for removing lock screen preloading?
Can we do this:
if (!network_portal_detector_ && GetCurrentScreen() == kScreenId) {
...
}
to fix this issue? Maybe add a TODO note for removing && after decommission lock screen preloading?
,
Jun 6 2017
hmm.. preloading will not make that check work I think
,
Jun 6 2017
Is there an underlying issue/crash here? If we run low on memory the preloaded lock screen will be evicted which will destroy the network detector. I suggest closing this as WontFix.
,
Jun 6 2017
If you do want to fix this, we probably don't want to instantiate GaiaScreenHandler since I don't believe it is used for anything on the lock screen. But all of that code is going to go away so the cost/benefit ratio is likely not worthwhile.
,
Jun 6 2017
Re #5, go/bad-portal describes the bad captive portal issue. Reducing detection attempts before online connection is one of the proposals in the doc, which is aimed at making the problem less common. Let us still fix it. By having two network detectors doesn't making much sense and fixing it can effectively reduce detection attempts.
,
Jun 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d4f038889267bfd326967c840b22166b567c595 commit 3d4f038889267bfd326967c840b22166b567c595 Author: warx <warx@chromium.org> Date: Wed Jun 07 00:39:32 2017 cros: Do not initialize gaia portal detector if not loading gaia Changes: Early bail out in GaiaScreenHandler::MaybePreloadAuthExtension if should not load gaia, so that portal detector will not get initialized and enabled in this case. BUG= 730157 TEST=tested that gaia screen portal detector is not created and used in user session. Review-Url: https://codereview.chromium.org/2928513004 Cr-Commit-Position: refs/heads/master@{#477489} [modify] https://crrev.com/3d4f038889267bfd326967c840b22166b567c595/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
,
Jun 7 2017
,
Jul 24 2017
,
Jul 24 2017
Is this issue affecting M60? We had a GUTS report showing a related signature https://gutsv3.corp.google.com/#ticket/27763563 Can you please evaluate if this bug is related to that GUTS?
,
Jul 24 2017
This is unlikely to be associated; it is about addressing some issues discussed in go/bad-portal.
,
Jan 22 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by warx@chromium.org
, Jun 6 2017