New issue
Advanced search Search tips

Issue 730138 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

The accessibility multiline state is overused

Project Member Reported by aleventhal@chromium.org, Jun 6 2017

Issue description

- It is exposed for descendants of a multiline control, which is not necessary 
- It is exposed for descendants of a single line control, which is wrong

The following is the blink accessibility tree for input-text-value.html
https://cs.chromium.org/chromium/src/content/test/data/accessibility/html/input-text-value.html?q=input-text-valu&sq=package:chromium 

rootWebArea focusable readOnly
++genericContainer readOnly
++++labelText readOnly
++++++staticText readOnly name='l1'
++++++++inlineTextBox disabled name='l1'
++++textField editable focusable name='l1'
++++labelText readOnly
++++++staticText readOnly name='l2'
++++++++inlineTextBox disabled name='l2'
++++textField editable focusable name='l2' value='value'
++++++genericContainer editable multiline
++++++++staticText editable multiline name='value'
++++++++++inlineTextBox disabled multiline name='value'
++++textField editable focusable name='l2'
++++textField editable focusable name='l2' value='value'
++++++genericContainer editable multiline
++++++++staticText editable multiline name='value'
++++++++++inlineTextBox disabled multiline name='value'
++++labelText readOnly
++++++staticText readOnly name='Email'
++++++++inlineTextBox disabled name='Email'
++++genericContainer offscreen readOnly
++++textField editable focusable name='Email'
++++textField editable focusable name='Email' value='value'
++++++genericContainer editable multiline
++++++++staticText editable multiline name='value'
++++++++++inlineTextBox disabled multiline name='value'
++++textField editable focusable multiline name='l5'
++++textField editable focusable multiline name='l6' value='Value'
++++++genericContainer editable multiline
++++++++staticText editable multiline name='Value'
++++++++++inlineTextBox disabled multiline name='Value'

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a1e7c0f36fc682b8572f3d781943aef6edce818

commit 5a1e7c0f36fc682b8572f3d781943aef6edce818
Author: aleventhal <aleventhal@chromium.org>
Date: Fri Jul 07 21:18:17 2017

More precise use of multiline state. It only needs to be exposed at the root of the editable area. ARIA should override native markup. Add lots of tests.

BUG= 730138 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2931893002
Cr-Commit-Position: refs/heads/master@{#485051}

[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/browser/accessibility/browser_accessibility.h
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[add] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/test/data/accessibility/aria/aria-multiline-expected-blink.txt
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/test/data/accessibility/aria/aria-multiline-expected-win.txt
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/test/data/accessibility/aria/aria-multiline.html
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/test/data/accessibility/aria/aria-textbox-expected-blink.txt
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/test/data/accessibility/aria/aria-textbox-expected-win.txt
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/test/data/accessibility/aria/aria-textbox-with-rich-text-expected-win.txt
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/test/data/accessibility/aria/aria-textbox-with-selection-expected-android.txt
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/test/data/accessibility/aria/aria-textbox-with-selection-expected-blink.txt
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/test/data/accessibility/aria/aria-textbox-with-selection.html
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/test/data/accessibility/aria/aria-textbox.html
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/test/data/accessibility/css/color-expected-blink.txt
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/test/data/accessibility/css/color-expected-win.txt
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/test/data/accessibility/css/font-style-expected-blink.txt
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/test/data/accessibility/css/font-style-expected-win.txt
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/test/data/accessibility/event/aria-combo-box-collapse-expected-win.txt
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/test/data/accessibility/event/aria-combo-box-expand-expected-win.txt
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/test/data/accessibility/event/aria-combo-box-focus-expected-win.txt
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/test/data/accessibility/event/aria-combo-box-next-expected-win.txt
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/test/data/accessibility/html/contenteditable-descendants-expected-blink.txt
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/test/data/accessibility/html/contenteditable-descendants-expected-win.txt
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/test/data/accessibility/html/contenteditable-descendants-with-selection-expected-blink.txt
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/test/data/accessibility/html/contenteditable-descendants-with-selection-expected-win.txt
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/test/data/accessibility/html/contenteditable-descendants-with-selection.html
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/test/data/accessibility/html/contenteditable-descendants.html
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/test/data/accessibility/html/contenteditable-with-embedded-contenteditables-expected-blink.txt
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/test/data/accessibility/html/contenteditable-with-embedded-contenteditables-expected-win.txt
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/test/data/accessibility/html/contenteditable-with-no-descendants-expected-blink.txt
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/test/data/accessibility/html/contenteditable-with-no-descendants-expected-win.txt
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/test/data/accessibility/html/input-text-value-expected-blink.txt
[add] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/test/data/accessibility/html/input-text-value-expected-win.txt
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/test/data/accessibility/html/input-text-value.html
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/test/data/accessibility/html/textarea-expected-blink.txt
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/test/data/accessibility/html/textarea-read-only-expected-blink.txt
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/content/test/data/accessibility/html/textarea-with-selection-expected-blink.txt
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
[modify] https://crrev.com/5a1e7c0f36fc682b8572f3d781943aef6edce818/third_party/WebKit/Source/modules/accessibility/AXObject.h

Status: Fixed (was: Assigned)

Sign in to add a comment