Issue metadata
Sign in to add a comment
|
[Forum PreStable] Some elements surrounded by black borders. |
|||||||||||||||||||||||||||||||||||
Issue descriptionChrome Version: 59.0.3071.86 OS: Win 10 (Most likely ultra portables with detachable keyboards) Some user feedback 1. there're black border on many elements on many webpages such as Facebook, 99designs, this forum and what not. 2. most of the links on a web page are surrounded by a frame or border or black background. None of those black boxes should be seen (they are DIVs) that delimit the link area of the link. I only happen on this machine an HP x2 210 G1 Tablet (integrated intel graphics) with Windows 10 Pro. I have tried it on other computers and it does not happen. What is the expected result? Black borders should not be shown around elements with shadows What happens instead? Please see attached screenshots Forum : https://productforums.google.com/forum/#!topic/chrome/iXD93VKi_ec Working with users to get GPU details. Marking this bug RVG due to screenshots.
,
Jun 6 2017
Need about:gpu information. Looks like a rasterization bug to me?
,
Jun 6 2017
Here's one user's about:gpu from the above forum posting. Intel GPU. John, do you have a machine that could possibly reproduce this? Graphics Feature Status Canvas: Hardware accelerated Flash: Hardware accelerated Flash Stage3D: Hardware accelerated Flash Stage3D Baseline profile: Hardware accelerated Compositing: Hardware accelerated Multiple Raster Threads: Enabled Native GpuMemoryBuffers: Software only. Hardware acceleration disabled Rasterization: Hardware accelerated Video Decode: Hardware accelerated Video Encode: Hardware accelerated WebGL: Hardware accelerated WebGL2: Hardware accelerated Driver Bug Workarounds clear_uniforms_before_first_program_use decode_encode_srgb_for_generatemipmap disable_accelerated_vpx_decode disable_discard_framebuffer disable_framebuffer_cmaa disable_larger_than_screen_overlays exit_on_context_lost force_cube_complete msaa_is_slow scalarize_vec_and_mat_constructor_args texsubimage_faster_than_teximage Problems Detected Some drivers are unable to reset the D3D device in the GPU process sandbox Applied Workarounds: exit_on_context_lost TexSubImage is faster for full uploads on ANGLE Applied Workarounds: texsubimage_faster_than_teximage Clear uniforms before first program use on all platforms: 124764, 349137 Applied Workarounds: clear_uniforms_before_first_program_use Always rewrite vec/mat constructors to be consistent: 398694 Applied Workarounds: scalarize_vec_and_mat_constructor_args ANGLE crash on glReadPixels from incomplete cube map texture: 518889 Applied Workarounds: force_cube_complete On Intel GPUs MSAA performance is not acceptable for GPU rasterization: 527565 Applied Workarounds: msaa_is_slow Framebuffer discarding can hurt performance on non-tilers: 570897 Applied Workarounds: disable_discard_framebuffer Limited enabling of Chromium GL_INTEL_framebuffer_CMAA: 535198 Applied Workarounds: disable_framebuffer_cmaa Disable KHR_blend_equation_advanced until cc shaders are updated: 661715 Decode and Encode before generateMipmap for srgb format textures on Windows: 634519 Applied Workarounds: decode_encode_srgb_for_generatemipmap VPx decoding is too slow on Intel Broadwell, Skylake, and CherryView: 616318 Applied Workarounds: disable_accelerated_vpx_decode Accelerated VPx decoding is hanging on some videos.: 654111 Applied Workarounds: disable_accelerated_vpx_decode Overlay sizes bigger than screen aren't accelerated on some Intel drivers: 720059 Applied Workarounds: disable_larger_than_screen_overlays Native GpuMemoryBuffers have been disabled, either via about:flags or command line. Disabled Features: native_gpu_memory_buffers Version Information Data exported 6/7/2017, 7:07:11 AM Chrome version Chrome/59.0.3071.86 Operating system Windows NT 10.0.15063 Software rendering list version 13.8 Driver bug list version 10.101 ANGLE commit id a9042d3c1952 2D graphics backend Skia/59 ef6f9c65527412ec4057ea0551f2e051beb94d32 Command Line Args Files (x86)\Google\Chrome\Application\chrome.exe" --flag-switches-begin --flag-switches-end Driver Information Initialization time 412 In-process GPU false Passthrough Command Decoder false Supports overlays false Sandboxed false GPU0 VENDOR = 0x8086, DEVICE= 0x22b0 Optimus false Optimus false AMD switchable false Desktop compositing Aero Glass Driver vendor Intel Corporation Driver version 20.19.15.4474 Driver date 6-13-2016 Pixel shader version 5.0 Vertex shader version 5.0 Max. MSAA samples 8 Machine model name Machine model version GL_VENDOR Google Inc. GL_RENDERER ANGLE (Intel(R) HD Graphics Direct3D11 vs_5_0 ps_5_0) GL_VERSION OpenGL ES 3.0 (ANGLE 2.1.0.a9042d3c1952) GL_EXTENSIONS GL_ANGLE_client_arrays GL_ANGLE_depth_texture GL_ANGLE_framebuffer_blit GL_ANGLE_framebuffer_multisample GL_ANGLE_instanced_arrays GL_ANGLE_lossy_etc_decode GL_ANGLE_pack_reverse_row_order GL_ANGLE_request_extension GL_ANGLE_robust_client_memory GL_ANGLE_robust_resource_initialization GL_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_ANGLE_texture_usage GL_ANGLE_translated_shader_source GL_CHROMIUM_bind_generates_resource GL_CHROMIUM_bind_uniform_location GL_CHROMIUM_copy_compressed_texture GL_CHROMIUM_copy_texture GL_CHROMIUM_sync_query GL_EXT_blend_minmax GL_EXT_color_buffer_float GL_EXT_color_buffer_half_float GL_EXT_debug_marker GL_EXT_discard_framebuffer GL_EXT_disjoint_timer_query GL_EXT_draw_buffers GL_EXT_frag_depth GL_EXT_map_buffer_range GL_EXT_occlusion_query_boolean GL_EXT_read_format_bgra GL_EXT_robustness GL_EXT_sRGB GL_EXT_shader_texture_lod GL_EXT_texture_compression_dxt1 GL_EXT_texture_compression_s3tc_srgb GL_EXT_texture_filter_anisotropic GL_EXT_texture_format_BGRA8888 GL_EXT_texture_norm16 GL_EXT_texture_rg GL_EXT_texture_storage GL_EXT_unpack_subimage GL_KHR_debug GL_NV_EGL_stream_consumer_external GL_NV_fence GL_NV_pack_subimage GL_NV_pixel_buffer_object GL_OES_EGL_image GL_OES_EGL_image_external GL_OES_EGL_image_external_essl3 GL_OES_compressed_ETC1_RGB8_texture GL_OES_depth32 GL_OES_element_index_uint GL_OES_get_program_binary GL_OES_mapbuffer GL_OES_packed_depth_stencil GL_OES_rgb8_rgba8 GL_OES_standard_derivatives GL_OES_texture_float GL_OES_texture_float_linear GL_OES_texture_half_float GL_OES_texture_half_float_linear GL_OES_texture_npot GL_OES_vertex_array_object Disabled Extensions GL_KHR_blend_equation_advanced GL_KHR_blend_equation_advanced_coherent Window system binding vendor Google Inc. (adapter LUID: 00000000000078e9) Window system binding version 1.4 (ANGLE 2.1.0.a9042d3c1952) Window system binding extensions EGL_EXT_create_context_robustness EGL_ANGLE_d3d_share_handle_client_buffer EGL_ANGLE_d3d_texture_client_buffer EGL_ANGLE_surface_d3d_texture_2d_share_handle EGL_ANGLE_query_surface_pointer EGL_ANGLE_window_fixed_size EGL_ANGLE_keyed_mutex EGL_ANGLE_surface_orientation EGL_ANGLE_direct_composition EGL_NV_post_sub_buffer EGL_KHR_create_context EGL_EXT_device_query EGL_KHR_image EGL_KHR_image_base EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_KHR_get_all_proc_addresses EGL_KHR_stream EGL_KHR_stream_consumer_gltexture EGL_NV_stream_consumer_gltexture_yuv EGL_ANGLE_flexible_surface_compatibility EGL_ANGLE_stream_producer_d3d_texture_nv12 EGL_ANGLE_create_context_webgl_compatibility EGL_CHROMIUM_create_context_bind_generates_resource EGL_CHROMIUM_sync_control EGL_EXT_pixel_format_float EGL_ANGLE_display_texture_share_group EGL_ANGLE_create_context_client_arrays EGL_ANGLE_create_context_robust_resource_initialization Direct rendering Yes Reset notification strategy 0x8252 GPU process crash count 0 Compositor Information Tile Update Mode One-copy Partial Raster Enabled GpuMemoryBuffers Status ATC Software only ATCIA Software only DXT1 Software only DXT5 Software only ETC1 Software only R_8 Software only RG_88 Software only BGR_565 Software only RGBA_4444 Software only RGBX_8888 Software only RGBA_8888 Software only BGRX_8888 Software only BGRA_8888 Software only RGBA_F16 Software only YVU_420 Software only YUV_420_BIPLANAR Software only UYVY_422 Software only Diagnostics 0 b3DAccelerationEnabled true b3DAccelerationExists true bAGPEnabled true bAGPExistenceValid true bAGPExists true bCanRenderWindow true bDDAccelerationEnabled true bDriverBeta false bDriverDebug false bDriverSigned false bDriverSignedValid false bNoHardware false dwBpp 32 dwDDIVersion 12 dwHeight 800 dwRefreshRate 60 dwWHQLLevel 0 dwWidth 1280 iAdapter 0 lDriverSize 39511240 lMiniVddSize 0 szAGPStatusEnglish Enabled szAGPStatusLocalized Enabled szChipType Intel(R) HD Graphics szD3DStatusEnglish Enabled szD3DStatusLocalized Enabled szDACType Internal szDDIVersionEnglish 12 szDDIVersionLocalized 12 szDDStatusEnglish Enabled szDDStatusLocalized Enabled szDXVAHDEnglish Supported szDXVAModes ModeMPEG2_A ModeMPEG2_C ModeWMV9_C ModeVC1_C szDescription Intel(R) HD Graphics szDeviceId 0x22B0 szDeviceIdentifier {D7B78E66-61F0-11CF-6065-06188AC2D935} szDeviceName \\.\DISPLAY1 szDisplayMemoryEnglish 2094 MB szDisplayMemoryLocalized 2094 MB szDisplayModeEnglish 1280 x 800 (32 bit) (60Hz) szDisplayModeLocalized 1280 x 800 (32 bit) (60Hz) szDriverAssemblyVersion 20.19.15.4474 szDriverAttributes Final Retail szDriverDateEnglish 13/6/2016 8:00:00 AM szDriverDateLocalized 6/13/2016 08:00:00 szDriverLanguageEnglish English szDriverLanguageLocalized English szDriverModelEnglish WDDM 2.0 szDriverModelLocalized WDDM 2.0 szDriverName igdumdim64.dll,igd10iumd64.dll,igd10iumd64.dll,igd12umd64.dll szDriverNodeStrongName oem4.inf:5f63e5342b627028:iCHVM_w10:20.19.15.4474:pci\ven_8086&dev_22b0 szDriverSignDate Unknown szDriverVersion 20.19.0015.4474 szKeyDeviceID Enum\PCI\VEN_8086&DEV_22B0&SUBSYS_380917AA&REV_36 szKeyDeviceKey \Registry\Machine\System\CurrentControlSet\Control\Video\{212F01AE-0484-46EA-8E4C-37997D60B2EA}\0000 szManufacturer Intel Corporation szMiniVdd unknown szMiniVddDateEnglish Unknown szMiniVddDateLocalized unknown szMonitorMaxRes Unknown szMonitorName Generic PnP Monitor szNotesEnglish No problems found. szNotesLocalized No problems found. szOverlayEnglish Supported szRankOfInstalledDriver 00D12001 szRegHelpText Unknown szRevision Unknown szRevisionId 0x0036 szSubSysId 0x380917AA szTestResultD3D7English Not run szTestResultD3D7Localized Not run szTestResultD3D8English Not run szTestResultD3D8Localized Not run szTestResultD3D9English Not run szTestResultD3D9Localized Not run szTestResultDDEnglish Not run szTestResultDDLocalized Not run szVdd unknown szVendorId 0x8086
,
Jun 6 2017
0x8086 0x22b0 is Intel Cherryview (Cherry Trail). I don't have anything like that.
,
Jun 7 2017
I have a cherryview device that can repro the issue.... running a bisect now.
,
Jun 7 2017
Bisected to the following revision: https://chromium.googlesource.com/chromium/src/+log/bce355c4052c6a9c3863c355a7150b4df8f08b0c..a0d155d336a59388f84140f7b4c4f79cb1f36e40 Seems like it could be either the Angle roll here: https://chromium.googlesource.com/angle/angle.git/+log/d0fcb90..4063e20 or the Skia roll here: https://skia.googlesource.com/skia.git/+/02be3c1c3f53858263df82b1db466b5bb7059ab0 From looking at the changes, Skia roll seems to be laregly non-gpu-specific, so maybe an Angle change, perhaps: https://chromium.googlesource.com/angle/angle.git/+/95f6ceddd672970b4256a15e13f05ca0b6ec8539 Which seems to do with clearing and blending modes - an issue here seems like it could result in the black output (non-blended transparent alpha?). Adding people from that CL. shahmeer.esmail@ and jmadill@, can you take a look and see if this change could explain the bug we're seeing?
,
Jun 7 2017
,
Jun 7 2017
Based on offline chat with Eric, This is a straight forward bug which would impact sizable user based with the specific hardware. Eric can if possible can you please provide exact number of users who can effect.
,
Jun 7 2017
This is easy to repro on impacted hardware - don't really understand the cause yet. From looking at UMA, assuming this bug is cherrview only, this will impact ~1.6% of our Windows stable users.
,
Jun 7 2017
Shahmeer no longer work for Intel.
,
Jun 7 2017
Confirmed via manual build / revert that the Angle change indicated above causes the visual corruption to start appearing (although it's very likely we are just hitting a driver issue): https://chromium.googlesource.com/angle/angle.git/+/95f6ceddd672970b4256a15e13f05ca0b6ec8539
,
Jun 7 2017
Hey Yang, It seems likely that there is a bug in the Intel GPU drivers for Intel Cherryview (Cherry Trail), which gets exposed from an ANGLE CL mentioned in comment #11. Could you look into this with your team and see if you can reproduce this problem in-house? In the meantime I will order a version of the affected hardware and try to repro. This issue does not repro on my Intel Skylake HD Graphics 530.
,
Jun 7 2017
I have a pending change which works around the issue by blacklisting D3D11 on affected devices. Reverting the Angle change seemed quite complex, so temporarily moving to the D3D9 path (which is unaffected) seems safest. https://chromium-review.googlesource.com/c/527477/ Once that lands, we should merge to M59, M60. We can then investigate a more thorough Angle (or Intel) fix for M60 timeframe. On the test side, it would be great to confirm that this issue is scoped to Cherryview hardware. I've tested the Intel devices I have locally, and only my Cherryview device repros. Test has also verified three additional machines (no repro). This is probably fine, but any additional testing would be great.
,
Jun 7 2017
I have tried to reproduce the issue on 3 different machine with Intel machines(Windows 7 and 10) where I wasn't able to reproduce the issue.
,
Jun 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27cc6805cf59eb98ff62b9b5e5566faee6109e01 commit 27cc6805cf59eb98ff62b9b5e5566faee6109e01 Author: Eric Karl <ericrk@chromium.org> Date: Wed Jun 07 23:24:36 2017 Disable D3D11 on Intel Cherryview D3D11 on Intel Cherryview GPUs experiences visual corruption after Angle change here: https://chromium.googlesource.com/angle/angle.git/+/95f6ceddd672970b4256a15e13f05ca0b6ec8539 Fixing / Working around this in Angle will be more involved, so this CL temporarily disables D3D11 and the problematic D3D11 Angle path until a more complete fix can be created. Bug: 730126 Change-Id: Ib6b041e69c745c0ad3a81dd43902edc85a993615 Reviewed-on: https://chromium-review.googlesource.com/527477 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#477775} [modify] https://crrev.com/27cc6805cf59eb98ff62b9b5e5566faee6109e01/gpu/config/gpu_driver_bug_list.json
,
Jun 8 2017
,
Jun 8 2017
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 8 2017
Per #9, this change represents fairly significant visual corruption for ~1.6% of Windows users on a large number of sites. Would like to merge to M59.
,
Jun 8 2017
We don't have Cherryview at hand. Let me cc Bryan Bernhart first to see if he can provide some help.
,
Jun 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea298d2051e9fa3ecec5f301b9041d736bad4a7e commit ea298d2051e9fa3ecec5f301b9041d736bad4a7e Author: Kai Ninomiya <kainino@chromium.org> Date: Thu Jun 08 05:47:58 2017 Add missing cr_bugs entry to gpu driver bug list TBR=kbr@chromium.org Bug: 730126 Change-Id: I647d556c3ab9a557d37082a1d14bdeab6d8ab702 Reviewed-on: https://chromium-review.googlesource.com/528014 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#477905} [modify] https://crrev.com/ea298d2051e9fa3ecec5f301b9041d736bad4a7e/gpu/config/gpu_driver_bug_list.json
,
Jun 8 2017
erick@ - as discussed, let's wait until today/tomorrow to see canary data and verify fix. Then, we can re-visit merge review for M59.
,
Jun 8 2017
Opening bug for public view after removing screenshots.
,
Jun 8 2017
+ReleaseBlock - since this is a blocker
,
Jun 8 2017
I don't think this should block release any more with the blacklist entry. We'll likely fix it for M60, but it shouldn't block 59 release. Please clarify if that is not correct.
,
Jun 8 2017
Sorry for toggling the flag :D - I'll remove releaseblock-stable once I've merged to M59 - will likely land today - let's keep this on until then so we don't lose visiblity into this CL. I'll assign back to jmadill@ at this point.
,
Jun 8 2017
,
Jun 9 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 9 2017
Confirmed the fix in Canary. Would like to move ahead with merge to M59.
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1be4e414cb6086f4898a162c9b294b4ccdda9bfe commit 1be4e414cb6086f4898a162c9b294b4ccdda9bfe Author: Eric Karl <ericrk@chromium.org> Date: Fri Jun 09 16:03:58 2017 Disable D3D11 on Intel Cherryview D3D11 on Intel Cherryview GPUs experiences visual corruption after Angle change here: https://chromium.googlesource.com/angle/angle.git/+/95f6ceddd672970b4256a15e13f05ca0b6ec8539 Fixing / Working around this in Angle will be more involved, so this CL temporarily disables D3D11 and the problematic D3D11 Angle path until a more complete fix can be created. Bug: 730126 Change-Id: Ib6b041e69c745c0ad3a81dd43902edc85a993615 Reviewed-on: https://chromium-review.googlesource.com/527477 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#477775} Review-Url: https://codereview.chromium.org/2931113002 . Cr-Commit-Position: refs/branch-heads/3112@{#283} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/1be4e414cb6086f4898a162c9b294b4ccdda9bfe/gpu/config/gpu_driver_bug_list.json
,
Jun 9 2017
Approving merge to M59.
,
Jun 9 2017
branch: 3071
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d11584b51627ec8f09959a0def2a5d20d2ca007 commit 0d11584b51627ec8f09959a0def2a5d20d2ca007 Author: Eric Karl <ericrk@chromium.org> Date: Fri Jun 09 16:53:33 2017 Disable D3D11 on Intel Cherryview D3D11 on Intel Cherryview GPUs experiences visual corruption after Angle change here: https://chromium.googlesource.com/angle/angle.git/+/95f6ceddd672970b4256a15e13f05ca0b6ec8539 Fixing / Working around this in Angle will be more involved, so this CL temporarily disables D3D11 and the problematic D3D11 Angle path until a more complete fix can be created. Bug: 730126 Change-Id: Ib6b041e69c745c0ad3a81dd43902edc85a993615 Reviewed-on: https://chromium-review.googlesource.com/527477 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#477775} Review-Url: https://codereview.chromium.org/2928163002 . Cr-Commit-Position: refs/branch-heads/3071@{#766} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/0d11584b51627ec8f09959a0def2a5d20d2ca007/gpu/config/gpu_driver_bug_list.json
,
Jun 9 2017
Now that the workaround is merged to Beta, dropping release-block, and re-assigning to jmadill@ for a more long-term fix.
,
Jun 9 2017
Issue 731695 has been merged into this issue.
,
Jun 9 2017
Pasting the comment from issue#731695 , "They say turning off hardware acceleration helps as a temporary workaround: https://www.reddit.com/r/webdev/comments/6funh4/just_updated_to_chrome_59_getting_black_borders/"
,
Jun 12 2017
- RVG making this bug public as suggested above.
,
Jun 12 2017
Making progress here, will update tomorrow.
,
Jun 13 2017
Unable to verify the issue as we don't have any intel specific driver machine here with India team. Hence passing this issue to MTV team. @MTV team: Can someone form MTV team please look into this issue?
,
Jun 13 2017
,
Jun 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/c174db3a03efebfefd0189e24ad7e435cb54bcdf commit c174db3a03efebfefd0189e24ad7e435cb54bcdf Author: Jamie Madill <jmadill@chromium.org> Date: Tue Jun 13 21:02:14 2017 D3D11: Apply a non-null blendstate in masked depth clear. In https://chromium-review.googlesource.com/c/453888/, we changed how blendstates were applied in masked clears. This change would apply a null blendstate when all color channels were disabled, but this seems to have an issue on Intel Cherry View drivers. Work around this issue by restoring the prior functionality of making a simple masked blend state. Also clean up some of the code style in the Clear11 class. BUG= chromium:730126 Change-Id: I9a4044201b2f07e9483525513a59e19bb2a8bcd3 Reviewed-on: https://chromium-review.googlesource.com/533684 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> [modify] https://crrev.com/c174db3a03efebfefd0189e24ad7e435cb54bcdf/src/libANGLE/renderer/d3d/d3d11/renderer11_utils.cpp [modify] https://crrev.com/c174db3a03efebfefd0189e24ad7e435cb54bcdf/src/libANGLE/renderer/d3d/d3d11/RenderStateCache.cpp [modify] https://crrev.com/c174db3a03efebfefd0189e24ad7e435cb54bcdf/src/libANGLE/renderer/d3d/d3d11/renderer11_utils.h [modify] https://crrev.com/c174db3a03efebfefd0189e24ad7e435cb54bcdf/src/libANGLE/renderer/d3d/d3d11/Clear11.cpp
,
Jun 13 2017
Excellent analysis and fix Jamie!
,
Jun 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6e5aae826b354d44a155460d6a2e0674971f4c8 commit e6e5aae826b354d44a155460d6a2e0674971f4c8 Author: jmadill <jmadill@chromium.org> Date: Tue Jun 13 22:47:36 2017 Roll ANGLE cabdd1a..fb05bcb https://chromium.googlesource.com/angle/angle.git/+log/cabdd1a..fb05bcb BUG=None,chromium:730126 TBR=geofflang@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2933413003 Cr-Commit-Position: refs/heads/master@{#479187} [modify] https://crrev.com/e6e5aae826b354d44a155460d6a2e0674971f4c8/DEPS
,
Jun 14 2017
I still have not seen any changes on my end. Still black boxes
,
Jun 14 2017
Re #43 - the change hasn't made it into a stable release yet. It should end up making it out this week. Please check that your chrome version is > 59.0.3071.86 to see if you should have the fix. Thanks!
,
Jun 14 2017
jmadill@, can you merge the fix to M60? At that point I'll revert my D3D9 blacklist change in M60/M61. Thanks!
,
Jun 14 2017
Issue 733094 has been merged into this issue.
,
Jun 14 2017
This bug requires manual review: DEPS changes referenced in bugdroid comments. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 14 2017
Approving merge for M60, as it's a clear regression and we've taken the change in for M59.
,
Jun 15 2017
Sure, I'll merge it to M60/branch 3112.
,
Jun 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/f1ca5288afea5f65d8af8c745e4fa0e2d69ebd40 commit f1ca5288afea5f65d8af8c745e4fa0e2d69ebd40 Author: Jamie Madill <jmadill@chromium.org> Date: Thu Jun 15 19:19:00 2017 D3D11: Apply a non-null blendstate in masked depth clear. In https://chromium-review.googlesource.com/c/453888/, we changed how blendstates were applied in masked clears. This change would apply a null blendstate when all color channels were disabled, but this seems to have an issue on Intel Cherry View drivers. Work around this issue by restoring the prior functionality of making a simple masked blend state. Also clean up some of the code style in the Clear11 class. BUG= chromium:730126 Change-Id: I9a4044201b2f07e9483525513a59e19bb2a8bcd3 Reviewed-on: https://chromium-review.googlesource.com/533684 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/537203 Reviewed-by: Jamie Madill <jmadill@chromium.org> [modify] https://crrev.com/f1ca5288afea5f65d8af8c745e4fa0e2d69ebd40/src/libANGLE/renderer/d3d/d3d11/renderer11_utils.cpp [modify] https://crrev.com/f1ca5288afea5f65d8af8c745e4fa0e2d69ebd40/src/libANGLE/renderer/d3d/d3d11/RenderStateCache.cpp [modify] https://crrev.com/f1ca5288afea5f65d8af8c745e4fa0e2d69ebd40/src/libANGLE/renderer/d3d/d3d11/renderer11_utils.h [modify] https://crrev.com/f1ca5288afea5f65d8af8c745e4fa0e2d69ebd40/src/libANGLE/renderer/d3d/d3d11/Clear11.cpp
,
Jun 15 2017
Eric can you handle the blacklist and verification on your local device?
,
Jun 16 2017
Yup, I'll take care of this. Thanks for the fix!
,
Jun 22 2017
,
Jun 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/3e6a61fecba96d06ac24e9bc0e4a030f2bb3cc1d commit 3e6a61fecba96d06ac24e9bc0e4a030f2bb3cc1d Author: Jamie Madill <jmadill@chromium.org> Date: Thu Jun 22 16:43:09 2017 D3D11: Fix nullptr dereference from bad merge. f1ca5288af was a cherry-pick that was merged incorrectly after some conflicts. This was causing a very serious crasher in Chrome. BUG= chromium:730126 BUG= chromium:735986 Change-Id: I82a48c25d604e1088800cb870297ccfef5915fc5 Reviewed-on: https://chromium-review.googlesource.com/544541 Reviewed-by: Jamie Madill <jmadill@chromium.org> [modify] https://crrev.com/3e6a61fecba96d06ac24e9bc0e4a030f2bb3cc1d/src/libANGLE/renderer/d3d/d3d11/Clear11.cpp
,
Jun 26 2017
Issue 716074 has been merged into this issue.
,
Jun 29 2017
This is happening in Chrome Version 59.0.3071.115 Windows 7 with Intel HD Graphics 4600.
,
Jun 29 2017
Re #56, this should be fixed with stable version 59.0.3071.117, which I believe is rolling out now. Can you please check if you have an update available? Thanks!
,
Jun 29 2017
Sorry for the confusion - this should be fixed in version 59.0.3071.115 - ignore comment #57. tigheklory@, can you please navigate to about:gpu and save the contents as "webpage, complete" then attach that here? This will help us identify your issue. A screenshot would also be very helpful. Thanks!
,
Jul 13 2017
Hmm... it does look like the same issue - likely my M59 quick-fix missed some set of cards on which the problem occurred. This will be completely fixed in M60, which will ship around July 26th on Desktop (see https://www.chromium.org/developers/calendar) If you want to temporarily work around this in most cases, please open "about:flags" and find the entry entitled: "Gpu Rasterization" Change the value to "Disabled" and restart Chrome. Otherwise, this will be fixed in M60 by the change in comment number 54.
,
Jul 14 2017
The temp fix worked great! Thanks for the help!
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da2aa6fe3f0cccfc59b46033220145d92e76107c commit da2aa6fe3f0cccfc59b46033220145d92e76107c Author: Eric Karl <ericrk@chromium.org> Date: Thu Jul 20 21:53:20 2017 Re-enable Angle D3D11 on Cherryview With the angle fix here: https://chromium-review.googlesource.com/c/533684/ We can re-enable D3D11. Bug: 730126 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib04b49ecf66464baf92a517c364625c461785c47 Reviewed-on: https://chromium-review.googlesource.com/580187 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#488424} [modify] https://crrev.com/da2aa6fe3f0cccfc59b46033220145d92e76107c/gpu/config/gpu_driver_bug_list.json
,
Aug 25 2017
Issue 740452 has been merged into this issue. |
||||||||||||||||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||||||||||||||||
Comment 1 by gov...@chromium.org
, Jun 6 2017Labels: M-59