New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 730122 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

No focus on NewTabAtStart Chrome window after sign-in

Project Member Reported by ka...@chromium.org, Jun 6 2017

Issue description

Build: 9460.60.0, 59.0.3071.91

Steps to reproduce:
- Set NewTabAtStart in chrome://settings
- Close all browser windows
- Sign-out and Sign-in
- Try typing any search entity in the newly opened Chrome window

Observation: Nothing happens. No typing cursor blinking in omnibox or addressbar. Ficus is missing. Pressing Tab key does not change status.
You have to use touchpad or external mouse to click and regain focus.

Feedback filed after reproduced -https://feedback.corp.google.com/product/208/neutron?lView=rd&lReport=65043211502
 
Owner: abodenha@chromium.org
Status: Assigned (was: Untriaged)
Is this only happening on kip?

Comment 3 by ka...@chromium.org, Jun 6 2017

I guess all boards. The bug was filed after reproducing with nyan_blaze.

Comment 4 by ka...@chromium.org, Jun 6 2017

My bad - it was kip. But observed on caroline and cave too.
Cc: pucchakayala@chromium.org
Unable to reproduce the issue on Chrome 58.0.3029.140/CrOS 9334.72.0 - Reks
Able to reproduce the issue on 59.0.3071.82/9460.57.0 - Paine, & 9460.60.0/ 59.0.3071.91 - Reks, Peppy

Owner: afakhry@chromium.org
afakhry@ can someone on your team look into this?
Cc: afakhry@chromium.org
Owner: wutao@chromium.org
Can't repro this on kevin on ToT. wutao@ can you please take a look?

Comment 8 by wutao@chromium.org, Jun 7 2017

It might be fixed in TOT. I can bisect to find the bad version.

Can't repro on
ELM Chrome 61.0.3119.0.

Can repro on
KEVIN Chrome 60.0.3102.0.
LINK Chrome 60.0.3102.0.

Comment 9 by wutao@chromium.org, Jun 8 2017

Cc: xiy...@chromium.org
+xiyuan@,
I bisected and found this cl [1] could be the cause.
I also found this cl [2] fixed the issue.

xiyuan@
Any idea your cls could be related to the focusing issue? Thanks.

[1] https://codereview.chromium.org/2734933004
[2] https://codereview.chromium.org/2891223002
Labels: M-60
Yes, those affect how ash activates window during signing in. Basically, ash only focus window inside user session (e.g. browser window) when SessionController::IsUserSessionBlocked returns false.

[1] might created a race that even though we set ACTIVE before we create browser window, ACTIVE goes to ash via mojo but browser window creation is sort synchronous. So it could be that browser window activation happens before ash gets the new session state.

[2] marks LOGGED_IN_NOT_ACTIVE as non user blocking. This happens way before creating browser window so fixed the race.

[1] is in M59. So let's merge [2] to M59 and M60. Let me know if it does not merge cleanly and I could help to manually merge it.
Could someone help to merge the cl [2] into M59 and M60?
I am not committer yet.
Labels: Merge-Request-60 Merge-Request-59
Okay. Let me do it.

Requesting merge https://codereview.chromium.org/2891223002 ([2]) to M59 and M60.
Project Member

Comment 13 by sheriffbot@chromium.org, Jun 8 2017

Labels: -Merge-Request-59 Merge-Review-59 Hotlist-Merge-Review
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Request-60 Merge-Approved-60
Labels: Merge-Approved-59
Labels: -M-60 -Merge-Approved-60
[2] is actually already in M60. Removing the M60 merge tags.
Labels: -Merge-Approved-59 merge-merged-3071
Status: Fixed (was: Assigned)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/358a5df9871e31bdb8ee8b815dba6d3b2a905656

commit 358a5df9871e31bdb8ee8b815dba6d3b2a905656
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Mon Jun 12 19:40:04 2017

Merge "cros: Move wallpaper after login screen is gone"

> - Make LoginDisplayHost::Finalize to take a callback to
>   be invoked just before login screen is dismissed;
> - Set ACTIVE session state via the callback so that
>   wallpaper is moved to unlock container after login
>   screen is gone;
> - Add LOGGED_IN_NOT_ACTIVE as another user session blocked
>   exception so that initial browser window created in
>   this state can be activated;
>
> BUG=  718011  
>
> Review-Url: https://codereview.chromium.org/2891223002
> Cr-Commit-Position: refs/heads/master@{#474654}
> (cherry picked from commit e6a229fa45aa9c57619d7e8f7bae4abe8351600c)

Review-Url: https://codereview.chromium.org/2935623003 .
Cr-Commit-Position: refs/branch-heads/3071@{#778}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Labels: -Merge-Review-59
Labels: -Hotlist-Merge-Review
Status: Verified (was: Fixed)
9460.67.0, 59.0.3071.113

Sign in to add a comment