New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 730119 link

Starred by 6 users

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

2.1%-14.2% regression in media_perftests at 476915:476958

Project Member Reported by chcunningham@chromium.org, Jun 6 2017

Issue description

These regressions all appear to be a retrun to a previous average from ~100 revisions prior. Likely some change landed and reverted. Bisects just to be sure.
 
Cc: h...@chromium.org
Owner: h...@chromium.org

=== Auto-CCing suspected CL author hans@chromium.org ===

Hi hans@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : hans
  Commit : ba2ff9ad0d643a443575c839e56ae9edf7106643
  Date   : Mon Jun 05 02:02:06 2017
  Subject: Revert of "win: Set is_clang=true by default over the weekend."

Bisect Details
  Configuration: winx64_10_perf_bisect
  Benchmark    : media.tough_video_cases
  Metric       : vm_working_set_delta_size/tulip2.mp4_gpu
  Change       : 1.88% | 23577.3333333 -> 24020.6666667

Revision             Result                  N
chromium@476917      23577.3 +- 59.5091      6      good
chromium@476920      23493.3 +- 102.554      6      good
chromium@476921      23924.0 +- 128.623      6      bad       <--
chromium@476922      23934.7 +- 72.5902      6      bad
chromium@476923      24003.3 +- 132.353      6      bad
chromium@476928      23966.0 +- 76.4722      6      bad
chromium@476938      23918.7 +- 50.8068      6      bad
chromium@476958      24020.7 +- 124.376      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests media.tough_video_cases

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8977508179883889392

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5781074111627264


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
 Issue 730118  has been merged into this issue.

Comment 5 by h...@chromium.org, Jun 7 2017

Status: WontFix (was: Untriaged)
> These regressions all appear to be a retrun to a previous average from ~100 revisions prior. Likely some change landed and reverted. Bisects just to be sure.

Yes, looks like this is from the end of the clang on winows experiment last weekend.

I'll mark it wontfix since there's nothing to do at the moment, but it's nice to know we'll improve this when we turn on clang for real.
 Issue 730538  has been merged into this issue.
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Jun 13 2017

Cc: alexclarke@chromium.org
 Issue 732312  has been merged into this issue.
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Jun 19 2017

Cc: cblume@chromium.org chiniforooshan@chromium.org reve...@chromium.org
 Issue 734568  has been merged into this issue.
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Jun 23 2017

Cc: falken@chromium.org
 Issue 736189  has been merged into this issue.

Sign in to add a comment