New issue
Advanced search Search tips

Issue 730110 link

Starred by 5 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Windows
Pri: 3
Type: Bug



Sign in to add a comment

touch-action filtering is flaky

Project Member Reported by bokan@chromium.org, Jun 6 2017

Issue description

Chrome Version: 61.0.3122.0
OS: Android

What steps will reproduce the problem?
(1) Load http://bokand.github.io/touchaction.html (attached)
(2) Repeatedly pinch-zoom very quickly (as quickly as you can)

What is the expected result?
The page has touch-action: pan-y set. The pinch gestures shouldn't do anything. (They should be filtered in InputRouterImpl::SendGestureEvent)

What happens instead?
Occasionally (1/10?) the pinch gesture will cause a zoom.

Doing the same to try and zoom out frequently causes a failing DCHECK:

I    7.416s Main  [FATAL:input_router_impl.cc(497)] Check failed: touch_event_queue_->IsPendingAckTouchStart()..
  23 I    7.416s Main..
  24 I    7.416s Main  Stack Trace:
  25 I    7.416s Main    RELADDR   FUNCTION                                                     FILE:LINE
  26 I    7.416s Main    000c50ab  StackTrace                                                   /home/bokan/chrome/src/base/debug/stack_trace.cc:199
  27 I    7.417s Main    000fe9bd  ~LogMessage                                                  /home/bokan/chrome/src/base/logging.cc:552
  28 I    7.417s Main    0110d0f7  content::InputRouterImpl::OnSetTouchAction(cc::TouchAction)  /home/bokan/chrome/src/content/browser/renderer_host/input/input_router_impl.cc:497
  29 I    7.417s Main..
  30 I    7.417s Main  -----------------------------------------------------
  31 I    7.417s Main..
  32 I    7.417s Main      r0 00000000  r1 00005d71  r2 00000006  r3 00000008
  33 I    7.417s Main      r4 b4fc758c  r5 00000006  r6 b4fc7534  r7 0000010c
  34 I    7.417s Main      r8 80f23108  r9 beeedf3c  sl b2323230  fp 00000003
  35 I    7.417s Main      ip 0000000b  sp beeeb0f0  lr b33625c7  pc b3364e30
  36 I    7.417s Main..
  37 I    7.417s Main  Stack Trace:
  38 I    7.417s Main    RELADDR   FUNCTION
  39 I    7.417s Main    00049e30  tgkill+12
  40 I    7.417s Main    000475c3  pthread_kill+34
  41 I    7.417s Main    0001d635  raise+10
  42 I    7.417s Main    00019181  __libc_android_abort+34
  43 I    7.417s Main    00017048  abort+4
  44 I    7.417s Main    000c5037  base::debug::(anonymous namespace)::DebugBreak()
  45 I    7.417s Main    000c501d  base::debug::BreakDebugger()
  46 I    7.417s Main    000ff09b  ~LogMessage
  47 I    7.417s Main    0110d0f7  content::InputRouterImpl::OnSetTouchAction(cc::TouchAction)
  48 I    7.417s Main    0052b6d5  void base::DispatchToMethodImpl<content::ChildHistogramMessageFilter*, void (content::ChildHistogramMessageFilter::*)(int), std::__ndk1::tuple<int> const&, 0u>(content::ChildH
  49 I    7.417s Main    0052b65f  void base::DispatchToMethod<content::ChildHistogramMessageFilter*, void (content::ChildHistogramMessageFilter::*)(int), std::__ndk1::tuple<int> const&>(content::ChildHistogram
  50 I    7.417s Main    01110139  void IPC::DispatchToMethod<content::InputRouterImpl, void (content::InputRouterImpl::*)(cc::TouchAction), void, std::__ndk1::tuple<cc::TouchAction> >(content::InputRouterImpl*
  51 I    7.417s Main    0110d025  bool IPC::MessageT<InputHostMsg_SetTouchAction_Meta, std::__ndk1::tuple<cc::TouchAction>, void>::Dispatch<content::InputRouterImpl, content::InputRouterImpl, void, void (conte
  52 I    7.417s Main    0110c0b5  content::InputRouterImpl::OnMessageReceived(IPC::Message const&)
  53 I    7.417s Main    011eac53  content::RenderWidgetHostImpl::OnMessageReceived(IPC::Message const&)
  54 I    7.417s Main    011beb4d  content::RenderProcessHostImpl::OnMessageReceived(IPC::Message const&)
  55 I    7.417s Main    00021195  IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const&)
  56 I    7.417s Main    0002446d  void base::internal::FunctorTraits<void (IPC::ChannelProxy::Context::*)(IPC::Message const&), void>::Invoke<scoped_refptr<IPC::ChannelProxy::Context> const&, IPC::Message cons
  57 I    7.417s Main    000243fb  void base::internal::InvokeHelper<false, void>::MakeItSo<void (IPC::ChannelProxy::Context::* const&)(IPC::Message const&), scoped_refptr<IPC::ChannelProxy::Context> const&, IP
  58 I    7.417s Main    000243b7  void base::internal::Invoker<base::internal::BindState<void (IPC::ChannelProxy::Context::*)(IPC::Message const&), scoped_refptr<IPC::ChannelProxy::Context>, IPC::Message>, voi
  59 I    7.417s Main    00024301  base::internal::Invoker<base::internal::BindState<void (IPC::ChannelProxy::Context::*)(IPC::Message const&), scoped_refptr<IPC::ChannelProxy::Context>, IPC::Message>, void ()>
  60 I    7.417s Main    000a0e95  base::Callback<void (), (base::internal::CopyMode)0, (base::internal::RepeatMode)0>::Run() &&
  61 I    7.417s Main    000c5e8b  base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*)
  62 I    7.417s Main    00111ca5  base::MessageLoop::RunTask(base::PendingTask*)
  63 I    7.417s Main    0011203d  base::MessageLoop::DeferOrRunPendingTask(base::PendingTask)
  64 I    7.418s Main    0011254f  base::MessageLoop::DoWork()
  65 I    7.418s Main    00115783  DoRunLoopOnce(_JNIEnv*, base::android::JavaParamRef<_jobject*> const&, long long, long long, long long)
  66 I    7.418s Main    00115657  Java_org_chromium_base_SystemMessageHandler_nativeDoRunLoopOnce
  67 I    7.418s Main    00014b25  offset 0x6d000


 
touchaction.html
1.6 KB View Download
Owner: eirage@chromium.org
Status: Assigned (was: Untriaged)
Cc: eirage@chromium.org bokan@chromium.org xidac...@chromium.org
Owner: ----
Status: Available (was: Assigned)
make it available as I'm not going to look into this in the near future. 

(+xida, maybe he is interested since this is related to touch-action)


This looks similar as issue 692729, but the fix there only suppressed the DCHECK doesn't fix the issue. 
Cc: vamshi.kommuri@chromium.org
Issue 919282 has been merged into this issue.
Labels: OS-Windows
Adding OS Windows as per C#3....

Thanks!
Note, this still repros as of 73.0.3664.2

Sign in to add a comment