New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 730100 link

Starred by 1 user
Status: Fixed
Owner:
robliao@chromium.org
Closed: Jun 2017
Cc:
█ euge...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Win-Clang release builds failing with error: unused function 'GetComInitStatusForThread'

Project Member Reported by h...@chromium.org, Jun 6 2017 
This isn't firing on most bots, because they're either debug or building with dcheck always on, but for non-dcheck release builds, e.g https://build.chromium.org/p/chromium.fyi/builders/CrWinClang64/builds/7870 it breaks:

FAILED: obj/base/base/com_init_util.obj 
E:\b\c\goma_client/gomacc.exe ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes /FC @obj/base/base/com_init_util.obj.rsp /c ../../base/win/com_init_util.cc /Foobj/base/base/com_init_util.obj /Fd"obj/base/base_cc.pdb"
E:\b\c\builder\win_clang\src\base\win\com_init_util.cc(37,15):  error: unused function 'GetComInitStatusForThread' [-Werror,-Wunused-function]
ComInitStatus GetComInitStatusForThread() {
              ^
1 error generated.


This is due to https://chromium-review.googlesource.com/c/522855/, which I suppose needs more #ifdef.

Robert, can you take a look?

Comment 1 by robliao@chromium.org, Jun 6 2017 

Yeah, I'll go ahead and revert it now.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8af838d6c1743f6498cbcd7bc5c2ffb118ae8533

commit 8af838d6c1743f6498cbcd7bc5c2ffb118ae8533
Author: Robert Liao <robliao@chromium.org>
Date: Tue Jun 06 19:22:45 2017

Revert "Introduce AssertComInitialized"

This reverts commit 19d7d854deaeb76f9855ae10a0a8a4718c645755.

Reason for revert: Breaks the CrWinClang builder
https://build.chromium.org/p/chromium.fyi/builders/CrWinClang64/builds/7870
FAILED: obj/base/base/com_init_util.obj 
E:\b\c\goma_client/gomacc.exe ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes /FC @obj/base/base/com_init_util.obj.rsp /c ../../base/win/com_init_util.cc /Foobj/base/base/com_init_util.obj /Fd"obj/base/base_cc.pdb"
E:\b\c\builder\win_clang\src\base\win\com_init_util.cc(37,15):  error: unused function 'GetComInitStatusForThread' [-Werror,-Wunused-function]
ComInitStatus GetComInitStatusForThread() {
              ^
1 error generated.

Original change's description:
> Introduce AssertComInitialized
> 
> This change adds AssertComInitialized, which DCHECKs when COM is not
> initialized.
> 
> BUG= 708303 
> 
> Change-Id: I8e857fd8ebd4537340f4b37ed98f02457374e671
> Reviewed-on: https://chromium-review.googlesource.com/522855
> Commit-Queue: Robert Liao <robliao@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Reviewed-by: Scott Graham <scottmg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#477190}

TBR=gab@chromium.org,robliao@chromium.org,scottmg@chromium.org
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
BUG= 708303 , 730100  

Change-Id: I9309067ad277e5f39de4dd138049b428af374a0f
Reviewed-on: https://chromium-review.googlesource.com/526432
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477368}
[modify] https://crrev.com/8af838d6c1743f6498cbcd7bc5c2ffb118ae8533/base/BUILD.gn
[delete] https://crrev.com/8aa0f3df4a5f4adad0bff5b47da58f14d1bb6e23/base/win/com_init_util.cc
[delete] https://crrev.com/8aa0f3df4a5f4adad0bff5b47da58f14d1bb6e23/base/win/com_init_util.h
[delete] https://crrev.com/8aa0f3df4a5f4adad0bff5b47da58f14d1bb6e23/base/win/com_init_util_unittest.cc

Comment 3 by robliao@chromium.org, Jun 6 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment