New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 730099 link

Starred by 1 user
Status: Fixed
Owner:
estevenson@chromium.org
Closed: Jun 2017
Cc:
agrieve@chromium.org
█ wnwen@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Android process_resources sometimes uses stale dependency information

Project Member Reported by estevenson@chromium.org, Jun 6 2017 
Example repro steps:
* ninja -C out/Release monochrome_public_apk
* rm chrome/android/java/res/drawable-xxhdpi/ic_email_googblue_36dp.png
* gn gen out/Release
* ninja -C out/Release monochrome_public_apk

drawable-xxhdpi/ic_email_googblue_36dp.png still ends up in the apk.

This doesn't seem to happen on bots though.

Comment 1 by wnwen@chromium.org, Jun 7 2017 

Horray, so this means the CL removing drawables actually moved the needle, cool! Thanks for looking into it, Eric.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d59edeefb6bfb8e4abe9c2c2ff313baf5f47b513

commit d59edeefb6bfb8e4abe9c2c2ff313baf5f47b513
Author: Eric Stevenson <estevenson@chromium.org>
Date: Mon Jun 12 12:48:54 2017

Android: fix stale process_resources targets.

Prior to this CL, removing an Android resource wouldn't actually remove
it from the final APK.

This CL adds each resource to depfile_deps so that building after
removing an Android resource will work as expected (after a gn gen -
which is required when adding a resource as well).

Bug:  730099 
Change-Id: I9429b61fa19c2c8e3d21df3e30119ba7c6bdec01
Reviewed-on: https://chromium-review.googlesource.com/527492
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478597}
[modify] https://crrev.com/d59edeefb6bfb8e4abe9c2c2ff313baf5f47b513/build/android/gyp/process_resources.py

Comment 3 by estevenson@chromium.org, Jun 12 2017

Status: Fixed (was: Assigned)

Comment 4 by wnwen@chromium.org, Jun 12 2017 

Thanks Eric!
►

Sign in to add a comment