New issue
Advanced search Search tips

Issue 730097 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[remoting] start-host tool improvements

Project Member Reported by lambroslambrou@chromium.org, Jun 6 2017

Issue description

The start-host tool can be used to set up a headless CRD host, but could do with some usability improvements:
* Prompts are in English and not localized.
* The "--name" parameter should be optional like the other parameters. This would allow a Help/Support instructional page (for example) to display a working command, instead of requiring a user to append the name at the end (and failing because of spaces and so on...)
* We currently print the authorization URL if the command syntax is wrong. Instead, it makes more sense to print this URL only when the "--code" parameter is missing.

 
Owner: lambroslambrou@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b543c74b893c362d0fd2c459a51a3c668535d9e

commit 1b543c74b893c362d0fd2c459a51a3c668535d9e
Author: lambroslambrou <lambroslambrou@chromium.org>
Date: Wed Jun 07 00:21:01 2017

[remoting start-host] Make --name optional, and other tweaks.

If --name is omitted, this prompts for a name.
If (and only if) --code is omitted, this prints an authorization URL
which can be used to obtain a code.
This prints a help/usage message if the command includes non-option
parameters, or includes a standard option for requesting help.

BUG= 730097 

Review-Url: https://codereview.chromium.org/2930543002
Cr-Commit-Position: refs/heads/master@{#477479}

[modify] https://crrev.com/1b543c74b893c362d0fd2c459a51a3c668535d9e/remoting/host/setup/start_host_main.cc

Status: Fixed (was: Assigned)
This is all fixed, apart from the localization issue, which I've filed as  bug 739463 .

Sign in to add a comment