New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 730084 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 717218



Sign in to add a comment

Ensure that blink perf can accept more than just time.

Project Member Reported by vmp...@chromium.org, Jun 6 2017

Issue description

Right now the blink perf system seems to only accept a single value (time taken) as a thing to measure.

When migrating rasterize and record, we'll need more values to record. Ideally we can just spit out a json object that can be parsed by the python script to produce all of the values needed.
 
Status: Assigned (was: Unconfirmed)
Cc: haraken@chromium.org wangxianzhu@chromium.org
Components: Speed>Benchmarks
Cc: charliea@chromium.org
Owner: nedngu...@google.com
I think we should take this opportunity to refactor how blink_perf test results are output & integrated with Telemetry. 

Currently it's done very hackily in https://cs.chromium.org/chromium/src/tools/perf/benchmarks/blink_perf.py?q=blink_perf.py&dr&l=222 

Summary of what those code does: telemetry parses the "log" element in the dom & output the data in that log. 

What it should do instead: blink_perf harness should store its results in a js dictionary, something like testRunner.testResults. Telemetry should just use evaluate that object to get the test results out.
Design doc: https://docs.google.com/document/d/1YFw49ap4ovznC6FKo_hFTO418pu9HI3CLnuVFqq0msQ/edit#

PTAL and let me know what you think
Status: Started (was: Assigned)
The design doc LGTM.
LGTM with my admittedly not-much-context
Owner: nednguyen@chromium.org

Sign in to add a comment