Issue metadata
Sign in to add a comment
|
Skia mask filters don't work in Direct3D 9 mode.
Reported by
lo...@yandex-team.ru,
Jun 6 2017
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3117.0 Safari/537.36 Steps to reproduce the problem: 1. Compile cc_unittest in chromium master 2. Run cc_unittests.exe --gtest_filter=*EnlargedTextureWithAlphaThresholdFilter* --use-gpu-in-tests --disable-d3d11 What is the expected behavior? All tests passed. What went wrong? Software test passed, GL test failed. Did this work before? Yes ~58.0.3007.3 Chrome version: 61.0.3117.0 Channel: canary OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: Creating kAlpha_8_GrPixelConfig textures in d3d9 mode is broken. https://cs.chromium.org/chromium/src/third_party/skia/src/effects/SkAlphaThresholdFilter.cpp?l=106 If we replace kAlpha_8_GrPixelConfig -> kRGBA_8888_GrPixelConfig, all tests pass.
,
Jun 6 2017
Hi, are you able to bisect where it went wrong?
,
Jun 6 2017
Or, I guess you have a fix suggestion, so maybe the bisect isn't needed if the bug is understandable from there :)
,
Jun 6 2017
In Yandex.Browser we use mask filter for UI bubbles. It broke when we merged chromium 58.0.3007.3. But I don't know does chromium use this filters for UI ( I think it doesn't ), so I can't easily bisect chromium.
,
Jun 6 2017
I believe this is a dupe of Issue 720325 but cc'ing Robert to confirm.
,
Jun 6 2017
Hm, It is strange, because I can repro bug in the latest master: commit 14b5a11abcadd47e2b7bf5baf1f6f545232f520f Author: tjbecker <tjbecker@google.com> Date: Tue Jun 6 13:01:27 2017 -0700 Fix High_Level-Bindings-APIs link There was a typo in the markdown link. Review-Url: https://codereview.chromium.org/2928633002 Cr-Commit-Position: refs/heads/master@{#477383} Run: cc_unittests.exe --gtest_filter=*EnlargedTextureWithAlphaThresholdFilter* --use-gpu-in-tests --disable-d3d11
,
Jun 7 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/5ab7276a35906734b017add5cc37fd8cf477a63b commit 5ab7276a35906734b017add5cc37fd8cf477a63b Author: Robert Phillips <robertphillips@google.com> Date: Wed Jun 07 17:27:54 2017 Suppress rendererability of kAlpha8 GL_CHROMIUM_framebuffer_multisample for ANGLE D3D9 For ANGLE D3D9 ES2 we're seeing GL_CHROMIUM_framebuffer_multisample but not GL_ANGLE_framebuffer_multisample. The same occurs for ANGLE D3D11 ES2 but kAlpha8 is renderable in that case. Bug: 730082 Change-Id: I7eda844b0ad48150d19406517d1dfbe453e9e478 Reviewed-on: https://skia-review.googlesource.com/18980 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> [modify] https://crrev.com/5ab7276a35906734b017add5cc37fd8cf477a63b/src/gpu/gl/GrGLGpu.cpp [modify] https://crrev.com/5ab7276a35906734b017add5cc37fd8cf477a63b/src/gpu/gl/GrGLCaps.h [modify] https://crrev.com/5ab7276a35906734b017add5cc37fd8cf477a63b/src/gpu/gl/GrGLCaps.cpp
,
Jun 7 2017
crbug.com/720325 involved incorrect RG support information in ANGLE D3D9. In this bug we are/were incorrectly assuming A8 support. https://skia-review.googlesource.com/18980 sorts out the Skia caps settings for this bug. Wrt getting this working with M58 I suggest applying the following CLs to your M58 fork: ANGLE: https://chromium-review.googlesource.com/c/523023/ Skia: https://skia-review.googlesource.com/18980
,
Jun 7 2017
I don't necessarily think we want to merge this back to M-60 (since we're not seeing bug reports about this) but I thought it should be on the branch managers' radar.
,
Jun 8 2017
Thank you for fix! I think we can close this issue.
,
Jun 8 2017
,
Jun 8 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 12 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 12 2017
Please merge the patch to M60 branch(3112),Beta RC cut is scheduled @ 4.00 PM PST tomorrow(06/13).
,
Jun 15 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 15 2017
Ping..
,
Jun 16 2017
I think it can be done only by googler, not me. robertphillips@chromium.org ?
,
Jun 16 2017
Assigning to Robert to merge the patch.
,
Jun 22 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/a46f69bf6f3283c8ee71674617f3eb27ad905565 commit a46f69bf6f3283c8ee71674617f3eb27ad905565 Author: Robert Phillips <robertphillips@google.com> Date: Thu Jun 22 19:27:03 2017 [M60 cherry pick] Suppress rendererability of kAlpha8 GL_CHROMIUM_framebuffer_multisample for ANGLE D3D9 For ANGLE D3D9 ES2 we're seeing GL_CHROMIUM_framebuffer_multisample but not GL_ANGLE_framebuffer_multisample. The same occurs for ANGLE D3D11 ES2 but kAlpha8 is renderable in that case. TBR=bsalomon@google.com No-Tree-Checks: true No-Try: true No-Presubmit: true Bug: 730082 Change-Id: I2b1ca8da85428426ccdfd2c31d1aa0fd59acb8f9 Reviewed-on: https://skia-review.googlesource.com/20513 Reviewed-by: Ravi Mistry <rmistry@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com> [modify] https://crrev.com/a46f69bf6f3283c8ee71674617f3eb27ad905565/src/gpu/gl/GrGLGpu.cpp [modify] https://crrev.com/a46f69bf6f3283c8ee71674617f3eb27ad905565/src/gpu/gl/GrGLCaps.h [modify] https://crrev.com/a46f69bf6f3283c8ee71674617f3eb27ad905565/src/gpu/gl/GrGLCaps.cpp
,
Jun 23 2017
,
Jun 26 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by enne@chromium.org
, Jun 6 2017Components: -UI Internals>Skia
Status: Available (was: Unconfirmed)