New issue
Advanced search Search tips

Issue 730065 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Add website to message with process id when running with --renderer-startup-dialog

Project Member Reported by flackr@chromium.org, Jun 6 2017

Issue description

When running chrome with --site-per-process we spawn a new process for different sites. This makes debugging the child process renderers difficult, especially in tests where there's no process UI to figure out which PID which site got.

We should add the site to the message if possible, then you could easily attach to the renderer of the site you wanted to debug and resume the other processes.

https://cs.chromium.org/chromium/src/content/renderer/renderer_main.cc?type=cs&q=ChildProcess::WaitForDebugger&l=81
 

Comment 1 by lunalu@chromium.org, Jun 12 2017

Cc: -lunalu@chromium.org loonyb...@chromium.org

Comment 2 by foolip@chromium.org, Dec 15 2017

Cc: haraken@chromium.org
Status: Assigned (was: Untriaged)
Moving from untriaged to assigned since iclelland@ is assigned. But I don't think this is really Blink>Infra. haraken@, you're in the OWNERS file closest to content/renderer/renderer_main.cc, what component should this go in?

Comment 3 by flackr@chromium.org, Jun 28 2018

When I last looked into this the WaitForDebugger call happens way before we know where that process will be navigating. The more pragmatic thing may be to add a flag which outputs the PID and address each time a frame navigates. You could then grep for this from the output and use rr replay to debug the correct process.

Sign in to add a comment