New issue
Advanced search Search tips

Issue 730059 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Chrome paths aren't getting deleted at "HKLM\Software|Microsoft\Windows\CurrentVersion\App Paths\chrome.exe" after Chrome uninstall.

Project Member Reported by pbomm...@chromium.org, Jun 6 2017

Issue description

Chrome Version: 59.0.3071.86
OS: Windows 7, 10

What steps will reproduce the problem?
(1) Install and launch Chrome
(2) Uninstall Chrome 


What is the expected result?
HKLM\Software|Microsoft\Windows\CurrentVersion\App Paths\chrome.exe should be deleted.

What happens instead?
HKLM\Software|Microsoft\Windows\CurrentVersion\App Paths\chrome.exe isn't getting deleted.



 

Comment 1 by grt@chromium.org, Nov 7 2017

Owner: pmonette@chromium.org
Status: Assigned (was: Available)
Hey Patrick. Could you look into fixing this? While we have code to remove this on uninstall in DeleteChromeRegistrationKeys, it doesn't work properly for system-level installs for some reason. It's possible it doesn't work for user-level either, though I'm not sure. Thanks.

Comment 2 by grt@chromium.org, Nov 13 2017

Cc: -grt@chromium.org pmonette@chromium.org
Labels: -Type-Bug Type-Bug-Regression
Owner: grt@chromium.org
Status: Started (was: Assigned)
Nevermind. I found the problem while investigating something else. This is a regression introduced in r442077. I'll send you the fix for review. Thanks.

Comment 3 by grt@chromium.org, Nov 13 2017

 Issue 784153  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47768a910945bdc7b144a9a4e8100ebf77df17ca

commit 47768a910945bdc7b144a9a4e8100ebf77df17ca
Author: Greg Thompson <grt@chromium.org>
Date: Tue Nov 14 06:14:52 2017

Fix deletion of system-level Chrome registration.

A regression suck in in r442077 causing many values to be left behind in
HKLM.

BUG= 730059 
R=pmonette@chromium.org

Change-Id: I6109b2e1480b5f3957db675ee36452a5ec65e16a
Reviewed-on: https://chromium-review.googlesource.com/765491
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516201}
[modify] https://crrev.com/47768a910945bdc7b144a9a4e8100ebf77df17ca/chrome/installer/setup/uninstall.cc

Labels: Needs-Feedback
Tested the issue on Windows 7 / 8.1 / 10 using Chrome# 64.0.3269.0 (revision: 516552) and still able to reproduce the issue.
Chrome paths aren't getting deleted at "HKLM\Software|Microsoft\Windows\CurrentVersion\App Paths\chrome.exe" after Chrome uninstalling Chrome.

Thank You.

Comment 6 by grt@chromium.org, Nov 15 2017

Status: Fixed (was: Started)
I believe this is fixed in 64.0.3269.0:

>reg query "HKLM\Software\Microsoft\Windows\CurrentVersion\App Paths\chrome.exe" /s
ERROR: The system was unable to find the specified registry key or value.

>desktop-5c0tCh%2F64.0.3269.0%2Fwin-clang%2F64.0.3269.0_chrome_installer.exe --system-level --verbose-logging --do-not-launch-chrome --chrome-dev

>reg query "HKLM\Software\Microsoft\Windows\CurrentVersion\App Paths\chrome.exe" /s

HKEY_LOCAL_MACHINE\Software\Microsoft\Windows\CurrentVersion\App Paths\chrome.exe
    (Default)    REG_SZ    C:\Program Files (x86)\Google\Chrome Dev\Application\chrome.exe
    Path    REG_SZ    C:\Program Files (x86)\Google\Chrome Dev\Application

(...uninstall via Programs and Features control panel...)

>reg query "HKLM\Software\Microsoft\Windows\CurrentVersion\App Paths\chrome.exe" /s
ERROR: The system was unable to find the specified registry key or value.

Please provide your repro steps and the contents of the registry key if you find otherwise. Thanks.
Labels: -Needs-Feedback TE-Verified-M64 TE-Verified-64.0.3269.3
Tested the issue using Chrome Dev# 64.0.3269.3 on Windows 7 / 8.1 / 10 and below are the observations.

Steps Followed --
(i) Installed chrome with the command line, "desktop-5c0tCh%2F64.0.3269.3%2Fwin-clang%2F64.0.3269.3_chrome_installer.exe --system-level --verbose-logging --do-not-launch-chrome --chrome-dev
(ii) Navigated to HKLM\Software\Microsoft\Windows\CurrentVersion\App Paths and noticed chrome.exe
(iii) Uninstalled Chrome from Control Panel and navigated to regedit path and noticed that chrome.exe folder has been deleted.

Hence adding TE-Verified labels accordingly.
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e6930911e66781d5a618bfe94862207f7041ce6

commit 9e6930911e66781d5a618bfe94862207f7041ce6
Author: Greg Thompson <grt@chromium.org>
Date: Fri Dec 22 15:59:53 2017

Add test expectations for various registry keys/values being gone after uninstall.

Testing "App Paths" specifically isn't done here since handling of it is
a bit tricky (see https://crbug.com/312092). Coverage added by this
change is a whole lot better than none at all.

BUG= 730059 

Change-Id: I27f34979e1fe5d0c20bc7016577dc921730c57e8
Reviewed-on: https://chromium-review.googlesource.com/842883
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526000}
[modify] https://crrev.com/9e6930911e66781d5a618bfe94862207f7041ce6/chrome/test/mini_installer/config/chrome_beta_not_installed.prop
[modify] https://crrev.com/9e6930911e66781d5a618bfe94862207f7041ce6/chrome/test/mini_installer/config/chrome_canary_not_installed.prop
[modify] https://crrev.com/9e6930911e66781d5a618bfe94862207f7041ce6/chrome/test/mini_installer/config/chrome_dev_not_installed.prop
[modify] https://crrev.com/9e6930911e66781d5a618bfe94862207f7041ce6/chrome/test/mini_installer/config/chrome_system_not_installed.prop
[modify] https://crrev.com/9e6930911e66781d5a618bfe94862207f7041ce6/chrome/test/mini_installer/config/chrome_user_not_installed.prop
[modify] https://crrev.com/9e6930911e66781d5a618bfe94862207f7041ce6/chrome/test/mini_installer/registry_verifier.py
[modify] https://crrev.com/9e6930911e66781d5a618bfe94862207f7041ce6/chrome/test/mini_installer/variable_expander.py

Sign in to add a comment