New issue
Advanced search Search tips

Issue 730055 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::Element::InsertedInto

Project Member Reported by ClusterFuzz, Jun 6 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4901267750256640

Fuzzer: bj_broddelwerk
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000011
Crash State:
  blink::Element::InsertedInto
  blink::SVGElement::InsertedInto
  blink::ContainerNode::NotifyNodeInsertedInternal
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=477224:477239

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4901267750256640


Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jun 6 2017

Labels: OS-Mac

Comment 2 by tkent@chromium.org, Jun 6 2017

Components: Blink>DOM
Owner: tkent@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 3 by ClusterFuzz, Jun 7 2017

Labels: OS-Windows
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93679c17dea4c99e6d654e3d038097e79f0c52f9

commit 93679c17dea4c99e6d654e3d038097e79f0c52f9
Author: Kent Tamura <tkent@chromium.org>
Date: Wed Jun 07 04:21:38 2017

DOM: Fix a crash by replaceChild() and synchronous events.

This CL fixes a regression by crrev.com/477232. It was intended to skip
unnecessary structure check, however raplaceChild() relied on next->parentNode()
check in the skippable part.  This CL adds the check to replaceChild().

Bug:  730055 
Change-Id: Iac2b735d585eee1d517927ab4a5f36e993c8ef25
Reviewed-on: https://chromium-review.googlesource.com/526813
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477545}
[modify] https://crrev.com/93679c17dea4c99e6d654e3d038097e79f0c52f9/third_party/WebKit/LayoutTests/dom/README.md
[add] https://crrev.com/93679c17dea4c99e6d654e3d038097e79f0c52f9/third_party/WebKit/LayoutTests/dom/node/replace_child_recheck.html
[modify] https://crrev.com/93679c17dea4c99e6d654e3d038097e79f0c52f9/third_party/WebKit/Source/core/dom/ContainerNode.cpp

Project Member

Comment 5 by ClusterFuzz, Jun 7 2017

ClusterFuzz has detected this issue as fixed in range 477533:477555.

Detailed report: https://clusterfuzz.com/testcase?key=4901267750256640

Fuzzer: bj_broddelwerk
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000011
Crash State:
  blink::Element::InsertedInto
  blink::SVGElement::InsertedInto
  blink::ContainerNode::NotifyNodeInsertedInternal
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=477224:477239
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=477533:477555

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4901267750256640


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Jun 7 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 4901267750256640 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment