<a download=""> value is ignored
Reported by
starikov...@gmail.com,
Jun 6 2017
|
||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3122.0 Safari/537.36 Steps to reproduce the problem: 1. Create an <a> element with href="data:text/plain, ..." attribute and download attribute that has any value (e. g. "hello world.txt") 2. Click this link What is the expected behavior? hello world.txt file downloads What went wrong? No name.txt file downloaded Did this work before? Yes 58.0.3029.110 (not sure this is latest) Does this work in other browsers? Yes Chrome version: 61.0.3122.0 Channel: canary OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version:
,
Jun 7 2017
,
Jun 7 2017
Able to reproduce the issue on Windows 7, Mac 10.12.4 & Ubuntu 14.04 using chrome latest Canary-61.0.3123.0 & reported version-61.0.3122.0 as per the above html file. Observed "download.txt" file get downloaded instead of "some.txt" after clicking 'Download some.txt' link. jochen@, Seems this issue is similar to #714373. Could you please confirm to proceed further to provide bisect or to duplicate the issue. Thanks.
,
Jun 7 2017
,
Jun 7 2017
,
Jun 8 2017
Able to reproduce the issue on Windows 7, Mac 10.12.4 & Ubuntu 14.04 using chrome latest Canary-61.0.3123.0 Manual Bisect: -------------- Good-60.0.3106.0-Revision-473419 Bad-60.0.3107.0-Revision-473482 Per-revision-bisect info: ------------------------- You are probably looking for a change made after 473427 (known good), but no later than 473428 (first known bad). CHANGELOG URL: The script might not always return single CL as suspectas some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/dcc699ff151393a7d2fa29314befd57d194b0f60..aa36b98fa1c1df77968137cf73dd3244c4559a4e jochen@ Please take a look into this issue. Thanks.
,
Jun 8 2017
,
Jun 12 2017
,
Jun 12 2017
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 12 2017
hi jochen@ - have you already confirmed this fix in canary?
,
Jun 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e09ad54e01d9a94d9bc0480ed7f696f2ca188143 commit e09ad54e01d9a94d9bc0480ed7f696f2ca188143 Author: Jochen Eisinger <jochen@chromium.org> Date: Mon Jun 12 15:50:33 2017 Don't consider about: and data: as cross origin downloads Bug: 730050 Change-Id: Ia11ab0e17995339fa2a620837a0bbb29b789512a Reviewed-on: https://chromium-review.googlesource.com/528235 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#478638} [modify] https://crrev.com/e09ad54e01d9a94d9bc0480ed7f696f2ca188143/content/browser/download/download_request_core.cc
,
Jun 12 2017
Eh, sorry, the cl only landed now... Will ping again after confirming canary
,
Jun 20 2017
Verified the fix on Mac 10.12.5, Win-10 and Ubuntu 14.04 using Chrome dev version #61.0.3135.4 as per the comment #0. Attaching screen cast for reference. Observed that some.txt file downloaded. Hence, the fix is working as expected. Adding the verified labels. Thanks...!!
,
Jun 20 2017
,
Jun 20 2017
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 23 2017
Approving merge to M60.
,
Jun 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/260c644d232118eea29ef51197fb668545da72b4 commit 260c644d232118eea29ef51197fb668545da72b4 Author: Jochen Eisinger <jochen@chromium.org> Date: Tue Jun 27 07:36:22 2017 Don't consider about: and data: as cross origin downloads TBR=jochen@chromium.org (cherry picked from commit e09ad54e01d9a94d9bc0480ed7f696f2ca188143) Bug: 730050 Change-Id: Ia11ab0e17995339fa2a620837a0bbb29b789512a Reviewed-on: https://chromium-review.googlesource.com/528235 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#478638} Reviewed-on: https://chromium-review.googlesource.com/549299 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#476} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/260c644d232118eea29ef51197fb668545da72b4/content/browser/download/download_request_core.cc
,
Jun 28 2017
Verified the fix on Mac 10.12.5, Win-10 and Ubuntu 14.04 using Chrome beta version #60.0.3112.50 as per the comment #0. Attaching screen cast for reference. Observed that some.txt file downloaded. Hence, the fix is working as expected. Adding the verified labels. Thanks...!!
,
Jun 29 2017
Issue 735080 has been merged into this issue.
,
Jun 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9cb51a30376e75d2de0d20db35dc346d0fcf92f4 commit 9cb51a30376e75d2de0d20db35dc346d0fcf92f4 Author: Jochen Eisinger <jochen@chromium.org> Date: Thu Jun 29 20:05:44 2017 Test that suggested filenames for data: URLs work BUG= 730050 , 736304 R=dtrainor@chromium.org Change-Id: I2d0e02adee090787858aea446eafaf9efa22256d Reviewed-on: https://chromium-review.googlesource.com/549896 Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#483459} [modify] https://crrev.com/9cb51a30376e75d2de0d20db35dc346d0fcf92f4/content/browser/download/download_browsertest.cc |
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by woxxom@gmail.com
, Jun 6 2017