[WPT import] When removing expectation lines for deleted tests, virtual tests aren't removed |
|||||
Issue descriptionIn the automatic wpt import today, we hit this problem: There is a file that's removed in the import, and there's a line in a TestExpectations file for a virtual test based on the file that's removed. The virtual test expectation line isn't removed because the test name doesn't exactly match the file that's being removed. Thus, when the import is run, the line isn't removed and as a result there's a presubmit error for a virtual test that doesn't exist. The right behavior would be to remove all lines for all tests that depend on files that are removed. Example builds: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/150 https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/151
,
Jul 3 2017
,
Jul 26 2017
,
Sep 28 2017
Is there an update on this? Can it be assigned to someone?
,
Sep 28 2017
No recent update on this; I think this is still a bug, but not very high priority. There are some wpt subdirectories that have virtual test suites, and so if there are expectation lines for virtual tests and a wpt test is removed upstream, this will cause import to fail. To be totally correct, TestImporter._list_deleted_tests and TestImporter._list_renamed_tests will also have to check for all virtual tests based on deleted or renamed tests. This might involve getting a Port object and using methods there to list virtual tests. https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py?l=522
,
Nov 29 2017
Just checking in on this again, are there any updates?
,
Nov 29 2017
Same status as described in comment 5.
,
Feb 13 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by foolip@chromium.org
, Jul 3 2017