New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 730043 link

Starred by 1 user
Status: Fixed
Owner:
smcgruer@chromium.org
Closed: Aug 2017
Cc:
█ trchen@chromium.org
flackr@chromium.org
yigu@chromium.org
chrishtr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task



Sign in to add a comment

Add class-level documentation with example to StickyPositioNScrollingConstraints

Project Member Reported by yigu@chromium.org, Jun 6 2017 
It's better to document what the class does in detail. e.g. what does total_sticky_box_sticky_offset mean, difference between nearest_sticky_box_shifting_containing_block_ and nearest_sticky_box_shifting_sticky_box, etc.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/979aeb4b47044335a43dbe2d570220cd07589747

commit 979aeb4b47044335a43dbe2d570220cd07589747
Author: smcgruer <smcgruer@chromium.org>
Date: Tue Aug 01 15:15:22 2017

Refactor StickyPositionScrollingConstraints API and add documentation

Main changes:
  1. Removed unused method |NearestStickyAncestor|.
  2. Removed |GetTotalStickyBoxStickyOffset| and
     |GetTotalContainingBlockStickyOffset|, which were only accessed in the
     class implementation so can be accessed directly.
  3. Switched ancestor pointers to PaintLayer rather than LayoutBoxModelObject
     as we always just call ->Layer() on them.
  4. Passed the StickyConstraintsMap into |ComputeStickyOffset| and find the
     ancestors internally, the same way as |GetOffsetForStickyPosition|.

BUG= 730043 ,740070
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2961613002
Cr-Commit-Position: refs/heads/master@{#490996}

[modify] https://crrev.com/979aeb4b47044335a43dbe2d570220cd07589747/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
[modify] https://crrev.com/979aeb4b47044335a43dbe2d570220cd07589747/third_party/WebKit/Source/core/layout/LayoutBoxModelObjectTest.cpp
[modify] https://crrev.com/979aeb4b47044335a43dbe2d570220cd07589747/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/979aeb4b47044335a43dbe2d570220cd07589747/third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.cpp
[modify] https://crrev.com/979aeb4b47044335a43dbe2d570220cd07589747/third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.h

Comment 2 by smcgruer@chromium.org, Aug 1 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment