New issue
Advanced search Search tips

Issue 730041 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocked on:
issue 741072

Blocking:
issue 655753



Sign in to add a comment

Enable CrossProcessFramesForGuests experiment on Beta channel

Project Member Reported by lfg@chromium.org, Jun 6 2017

Issue description

Enable CrossProcessFramesForGuests experiment on Beta channel.


 
Cc: ekaramad@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de612fd93b37b1b369023c7bccc362720837c31e

commit de612fd93b37b1b369023c7bccc362720837c31e
Author: Lucas Furukawa Gadani <lfg@chromium.org>
Date: Tue Jun 06 19:44:55 2017

Change GuestView browsertests to use ScopedFeatureList instead of
appending the switch to the command line.

Bug:  730041 
Change-Id: I7cfdb3fedc1da72e28d332e7fd71ea3455d381e8
Reviewed-on: https://chromium-review.googlesource.com/526132
Reviewed-by: James Maclean <wjmaclean@chromium.org>
Commit-Queue: Lucas Furukawa Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477377}
[modify] https://crrev.com/de612fd93b37b1b369023c7bccc362720837c31e/chrome/browser/apps/guest_view/app_view_browsertest.cc
[modify] https://crrev.com/de612fd93b37b1b369023c7bccc362720837c31e/chrome/browser/apps/guest_view/extension_view/extension_view_browsertest.cc
[modify] https://crrev.com/de612fd93b37b1b369023c7bccc362720837c31e/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/de612fd93b37b1b369023c7bccc362720837c31e/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
[modify] https://crrev.com/de612fd93b37b1b369023c7bccc362720837c31e/extensions/browser/guest_view/app_view/app_view_apitest.cc
[modify] https://crrev.com/de612fd93b37b1b369023c7bccc362720837c31e/extensions/browser/guest_view/extension_options/extension_options_apitest.cc
[modify] https://crrev.com/de612fd93b37b1b369023c7bccc362720837c31e/extensions/browser/guest_view/mime_handler_view/mime_handler_view_browsertest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/796f884131897ac6a2a2eddd9226224b3f5bcaf7

commit 796f884131897ac6a2a2eddd9226224b3f5bcaf7
Author: Lucas Furukawa Gadani <lfg@chromium.org>
Date: Wed Jun 07 16:50:21 2017

Fix WebViewContextMenuInteractiveTest.ContextMenuParamCoordinates when
OOPIF-based guests are enabled.

Bug:  730041 
Change-Id: I67943a3d04c3722e033fbdcba7189a31b449741f
Reviewed-on: https://chromium-review.googlesource.com/526512
Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: James Maclean <wjmaclean@chromium.org>
Commit-Queue: Lucas Furukawa Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477680}
[modify] https://crrev.com/796f884131897ac6a2a2eddd9226224b3f5bcaf7/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/565f65717ec2a36c2112854cc1e8c1e2e20eef2e

commit 565f65717ec2a36c2112854cc1e8c1e2e20eef2e
Author: Lucas Furukawa Gadani <lfg@chromium.org>
Date: Thu Jun 08 17:21:52 2017

Fix ProcessManagerBrowserTest.NestedURLNavigationsToAppBlocked on
OOPIF-based guests.

This CL forces the test to wait until the guest is attached before
proceeding.

Bug:  730041 
Change-Id: Ia024392f02c159c9acd046381e9936c2340ebb92
Reviewed-on: https://chromium-review.googlesource.com/526097
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Lucas Furukawa Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478007}
[modify] https://crrev.com/565f65717ec2a36c2112854cc1e8c1e2e20eef2e/chrome/browser/extensions/process_manager_browsertest.cc
[modify] https://crrev.com/565f65717ec2a36c2112854cc1e8c1e2e20eef2e/components/guest_view/browser/guest_view_manager.h
[modify] https://crrev.com/565f65717ec2a36c2112854cc1e8c1e2e20eef2e/components/guest_view/browser/test_guest_view_manager.cc
[modify] https://crrev.com/565f65717ec2a36c2112854cc1e8c1e2e20eef2e/components/guest_view/browser/test_guest_view_manager.h

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6797871c1bc8330574a957eab616b7806d0b195

commit f6797871c1bc8330574a957eab616b7806d0b195
Author: Lucas Furukawa Gadani <lfg@chromium.org>
Date: Mon Jun 12 15:23:43 2017

Don't call GuestViewInternal.destroyGuest while destroying OOPIF-based
guests.

The OOPIF-based guests are already destroyed by the WebContentsImpl when
the FrameTreeNode is detached (in
WebContentsImpl::WebContentsTreeNode::OnFrameTreeNodeDestroyed).

Bug:  730041 
Change-Id: Ica33f1f289babae30293ee6ae6446936e2136b04
Reviewed-on: https://chromium-review.googlesource.com/528392
Reviewed-by: Paul Meyer <paulmeyer@chromium.org>
Commit-Queue: Lucas Furukawa Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478629}
[modify] https://crrev.com/f6797871c1bc8330574a957eab616b7806d0b195/extensions/renderer/resources/guest_view/guest_view_iframe.js

Comment 6 by lfg@chromium.org, Jul 11 2017

Blockedon: 741072

Comment 7 by lfg@chromium.org, Sep 8 2017

Status: Fixed (was: Assigned)

Sign in to add a comment