New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 730037 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: 0
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature

Blocking:
issue 732481



Sign in to add a comment

Add new search box hint text for launcher.

Project Member Reported by newcomer@chromium.org, Jun 6 2017

Issue description

Add "Search your Chromebook, apps, web..." to chrome/app/generated_resources.grd line 11123

<message name="IDS_SEARCH_BOX_HINT_LAUNCHER_V1" desc="Hint text for the search box in the app list window for the new launcher UI."> Search your Chromebook, apps, web...</message>

https://g3doc.corp.google.com/company/teams/chrome/chrome_localization.md?cl=head

 

Comment 1 by warx@chromium.org, Jun 12 2017

Cc: weidongg@chromium.org newcomer@chromium.org
Owner: warx@chromium.org

Comment 2 by warx@chromium.org, Jun 12 2017

Blocking: 732481
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c84a944f1ac480f9afd1ad93225499c40ddbf0b

commit 6c84a944f1ac480f9afd1ad93225499c40ddbf0b
Author: warx <warx@chromium.org>
Date: Mon Jun 12 23:18:48 2017

cros: add new search box hint text for launcher

R=xiyuan@chromium.org
BUG= 730037 
TEST=tested that enabling the new launcher with
--enable-features=EnableFullscreenAppList, search box will show "Search
your Chromebook, apps, web..." hint text; disabling the flag falls to
current behavior.

Review-Url: https://codereview.chromium.org/2934883002
Cr-Commit-Position: refs/heads/master@{#478815}

[modify] https://crrev.com/6c84a944f1ac480f9afd1ad93225499c40ddbf0b/chrome/app/generated_resources.grd
[modify] https://crrev.com/6c84a944f1ac480f9afd1ad93225499c40ddbf0b/chrome/browser/ui/app_list/search/search_resource_manager.cc

Comment 4 by warx@chromium.org, Jun 13 2017

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified on 9656.0.0, 61.0.3132.0

Sign in to add a comment