Cannot remove last Most Visited tile |
|||||
Issue descriptionWhat steps will reproduce the problem? (1) Remove all tiles on the NTP What is the expected result? All the tiles should be removed. What happens instead? The last one is not removed, the user has to open a new NTP for it to disappear.
,
Jun 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b90a205103775b54fac946c7617222ba9700b544 commit b90a205103775b54fac946c7617222ba9700b544 Author: gambard <gambard@chromium.org> Date: Wed Jun 07 07:02:00 2017 Make possible to remove the last most visited tile The last Most Visited tile could not be removed in the NTP. This CL fixes it. BUG= 730033 Review-Url: https://codereview.chromium.org/2923803002 Cr-Commit-Position: refs/heads/master@{#477569} [modify] https://crrev.com/b90a205103775b54fac946c7617222ba9700b544/ios/chrome/browser/ui/ntp/google_landing_mediator.mm
,
Jun 7 2017
,
Jun 7 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e5d1ab0e8c7c9146044bee7298c185807c76331 commit 6e5d1ab0e8c7c9146044bee7298c185807c76331 Author: gambard <gambard@chromium.org> Date: Wed Jun 07 13:52:03 2017 Make possible to remove the last most visited tile The last Most Visited tile could not be removed in the NTP. This CL fixes it. BUG= 730033 TBR=gambard@chromium.org (cherry picked from commit b90a205103775b54fac946c7617222ba9700b544) Review-Url: https://codereview.chromium.org/2923803002 Cr-Original-Commit-Position: refs/heads/master@{#477569} Change-Id: I34bc008a59221e144febd67af7b9042c085b824f Reviewed-on: https://chromium-review.googlesource.com/527097 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#221} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/6e5d1ab0e8c7c9146044bee7298c185807c76331/ios/chrome/browser/ui/ntp/google_landing_mediator.mm
,
Jun 13 2017
verified the issue on the build 61.0.3128.0 canary tested on iPhone 6(iOS 10). Able to remove all most visited tiles from NTP works fine.
,
Jun 14 2017
Verified the issue on the build 60.0.3112.32 beta tested on iPhone7(iOS10). Able to remove all most visited icons from NTP works fine. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by fhorschig@chromium.org
, Jun 6 2017